[ML] Improve lodash imports for transform plugin.

elastic · Sep 28, 2020 · f503dd4 · f503dd4
1 parent 9313f87
commit f503dd4
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 24 deletions.
diff --git a/.../app/sections/create_transform/components/advanced_pivot_editor/advanced_pivot_editor.tsx b/.../app/sections/create_transform/components/advanced_pivot_editor/advanced_pivot_editor.tsx
@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import isEqual from 'lodash/isEqual';
+import { isEqual } from 'lodash';
 import React, { memo, FC } from 'react';
 
 import { EuiCodeEditor, EuiFormRow } from '@elastic/eui';

diff --git a/...ansform/public/app/sections/create_transform/components/aggregation_list/popover_form.tsx b/...ansform/public/app/sections/create_transform/components/aggregation_list/popover_form.tsx
@@ -18,9 +18,7 @@ import {
   EuiSelectOption,
 } from '@elastic/eui';
 
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import cloneDeep from 'lodash/cloneDeep';
+import { cloneDeep } from 'lodash';
 import { useUpdateEffect } from 'react-use';
 import { AggName } from '../../../../../../common/types/aggregations';
 import { dictionaryToArray } from '../../../../../../common/types/common';

diff --git a/.../create_transform/components/step_define/common/apply_transform_config_to_define_state.ts b/.../create_transform/components/step_define/common/apply_transform_config_to_define_state.ts
@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import isEqual from 'lodash/isEqual';
+import { isEqual } from 'lodash';
 
 import { Dictionary } from '../../../../../../../common/types/common';
 import { PivotSupportedAggs } from '../../../../../../../common/types/pivot_aggs';

diff --git a/...create_transform/components/step_define/common/filter_agg/components/filter_term_form.tsx b/...create_transform/components/step_define/common/filter_agg/components/filter_term_form.tsx
@@ -7,9 +7,7 @@
 import React, { useCallback, useContext, useEffect, useState } from 'react';
 import { EuiComboBox, EuiFormRow } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import debounce from 'lodash/debounce';
+import { debounce } from 'lodash';
 import { useUpdateEffect } from 'react-use';
 import { i18n } from '@kbn/i18n';
 import { isEsSearchResponse } from '../../../../../../../../../common/api_schemas/type_guards';

diff --git a/...ctions/transform_management/components/edit_transform_flyout/use_edit_transform_flyout.ts b/...ctions/transform_management/components/edit_transform_flyout/use_edit_transform_flyout.ts
@@ -4,12 +4,8 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import isEqual from 'lodash/isEqual';
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import merge from 'lodash/merge';
+import { isEqual } from 'lodash';
+import { merge } from 'lodash';
 
 import { useReducer } from 'react';
 

diff --git a/.../public/app/sections/transform_management/components/transform_list/use_table_settings.ts b/.../public/app/sections/transform_management/components/transform_list/use_table_settings.ts
@@ -6,12 +6,8 @@
 
 import { useState } from 'react';
 import { Direction, EuiBasicTableProps, EuiTableSortingType } from '@elastic/eui';
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import sortBy from 'lodash/sortBy';
-// Prefer importing entire lodash library, e.g. import { get } from "lodash"
-// eslint-disable-next-line no-restricted-imports
-import get from 'lodash/get';
+import { sortBy } from 'lodash';
+import { get } from 'lodash';
 
 const PAGE_SIZE = 10;
 const PAGE_SIZE_OPTIONS = [10, 25, 50];