Skip to content

Commit

Permalink
[Saved Seaches] Unskip embeddable Jest tests and only skip the actual…
Browse files Browse the repository at this point in the history
… flaky test (#164003)

In #162997, the entire saved search embeddable Jest test suite was
skipped instead of just the flaky test. This PR doesn't fix the flaky
test, but unskips the test suite and instead only skips the flaky test
to ensure the other tests run.
  • Loading branch information
davismcphee authored Aug 16, 2023
1 parent bfd7c7f commit f4b925c
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ const createSearchFnMock = (nrOfHits: number) => {

const dataViewMock = buildDataViewMock({ name: 'the-data-view', fields: deepMockedFields });

// FLAKY: https://github.com/elastic/kibana/issues/162997
describe.skip('saved search embeddable', () => {
describe('saved search embeddable', () => {
let mountpoint: HTMLDivElement;
let servicesMock: jest.Mocked<DiscoverServices>;

Expand Down Expand Up @@ -322,7 +321,8 @@ describe.skip('saved search embeddable', () => {
expect(search).toHaveBeenCalledTimes(1);
});

it('should not reload when the input title doesnt change', async () => {
// FLAKY: https://github.com/elastic/kibana/issues/162997
it.skip('should not reload when the input title doesnt change', async () => {
const search = jest.fn().mockReturnValue(getSearchResponse(1));
const { embeddable } = createEmbeddable({ searchMock: search, customTitle: 'custom title' });
await waitOneTick();
Expand Down

0 comments on commit f4b925c

Please sign in to comment.