Skip to content

Commit

Permalink
[Watcher] Reverting incorrectly removed scope parameters (#37875)
Browse files Browse the repository at this point in the history
* [Watcher] Reverting incorrectly removed scope parameters

* removing  no-unused-vars comments
  • Loading branch information
jgowdyelastic committed Jun 4, 2019
1 parent dbb6b4b commit f1a24b5
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ app.directive('durationSelect', function ($injector) {
replace: true,
controllerAs: 'durationSelect',
bindToController: true,
link: function ($scope, $ctrl) {
link: function ($scope, $element, $attrs, $ctrl) {
$scope.durationSelect.form = $ctrl;
},
controller: class DurationSelectController extends InitAfterBindingsWorkaround {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ app.directive('kbnTab', function () {
controllerAs: 'kbnTab',
bindToController: true,
controller: class KbnTabController {},
link: function ($scope, kbnTabs) {
link: function ($scope, $ele, attrs, kbnTabs) {
$scope.kbnTabs = kbnTabs;
}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const app = uiModules.get('xpack/watcher');
app.directive('xpackAriaDescribes', function () {
return {
restrict: 'A',
link: function ($scope, attr) {
link: function ($scope, $ele, attr) {
if (!Object.keys(attr).includes('id')) {
throw new Error(`An element with xpack-aria-describes="${attr.xpackAriaDescribes}" does not have an id attribute defined`);
}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/watcher/public/directives/json_input.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ uiModules
return {
restrict: 'A',
require: 'ngModel',
link: function (scope, attrs, ngModelCntrl) {
link: function (scope, $el, attrs, ngModelCntrl) {
ngModelCntrl.$formatters.push(toJSON);
ngModelCntrl.$parsers.push(fromJSON);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ uiModules.get('xpack/watcher')
transclude: true,
replace: true,
scope: true,
link: function ($scope, attr) {
link: function ($scope, $el, attr) {
$scope.text = attr.text;
$scope.placement = attr.placement || 'top';
$scope.delay = attr.delay || 400;
Expand Down

0 comments on commit f1a24b5

Please sign in to comment.