Skip to content

Commit

Permalink
[8.15] [Lens][FTR] Fix afterAll issue (#189069) (#189181)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Lens][FTR] Fix afterAll issue
(#189069)](#189069)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-25T12:48:28Z","message":"[Lens][FTR]
Fix afterAll issue (#189069)\n\n## Summary\r\n\r\nFixes #189056,
#189057, #164623\r\n\r\nBring back the window handler for other tests
correctly.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c47f3714710fe76f9f94463d3b5dd8569f5b19bf","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.15.0","v8.16.0"],"title":"[Lens][FTR]
Fix afterAll
issue","number":189069,"url":"https://github.com/elastic/kibana/pull/189069","mergeCommit":{"message":"[Lens][FTR]
Fix afterAll issue (#189069)\n\n## Summary\r\n\r\nFixes #189056,
#189057, #164623\r\n\r\nBring back the window handler for other tests
correctly.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c47f3714710fe76f9f94463d3b5dd8569f5b19bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189069","number":189069,"mergeCommit":{"message":"[Lens][FTR]
Fix afterAll issue (#189069)\n\n## Summary\r\n\r\nFixes #189056,
#189057, #164623\r\n\r\nBring back the window handler for other tests
correctly.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c47f3714710fe76f9f94463d3b5dd8569f5b19bf"}}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <[email protected]>
  • Loading branch information
kibanamachine and dej611 authored Jul 25, 2024
1 parent 0c1dea0 commit ef1f623
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 3 additions & 2 deletions x-pack/test/functional/apps/lens/group1/ad_hoc_data_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await dataViews.isAdHoc()).to.be(true);
};

// Failing: See https://github.com/elastic/kibana/issues/164623
describe.skip('lens ad hoc data view tests', () => {
describe('lens ad hoc data view tests', () => {
it('should allow building a chart based on ad hoc data view', async () => {
await setupAdHocDataView();
await PageObjects.lens.configureDimension({
Expand Down Expand Up @@ -223,6 +222,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await dataViews.isAdHoc()).to.be(true);

await browser.closeCurrentWindow();
const [lensHandle] = await browser.getAllWindowHandles();
await browser.switchToWindow(lensHandle);
});

// Failing: See https://github.com/elastic/kibana/issues/164623
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/lens/group1/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ export default ({ getService, loadTestFile, getPageObjects }: FtrProviderContext
const config = getService('config');
let remoteEsArchiver;

// FLAKY: https://github.com/elastic/kibana/issues/189057
describe.skip('lens app - group 1', () => {
describe('lens app - group 1', () => {
const esArchive = 'x-pack/test/functional/es_archives/logstash_functional';
const localIndexPatternString = 'logstash-*';
const remoteIndexPatternString = 'ftr-remote:logstash-*';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
).to.eql(expectedData);
}

// Failing: See https://github.com/elastic/kibana/issues/189056
describe.skip('lens with multiple data views', () => {
describe('lens with multiple data views', () => {
const visTitle = 'xyChart with multiple data views';

before(async () => {
Expand Down

0 comments on commit ef1f623

Please sign in to comment.