[QA] Unskip functional tests (#69760)

* [functional tests] unskip dashboard state * [functional tests] unskip empty dashboard, reference ES issue * [functional tests] unskip data_table_nontime_index * [functional tests] unskip viz builder tests * link existing issue Co-authored-by: Elastic Machine <[email protected]>
elastic · Jun 25, 2020 · ec40593 · ec40593
1 parent f7acbbe
commit ec40593
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 67 deletions.
diff --git a/test/functional/apps/dashboard/dashboard_state.js b/test/functional/apps/dashboard/dashboard_state.js
@@ -251,8 +251,7 @@ export default function ({ getService, getPageObjects }) {
           });
         });
 
-        // Unskip once https://github.com/elastic/kibana/issues/15736 is fixed.
-        it.skip('and updates the pie slice legend color', async function () {
+        it('and updates the pie slice legend color', async function () {
           await retry.try(async () => {
             const colorExists = await PageObjects.visChart.doesSelectedLegendColorExist('#FFFFFF');
             expect(colorExists).to.be(true);
@@ -272,8 +271,7 @@ export default function ({ getService, getPageObjects }) {
           });
         });
 
-        // Unskip once https://github.com/elastic/kibana/issues/15736 is fixed.
-        it.skip('resets the legend color as well', async function () {
+        it('resets the legend color as well', async function () {
           await retry.try(async () => {
             const colorExists = await PageObjects.visChart.doesSelectedLegendColorExist('#57c17b');
             expect(colorExists).to.be(true);

diff --git a/test/functional/apps/dashboard/empty_dashboard.js b/test/functional/apps/dashboard/empty_dashboard.js
@@ -49,10 +49,11 @@ export default function ({ getService, getPageObjects }) {
       expect(emptyWidgetExists).to.be(true);
     });
 
-    it.skip('should open add panel when add button is clicked', async () => {
+    it('should open add panel when add button is clicked', async () => {
       await testSubjects.click('dashboardAddPanelButton');
       const isAddPanelOpen = await dashboardAddPanel.isAddPanelOpen();
       expect(isAddPanelOpen).to.be(true);
+      await testSubjects.click('euiFlyoutCloseButton');
     });
 
     it('should add new visualization from dashboard', async () => {

diff --git a/test/functional/apps/discover/_errors.js b/test/functional/apps/discover/_errors.js
@@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }) {
       await esArchiver.unload('invalid_scripted_field');
     });
 
-    // https://github.com/elastic/kibana/issues/61366
+    // ES issue https://github.com/elastic/elasticsearch/issues/54235
     describe.skip('invalid scripted field error', () => {
       it('is rendered', async () => {
         const isFetchErrorVisible = await testSubjects.exists('discoverFetchError');

diff --git a/test/functional/apps/visualize/_data_table_nontimeindex.js b/test/functional/apps/visualize/_data_table_nontimeindex.js
@@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }) {
   const renderable = getService('renderable');
   const PageObjects = getPageObjects(['visualize', 'visEditor', 'header', 'visChart']);
 
-  describe.skip('data table with index without time filter', function indexPatternCreation() {
+  describe('data table with index without time filter', function indexPatternCreation() {
     const vizName1 = 'Visualization DataTable without time filter';
 
     before(async function () {
@@ -112,65 +112,49 @@ export default function ({ getService, getPageObjects }) {
       expect(data.trim().split('\n')).to.be.eql(['14,004 1,412.6']);
     });
 
-    it('should show correct data for a data table with date histogram', async () => {
-      await PageObjects.visualize.navigateToNewVisualization();
-      await PageObjects.visualize.clickDataTable();
-      await PageObjects.visualize.clickNewSearch(
-        PageObjects.visualize.index.LOGSTASH_NON_TIME_BASED
-      );
-      await PageObjects.visEditor.clickBucket('Split rows');
-      await PageObjects.visEditor.selectAggregation('Date Histogram');
-      await PageObjects.visEditor.selectField('@timestamp');
-      await PageObjects.visEditor.setInterval('Daily');
-      await PageObjects.visEditor.clickGo();
-      const data = await PageObjects.visChart.getTableVisData();
-      log.debug(data.split('\n'));
-      expect(data.trim().split('\n')).to.be.eql([
-        '2015-09-20',
-        '4,757',
-        '2015-09-21',
-        '4,614',
-        '2015-09-22',
-        '4,633',
-      ]);
-    });
+    // bug https://github.com/elastic/kibana/issues/68977
+    describe.skip('data table with date histogram', async () => {
+      before(async () => {
+        await PageObjects.visualize.navigateToNewVisualization();
+        await PageObjects.visualize.clickDataTable();
+        await PageObjects.visualize.clickNewSearch(
+          PageObjects.visualize.index.LOGSTASH_NON_TIME_BASED
+        );
+        await PageObjects.visEditor.clickBucket('Split rows');
+        await PageObjects.visEditor.selectAggregation('Date Histogram');
+        await PageObjects.visEditor.selectField('@timestamp');
+        await PageObjects.visEditor.setInterval('Daily');
+        await PageObjects.visEditor.clickGo();
+      });
 
-    it('should show correct data for a data table with date histogram', async () => {
-      await PageObjects.visualize.navigateToNewVisualization();
-      await PageObjects.visualize.clickDataTable();
-      await PageObjects.visualize.clickNewSearch(
-        PageObjects.visualize.index.LOGSTASH_NON_TIME_BASED
-      );
-      await PageObjects.visEditor.clickBucket('Split rows');
-      await PageObjects.visEditor.selectAggregation('Date Histogram');
-      await PageObjects.visEditor.selectField('@timestamp');
-      await PageObjects.visEditor.setInterval('Daily');
-      await PageObjects.visEditor.clickGo();
-      const data = await PageObjects.visChart.getTableVisData();
-      expect(data.trim().split('\n')).to.be.eql([
-        '2015-09-20',
-        '4,757',
-        '2015-09-21',
-        '4,614',
-        '2015-09-22',
-        '4,633',
-      ]);
-    });
+      it('should show correct data', async () => {
+        const data = await PageObjects.visChart.getTableVisData();
+        log.debug(data.split('\n'));
+        expect(data.trim().split('\n')).to.be.eql([
+          '2015-09-20',
+          '4,757',
+          '2015-09-21',
+          '4,614',
+          '2015-09-22',
+          '4,633',
+        ]);
+      });
 
-    it('should correctly filter for applied time filter on the main timefield', async () => {
-      await filterBar.addFilter('@timestamp', 'is between', '2015-09-19', '2015-09-21');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      await renderable.waitForRender();
-      const data = await PageObjects.visChart.getTableVisData();
-      expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
-    });
+      it('should correctly filter for applied time filter on the main timefield', async () => {
+        await filterBar.addFilter('@timestamp', 'is between', '2015-09-19', '2015-09-21');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await renderable.waitForRender();
+        const data = await PageObjects.visChart.getTableVisData();
+        expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
+      });
 
-    it('should correctly filter for pinned filters', async () => {
-      await filterBar.toggleFilterPinned('@timestamp');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      await renderable.waitForRender();
-      const data = await PageObjects.visChart.getTableVisData();
-      expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
+      it('should correctly filter for pinned filters', async () => {
+        await filterBar.toggleFilterPinned('@timestamp');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await renderable.waitForRender();
+        const data = await PageObjects.visChart.getTableVisData();
+        expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
+      });
     });
   });
 }
diff --git a/test/functional/apps/visualize/_tsvb_chart.ts b/test/functional/apps/visualize/_tsvb_chart.ts
@@ -28,8 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const security = getService('security');
   const PageObjects = getPageObjects(['visualize', 'visualBuilder', 'timePicker', 'visChart']);
 
-  // FLAKY: https://github.com/elastic/kibana/issues/43150
-  describe.skip('visual builder', function describeIndexTests() {
+  describe('visual builder', function describeIndexTests() {
     this.tags('includeFirefox');
     beforeEach(async () => {
       await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
@@ -74,7 +73,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
     });
 
-    // FLAKY: https://github.com/elastic/kibana/issues/46677
     describe('gauge', () => {
       beforeEach(async () => {
         await PageObjects.visualBuilder.resetPage();
@@ -107,7 +105,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
     });
 
-    describe('switch index patterns', () => {
+    // FLAKY: https://github.com/elastic/kibana/issues/43150
+    describe.skip('switch index patterns', () => {
       beforeEach(async () => {
         log.debug('Load kibana_sample_data_flights data');
         await esArchiver.loadIfNeeded('kibana_sample_data_flights');