Skip to content

Commit

Permalink
[Security solution][Detections] increases test coverage for bulk edit (
Browse files Browse the repository at this point in the history
…#137165)

## Summary

- addresses #135201, apart from data views
- adds tests for scenarios in test plan: [internal document](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#)
- adds data-test-subj attributes to error toasts


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
  • Loading branch information
vitaliidm authored Aug 30, 2022
1 parent 04d1ffe commit eb525ce
Show file tree
Hide file tree
Showing 16 changed files with 1,149 additions and 408 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function showErrorDialog({
<EuiModalHeader>
<EuiModalHeaderTitle>{title}</EuiModalHeaderTitle>
</EuiModalHeader>
<EuiModalBody>
<EuiModalBody data-test-subj="errorModalBody">
<EuiCallOut size="s" color="danger" iconType="alert" title={error.message} />
{text && (
<React.Fragment>
Expand Down Expand Up @@ -112,6 +112,7 @@ export function ErrorToast({
<EuiButton
size="s"
color="danger"
data-test-subj="errorToastBtn"
onClick={() => showErrorDialog({ title, error, openModal, i18nContext })}
>
<FormattedMessage
Expand Down
Loading

0 comments on commit eb525ce

Please sign in to comment.