more strict 2

elastic · Aug 13, 2020 · e9a809e · e9a809e
1 parent 1c76cbd
commit e9a809e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/x-pack/plugins/reporting/server/export_types/csv/create_job.ts b/x-pack/plugins/reporting/server/export_types/csv/create_job.ts
@@ -24,9 +24,9 @@ export const scheduleTaskFnFactory: ScheduleTaskFnFactory<CreateJobFn<
     );
 
     return {
-      ...jobParams,
       headers: serializedEncryptedHeaders,
       indexPatternSavedObject,
+      ...jobParams,
     };
   };
 };
diff --git a/x-pack/plugins/reporting/server/export_types/csv/types.d.ts b/x-pack/plugins/reporting/server/export_types/csv/types.d.ts
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { ScheduledTaskParams } from '../../types';
+import { CreateJobBaseParams, ScheduledTaskParams } from '../../types';
 
 export type RawValue = string | object | null | undefined;
 
@@ -28,10 +28,8 @@ export interface IndexPatternSavedObject {
   };
 }
 
-export interface JobParamsDiscoverCsv {
-  browserTimezone: string;
+export interface JobParamsDiscoverCsv extends CreateJobBaseParams {
   indexPatternId: string;
-  objectType: string;
   title: string;
   searchRequest: SearchRequest;
   fields: string[];

diff --git a/x-pack/plugins/reporting/server/export_types/printable_pdf/types.d.ts b/x-pack/plugins/reporting/server/export_types/printable_pdf/types.d.ts
@@ -8,11 +8,9 @@ import { CreateJobBaseParams, ScheduledTaskParams } from '../../../server/types'
 import { LayoutInstance, LayoutParams } from '../../lib/layouts';
 
 // Job params: structure of incoming user request data, after being parsed from RISON
-export interface JobParamsPDF {
-  objectType: string; // visualization, dashboard, etc. Used for job info & telemetry
+export interface JobParamsPDF extends CreateJobBaseParams {
   title: string;
   relativeUrls: string[];
-  browserTimezone: string;
   layout: LayoutInstance;
 }