range slider step default

elastic · Aug 1, 2024 · e938b08 · e938b08
1 parent 80b45ac
commit e938b08
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/...ublic/react_controls/data_controls/range_slider/get_range_slider_control_factory.test.tsx b/...ublic/react_controls/data_controls/range_slider/get_range_slider_control_factory.test.tsx
@@ -204,6 +204,20 @@ describe('RangesliderControlApi', () => {
   });
 
   describe('step state', () => {
+    test('default value provided when state.step is undefined', async () => {
+      const { api } = await factory.buildControl(
+        {
+          dataViewId: 'myDataViewId',
+          fieldName: 'myFieldName',
+        },
+        getMockedBuildApi(uuid, factory, controlGroupApi),
+        uuid,
+        controlGroupApi
+      );
+      const serializedState = api.serializeState() as SerializedPanelState<RangesliderControlState>;
+      expect(serializedState.rawState.step).toBe(1);
+    });
+
     test('retains value from initial state', async () => {
       const { api } = await factory.buildControl(
         {
@@ -272,4 +286,4 @@ describe('RangesliderControlApi', () => {
       expect(setControlEditorValid).toBeCalledWith(true);
     });
   });
-});
+});
diff --git a/...ple/public/react_controls/data_controls/range_slider/get_range_slider_control_factory.tsx b/...ple/public/react_controls/data_controls/range_slider/get_range_slider_control_factory.tsx
@@ -61,7 +61,7 @@ export const getRangesliderControlFactory = (
       const loadingMinMax$ = new BehaviorSubject<boolean>(false);
       const loadingHasNoResults$ = new BehaviorSubject<boolean>(false);
       const dataLoading$ = new BehaviorSubject<boolean | undefined>(undefined);
-      const step$ = new BehaviorSubject<number | undefined>(initialState.step);
+      const step$ = new BehaviorSubject<number | undefined>(initialState.step ?? 1);
       const value$ = new BehaviorSubject<RangeValue | undefined>(initialState.value);
       function setValue(nextValue: RangeValue | undefined) {
         value$.next(nextValue);
@@ -100,7 +100,11 @@ export const getRangesliderControlFactory = (
         },
         {
           ...dataControl.comparators,
-          step: [step$, (nextStep: number | undefined) => step$.next(nextStep)],
+          step: [
+            step$,
+            (nextStep: number | undefined) => step$.next(nextStep),
+            (a, b) => (a ?? 1) === (b ?? 1),
+          ],
           value: [value$, setValue],
         }
       );