🐛 Fix first rendering ghost issue

elastic · Mar 31, 2023 · e8c4e5f · e8c4e5f
1 parent 39ca589
commit e8c4e5f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/x-pack/plugins/lens/public/app_plugin/get_application_user_messages.test.tsx b/x-pack/plugins/lens/public/app_plugin/get_application_user_messages.test.tsx
@@ -149,7 +149,7 @@ describe('application-level user messages', () => {
           activeDatasource: {
             checkIntegrity: jest.fn(() => ['missing_pattern']),
           } as unknown as Datasource,
-          activeDatasourceState: { state: {} },
+          activeDatasourceState: { isLoading: false, state: {} },
           core: createCoreStartWithPermissions(),
           ...irrelevantProps,
         })
@@ -166,7 +166,7 @@ describe('application-level user messages', () => {
                 activeDatasource: {
                   checkIntegrity: jest.fn(() => ['missing_pattern']),
                 } as unknown as Datasource,
-                activeDatasourceState: { state: {} },
+                activeDatasourceState: { isLoading: false, state: {} },
                 // user can go to management, but indexPatterns management is not accessible
                 core: createCoreStartWithPermissions({
                   navLinks: { management: true },
@@ -188,7 +188,7 @@ describe('application-level user messages', () => {
                 activeDatasource: {
                   checkIntegrity: jest.fn(() => ['missing_pattern']),
                 } as unknown as Datasource,
-                activeDatasourceState: { state: {} },
+                activeDatasourceState: { isLoading: false, state: {} },
                 // user can't go to management at all
                 core: createCoreStartWithPermissions({
                   navLinks: { management: false },

diff --git a/x-pack/plugins/lens/public/app_plugin/get_application_user_messages.tsx b/x-pack/plugins/lens/public/app_plugin/get_application_user_messages.tsx
@@ -36,7 +36,7 @@ export const getApplicationUserMessages = ({
   visualization: VisualizationState | undefined;
   visualizationMap: VisualizationMap;
   activeDatasource: Datasource | null | undefined;
-  activeDatasourceState: { state: unknown } | null;
+  activeDatasourceState: { isLoading: boolean; state: unknown } | null;
   dataViews: DataViewsState;
   core: CoreStart;
 }): UserMessage[] => {

diff --git a/x-pack/plugins/lens/public/editor_frame_service/editor_frame/state_helpers.ts b/x-pack/plugins/lens/public/editor_frame_service/editor_frame/state_helpers.ts
@@ -404,10 +404,14 @@ export async function persistedStateToExpression(
 
 export function getMissingIndexPattern(
   currentDatasource: Datasource | null | undefined,
-  currentDatasourceState: { state: unknown } | null,
+  currentDatasourceState: { isLoading: boolean; state: unknown } | null,
   indexPatterns: IndexPatternMap
 ) {
-  if (currentDatasourceState?.state == null || currentDatasource == null) {
+  if (
+    currentDatasourceState?.isLoading ||
+    currentDatasourceState?.state == null ||
+    currentDatasource == null
+  ) {
     return [];
   }
   const missingIds = currentDatasource.checkIntegrity(currentDatasourceState.state, indexPatterns);

diff --git a/x-pack/plugins/lens/public/embeddable/embeddable.tsx b/x-pack/plugins/lens/public/embeddable/embeddable.tsx
@@ -569,7 +569,10 @@ export class Embeddable
         },
         visualizationMap: this.deps.visualizationMap,
         activeDatasource: this.activeDatasource,
-        activeDatasourceState: { state: this.activeDatasourceState },
+        activeDatasourceState: {
+          isLoading: Boolean(this.activeDatasourceState),
+          state: this.activeDatasourceState,
+        },
         dataViews: {
           indexPatterns: this.indexPatterns,
           indexPatternRefs: this.indexPatternRefs, // TODO - are these actually used?