change the version missing response

elastic · Apr 3, 2023 · e723e06 · e723e06
1 parent 5388234
commit e723e06
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/...e/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.test.ts b/...e/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.test.ts
@@ -193,7 +193,7 @@ describe('Versioned route', () => {
     ).resolves.toEqual(
       expect.objectContaining({
         payload:
-          'No version "999" available for [post] [/test/{id}]. Available versions are: "none"',
+          'No version "999" available for [post] [/test/{id}]. Available versions are: <none>',
         status: 406,
       })
     );
@@ -212,7 +212,7 @@ describe('Versioned route', () => {
       handler!({} as any, createRequest({ version: undefined }), responseFactory)
     ).resolves.toEqual({
       options: {},
-      payload: `Version expected at [post] [/test/{id}]. Please specify a version using the "${ELASTIC_HTTP_VERSION_HEADER}" header. Available versions are: "1"`,
+      payload: `Version expected at [post] [/test/{id}]. Please specify a version using the "${ELASTIC_HTTP_VERSION_HEADER}" header. Available versions are: [1]`,
       status: 406,
     });
   });

diff --git a/...s/core/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.ts b/...s/core/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.ts
@@ -77,7 +77,10 @@ export class CoreVersionedRoute implements VersionedRoute {
   }
 
   private getAvailableVersionsMessage(): string {
-    return `Available versions are: "${[...this.handlers.keys()].join(',') || 'none'}"`;
+    const versions = [...this.handlers.keys()];
+    return `Available versions are: ${
+      versions.length ? '[' + [...versions].join(', ') + ']' : '<none>'
+    }`;
   }
 
   /** This is where we must implement the versioned spec once it is available */

diff --git a/src/core/server/integration_tests/http/versioned_router.test.ts b/src/core/server/integration_tests/http/versioned_router.test.ts
@@ -101,8 +101,7 @@ describe('Routing versioned requests', () => {
         .then(({ body }) => body)
     ).resolves.toEqual(
       expect.objectContaining({
-        message:
-          'Version expected at [get] [/my-path]. Please specify a version using the "elastic-api-version" header. Available versions are: "1,2"',
+        message: expect.stringMatching(/Version expected at/),
       })
     );
   });