[Detection Engine] Adding second quality gate tags (#189659)

## Summary - Added second quality gate tags to some exception FTRs - Unskipped one test that I couldn't get to flake (and ran through flakey test runner) - Added comment about adding suppression tests to second quality gate once its GA
elastic · Aug 6, 2024 · e6e9b99 · e6e9b99
1 parent 99cb9b7
commit e6e9b99
Show file tree

Hide file tree

Showing 38 changed files with 41 additions and 36 deletions.
diff --git a/...on_engine/exceptions/workflows/basic_license_essentials_tier/rule_exceptions_execution.ts b/...on_engine/exceptions/workflows/basic_license_essentials_tier/rule_exceptions_execution.ts
@@ -67,8 +67,7 @@ export default ({ getService }: FtrProviderContext) => {
       await esArchiver.unload(path);
     });
 
-    // FLAKY: https://github.com/elastic/kibana/issues/181887
-    describe.skip('creating rules with exceptions', () => {
+    describe('creating rules with exceptions', () => {
       beforeEach(async () => {
         await createAlertsIndex(supertest, log);
       });

diff --git a/...rule_execution_logic/trial_license_complete_tier/execution_logic/eql_alert_suppression.ts b/...rule_execution_logic/trial_license_complete_tier/execution_logic/eql_alert_suppression.ts
@@ -64,6 +64,7 @@ export default ({ getService }: FtrProviderContext) => {
     log,
   });
 
+  // NOTE: Add to second quality gate after feature is GA
   describe('@ess @serverless Alert Suppression for EQL rules', () => {
     before(async () => {
       await esArchiver.load('x-pack/test/functional/es_archives/security_solution/ecs_compliant');

diff --git a/...gine/rule_execution_logic/trial_license_complete_tier/execution_logic/esql_suppression.ts b/...gine/rule_execution_logic/trial_license_complete_tier/execution_logic/esql_suppression.ts
@@ -64,6 +64,7 @@ export default ({ getService }: FtrProviderContext) => {
   const getNonAggRuleQueryWithMetadata = (id: string) =>
     `from ecs_compliant metadata _id, _index, _version ${internalIdPipe(id)}`;
 
+  // NOTE: Add to second quality gate after feature is GA
   describe('@ess @serverless ES|QL rule type, alert suppression', () => {
     before(async () => {
       await esArchiver.load('x-pack/test/functional/es_archives/security_solution/ecs_compliant');

diff --git a/...on_logic/trial_license_complete_tier/execution_logic/indicator_match_alert_suppression.ts b/...on_logic/trial_license_complete_tier/execution_logic/indicator_match_alert_suppression.ts
@@ -158,7 +158,8 @@ export default ({ getService }: FtrProviderContext) => {
     },
   ];
 
-  describe('@ess @serverless @serverlessQA Indicator match type rules, alert suppression', () => {
+  // NOTE: Add to second quality gate after feature is GA
+  describe('@ess @serverless Indicator match type rules, alert suppression', () => {
     before(async () => {
       await esArchiver.load('x-pack/test/functional/es_archives/security_solution/ecs_compliant');
     });

diff --git a/...n_logic/trial_license_complete_tier/execution_logic/machine_learning_alert_suppression.ts b/...n_logic/trial_license_complete_tier/execution_logic/machine_learning_alert_suppression.ts
@@ -88,6 +88,7 @@ export default ({ getService }: FtrProviderContext) => {
     'user.name': ['root'],
   };
 
+  // NOTE: Add to second quality gate after feature is GA
   describe('@ess @serverless Machine Learning Detection Rule - Alert Suppression', () => {
     describe('with an active ML Job', () => {
       before(async () => {

diff --git a/...xecution_logic/trial_license_complete_tier/execution_logic/new_terms_alert_suppression.ts b/...xecution_logic/trial_license_complete_tier/execution_logic/new_terms_alert_suppression.ts
@@ -56,7 +56,8 @@ export default ({ getService }: FtrProviderContext) => {
 
   const historicalWindowStart = '2019-10-13T05:00:04.000Z';
 
-  describe('@ess @serverless @serverlessQA New terms type rules, alert suppression', () => {
+  // NOTE: Add to second quality gate after feature is GA
+  describe('@ess @serverless New terms type rules, alert suppression', () => {
     before(async () => {
       await esArchiver.load('x-pack/test/functional/es_archives/security_solution/ecs_compliant');
     });

diff --git a/...xecution_logic/trial_license_complete_tier/execution_logic/threshold_alert_suppression.ts b/...xecution_logic/trial_license_complete_tier/execution_logic/threshold_alert_suppression.ts
@@ -51,7 +51,8 @@ export default ({ getService }: FtrProviderContext) => {
   const dataPathBuilder = new EsArchivePathBuilder(isServerless);
   const path = dataPathBuilder.getPath('auditbeat/hosts');
 
-  describe('@ess @serverless @serverlessQA Threshold type rules, alert suppression', () => {
+  // NOTE: Add to second quality gate after feature is GA
+  describe('@ess @serverless Threshold type rules, alert suppression', () => {
     const { indexListOfDocuments, indexGeneratedDocuments } = dataGeneratorFactory({
       es,
       index: 'ecs_compliant',

diff --git a/...ts/exception_lists_items/trial_license_complete_tier/items/create_exception_list_items.ts b/...ts/exception_lists_items/trial_license_complete_tier/items/create_exception_list_items.ts
@@ -28,7 +28,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless create_exception_list_items', () => {
+  describe('@ess @serverless @serverlessQA create_exception_list_items', () => {
     describe('validation errors', () => {
       it('should give a 404 error that the exception list must exist first before being able to add a list item to the exception list', async () => {
         const { body } = await supertest

diff --git a/...ts/exception_lists_items/trial_license_complete_tier/items/delete_exception_list_items.ts b/...ts/exception_lists_items/trial_license_complete_tier/items/delete_exception_list_items.ts
@@ -28,7 +28,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless delete_exception_list_items', () => {
+  describe('@ess @serverless @serverlessQA delete_exception_list_items', () => {
     describe('delete exception list items', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...ists/exception_lists_items/trial_license_complete_tier/items/find_exception_list_items.ts b/...ists/exception_lists_items/trial_license_complete_tier/items/find_exception_list_items.ts
@@ -30,7 +30,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless find_exception_list_items', () => {
+  describe('@ess @serverless @serverlessQA find_exception_list_items', () => {
     describe('find exception list items', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...ists/exception_lists_items/trial_license_complete_tier/items/read_exception_list_items.ts b/...ists/exception_lists_items/trial_license_complete_tier/items/read_exception_list_items.ts
@@ -27,7 +27,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless read_exception_list_items', () => {
+  describe('@ess @serverless @serverlessQA read_exception_list_items', () => {
     describe('reading exception list items', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...ts/exception_lists_items/trial_license_complete_tier/items/update_exception_list_items.ts b/...ts/exception_lists_items/trial_license_complete_tier/items/update_exception_list_items.ts
@@ -32,7 +32,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless update_exception_list_items', () => {
+  describe('@ess @serverless @serverlessQA update_exception_list_items', () => {
     describe('update exception list items', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...n_lists/exception_lists_items/trial_license_complete_tier/lists/create_exception_lists.ts b/...n_lists/exception_lists_items/trial_license_complete_tier/lists/create_exception_lists.ts
@@ -23,7 +23,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless create_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA create_exception_lists', () => {
     describe('creating exception lists', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...n_lists/exception_lists_items/trial_license_complete_tier/lists/delete_exception_lists.ts b/...n_lists/exception_lists_items/trial_license_complete_tier/lists/delete_exception_lists.ts
@@ -24,7 +24,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless delete_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA delete_exception_lists', () => {
     describe('delete exception lists', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...lists/exception_lists_items/trial_license_complete_tier/lists/duplicate_exception_list.ts b/...lists/exception_lists_items/trial_license_complete_tier/lists/duplicate_exception_list.ts
@@ -25,7 +25,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless duplicate_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA duplicate_exception_lists', () => {
     afterEach(async () => {
       await deleteAllExceptions(supertest, log);
     });

diff --git a/...on_lists/exception_lists_items/trial_license_complete_tier/lists/export_exception_list.ts b/...on_lists/exception_lists_items/trial_license_complete_tier/lists/export_exception_list.ts
@@ -23,7 +23,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const supertest = getService('supertest');
   const log = getService('log');
 
-  describe('@ess @serverless export_exception_list_route', () => {
+  describe('@ess @serverless @serverlessQA export_exception_list_route', () => {
     describe('exporting exception lists', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...ion_lists/exception_lists_items/trial_license_complete_tier/lists/find_exception_lists.ts b/...ion_lists/exception_lists_items/trial_license_complete_tier/lists/find_exception_lists.ts
@@ -17,7 +17,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const supertest = getService('supertest');
   const log = getService('log');
 
-  describe('@ess @serverless find_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA find_exception_lists', () => {
     describe('find exception lists', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...ion_lists/exception_lists_items/trial_license_complete_tier/lists/get_exception_filter.ts b/...ion_lists/exception_lists_items/trial_license_complete_tier/lists/get_exception_filter.ts
@@ -30,7 +30,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const supertest = getService('supertest');
   const log = getService('log');
 
-  describe('@ess @serverless get_exception_filter', () => {
+  describe('@ess @serverless @serverlessQA get_exception_filter', () => {
     describe('get exception filter', () => {
       beforeEach(async () => {
         await createListsIndex(supertest, log);

diff --git a/...eption_lists/exception_lists_items/trial_license_complete_tier/lists/import_exceptions.ts b/...eption_lists/exception_lists_items/trial_license_complete_tier/lists/import_exceptions.ts
@@ -22,7 +22,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const supertest = getService('supertest');
   const log = getService('log');
 
-  describe('@ess @serverless import_exceptions', () => {
+  describe('@ess @serverless @serverlessQA import_exceptions', () => {
     beforeEach(async () => {
       await deleteAllExceptions(supertest, log);
     });

diff --git a/...ion_lists/exception_lists_items/trial_license_complete_tier/lists/read_exception_lists.ts b/...ion_lists/exception_lists_items/trial_license_complete_tier/lists/read_exception_lists.ts
@@ -24,7 +24,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless read_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA read_exception_lists', () => {
     describe('reading exception lists', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/..._lists/exception_lists_items/trial_license_complete_tier/lists/summary_exception_lists.ts b/..._lists/exception_lists_items/trial_license_complete_tier/lists/summary_exception_lists.ts
@@ -23,7 +23,7 @@ export default ({ getService }: FtrProviderContext) => {
   const supertest = getService('supertest');
   const log = getService('log');
 
-  describe('@ess @serverless summary_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA summary_exception_lists', () => {
     describe('summary exception lists', () => {
       beforeEach(async () => {
         await createListsIndex(supertest, log);

diff --git a/...n_lists/exception_lists_items/trial_license_complete_tier/lists/update_exception_lists.ts b/...n_lists/exception_lists_items/trial_license_complete_tier/lists/update_exception_lists.ts
@@ -25,7 +25,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless update_exception_lists', () => {
+  describe('@ess @serverless @serverlessQA update_exception_lists', () => {
     describe('update exception lists', () => {
       afterEach(async () => {
         await deleteAllExceptions(supertest, log);

diff --git a/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/create_list_items.ts b/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/create_list_items.ts
@@ -29,7 +29,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless create_list_items', () => {
+  describe('@ess @serverless @serverlessQA create_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/delete_list_items.ts b/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/delete_list_items.ts
@@ -24,7 +24,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless delete_list_items', () => {
+  describe('@ess @serverless @serverlessQA delete_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/export_list_items.ts b/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/export_list_items.ts
@@ -21,7 +21,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless export_list_items', () => {
+  describe('@ess @serverless @serverlessQA export_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...ists_and_exception_lists/lists_items/trial_license_complete_tier/items/find_list_items.ts b/...ists_and_exception_lists/lists_items/trial_license_complete_tier/items/find_list_items.ts
@@ -21,7 +21,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless find_list_items', () => {
+  describe('@ess @serverless @serverlessQA find_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/import_list_items.ts b/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/import_list_items.ts
@@ -26,7 +26,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless import_list_items', () => {
+  describe('@ess @serverless @serverlessQA import_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...sts_and_exception_lists/lists_items/trial_license_complete_tier/items/patch_list_items.ts b/...sts_and_exception_lists/lists_items/trial_license_complete_tier/items/patch_list_items.ts
@@ -31,7 +31,7 @@ export default ({ getService }: FtrProviderContext) => {
   const retry = getService('retry');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless patch_list_items', () => {
+  describe('@ess @serverless @serverlessQA patch_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...ists_and_exception_lists/lists_items/trial_license_complete_tier/items/read_list_items.ts b/...ists_and_exception_lists/lists_items/trial_license_complete_tier/items/read_list_items.ts
@@ -25,7 +25,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless read_list_items', () => {
+  describe('@ess @serverless @serverlessQA read_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/update_list_items.ts b/...ts_and_exception_lists/lists_items/trial_license_complete_tier/items/update_list_items.ts
@@ -31,7 +31,7 @@ export default ({ getService }: FtrProviderContext) => {
   const retry = getService('retry');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless update_list_items', () => {
+  describe('@ess @serverless @serverlessQA update_list_items', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...s/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/create_lists.ts b/...s/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/create_lists.ts
@@ -27,7 +27,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless create_lists', () => {
+  describe('@ess @serverless @serverlessQA create_lists', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...s_and_exception_lists/lists_items/trial_license_complete_tier/lists/create_lists_index.ts b/...s_and_exception_lists/lists_items/trial_license_complete_tier/lists/create_lists_index.ts
@@ -18,7 +18,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless create_list_index_route', () => {
+  describe('@ess @serverless @serverlessQA create_list_index_route', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...s/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/delete_lists.ts b/...s/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/delete_lists.ts
@@ -35,7 +35,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless delete_lists', () => {
+  describe('@ess @serverless @serverlessQA delete_lists', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...tes/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/find_lists.ts b/...tes/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/find_lists.ts
@@ -24,7 +24,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless find_lists', () => {
+  describe('@ess @serverless @serverlessQA find_lists', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...s_and_exception_lists/lists_items/trial_license_complete_tier/lists/find_lists_by_size.ts b/...s_and_exception_lists/lists_items/trial_license_complete_tier/lists/find_lists_by_size.ts
@@ -27,7 +27,7 @@ export default ({ getService }: FtrProviderContext): void => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless find_lists_by_size', () => {
+  describe('@ess @serverless @serverlessQA find_lists_by_size', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...es/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/patch_lists.ts b/...es/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/patch_lists.ts
@@ -26,7 +26,7 @@ export default ({ getService }: FtrProviderContext) => {
   const retry = getService('retry');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless patch_lists', () => {
+  describe('@ess @serverless @serverlessQA patch_lists', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...tes/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/read_lists.ts b/...tes/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/read_lists.ts
@@ -26,7 +26,7 @@ export default ({ getService }: FtrProviderContext) => {
   const log = getService('log');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless read_lists', () => {
+  describe('@ess @serverless @serverlessQA read_lists', () => {
     let supertest: TestAgent;
 
     before(async () => {

diff --git a/...s/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/update_lists.ts b/...s/lists_and_exception_lists/lists_items/trial_license_complete_tier/lists/update_lists.ts
@@ -27,7 +27,7 @@ export default ({ getService }: FtrProviderContext) => {
   const retry = getService('retry');
   const utils = getService('securitySolutionUtils');
 
-  describe('@ess @serverless update_lists', () => {
+  describe('@ess @serverless @serverlessQA update_lists', () => {
     let supertest: TestAgent;
 
     before(async () => {