Fix broken unit tests

These unit tests were not using mocks correctly, so they passed when
they should not have:
 * '#find returns empty result if user is unauthorized in any space'
 * '#openPointInTimeForType throws error if if user is unauthorized in any space'

The previous refactor fixed the mocks, which caused these two tests to
start failing. In this commit, I have fixed the code so the tests pass
as written.

x-pack/plugins/spaces/server/saved_objects/spaces_saved_objects_client.ts

@@ -179,7 +179,7 @@ export class SpacesSavedObjectsClient implements SavedObjectsClientContract {
     try {
       namespaces = await this.getSearchableSpaces(options.namespaces);
     } catch (err) {
-      if (Boom.isBoom(err) && err.output.payload.statusCode === 403) {
+      if (Boom.isBoom(err) && err.output.payload.statusCode === 401) {
         // return empty response, since the user is unauthorized in any space, but we don't return forbidden errors for `find` operations
         return SavedObjectsUtils.createEmptyFindResponse<T, A>(options);
       }
@@ -383,7 +383,16 @@ export class SpacesSavedObjectsClient implements SavedObjectsClientContract {
     type: string | string[],
     options: SavedObjectsOpenPointInTimeOptions = {}
   ) {
-    const namespaces = await this.getSearchableSpaces(options.namespaces);
+    let namespaces: string[];
+    try {
+      namespaces = await this.getSearchableSpaces(options.namespaces);
+    } catch (err) {
+      if (Boom.isBoom(err) && err.output.payload.statusCode === 401) {
+        // throw bad request since the user is unauthorized in any space
+        throw SavedObjectsErrorHelpers.createBadRequestError();
+      }
+      throw err;
+    }
     if (namespaces.length === 0) {
       // throw bad request if no valid spaces were found.
       throw SavedObjectsErrorHelpers.createBadRequestError();