Revert "use relative imports for SavedObjectsNamespace"

This reverts commit 348ef98.

src/core/server/saved_objects/serialization/index.ts

@@ -25,7 +25,7 @@
 /* eslint-disable @typescript-eslint/camelcase */
 
 import uuid from 'uuid';
-import { SavedObjectsNamespace } from '../';
+import { SavedObjectsNamespace } from 'src/core/server/saved_objects';
 import { SavedObjectsSchema } from '../schema';
 import { decodeVersion, encodeVersion } from '../version';
 import {
@@ -81,12 +81,6 @@ function assertNonEmptyString(value: string, name: string) {
   }
 }
 
-function assertNotSymbol(value: unknown, name: string) {
-  if (typeof value === 'symbol') {
-    throw new TypeError(`Expected "${String(value)}" to be a ${name}`);
-  }
-}
-
 export class SavedObjectsSerializer {
   private readonly schema: SavedObjectsSchema;
 
@@ -175,7 +169,6 @@ export class SavedObjectsSerializer {
    * @param {string} id - The id of the saved object
    */
   public generateRawId(namespace: SavedObjectsNamespace, type: string, id?: string) {
-    assertNotSymbol(namespace, 'namespace');
     const namespacePrefix =
       namespace && !this.schema.isNamespaceAgnostic(type) ? `${String(namespace)}:` : '';
     return `${namespacePrefix}${type}:${id || uuid.v1()}`;
@@ -184,7 +177,6 @@ export class SavedObjectsSerializer {
   private trimIdPrefix(namespace: SavedObjectsNamespace, type: string, id: string) {
     assertNonEmptyString(id, 'document id');
     assertNonEmptyString(type, 'saved object type');
-    assertNotSymbol(namespace, 'namespace');
 
     const namespacePrefix =
       namespace && !this.schema.isNamespaceAgnostic(type) ? `${String(namespace)}:` : '';

src/core/server/saved_objects/service/lib/namespace.ts

@@ -21,4 +21,4 @@
  * Saved Objects Namespace.
  * @public
  */
-export type SavedObjectsNamespace = string | undefined | symbol;
+export type SavedObjectsNamespace = string | undefined;

src/core/server/saved_objects/service/lib/search_dsl/query_params.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { SavedObjectsNamespace } from '../namespace';
+import { SavedObjectsNamespace } from 'src/core/server/saved_objects';
 import { getRootPropertiesObjects, IndexMapping } from '../../../mappings';
 import { SavedObjectsSchema } from '../../../schema';
 

src/core/server/saved_objects/service/lib/search_dsl/search_dsl.ts

@@ -19,7 +19,7 @@
 
 import Boom from 'boom';
 
-import { SavedObjectsNamespace } from '../namespace';
+import { SavedObjectsNamespace } from 'src/core/server/saved_objects';
 import { IndexMapping } from '../../../mappings';
 import { SavedObjectsSchema } from '../../../schema';
 import { getQueryParams } from './query_params';

src/core/server/saved_objects/service/saved_objects_client.ts

@@ -16,7 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { SavedObjectsRepository, SavedObjectsNamespace } from './lib';
+import { SavedObjectsNamespace } from 'src/core/server';
+import { SavedObjectsRepository } from './lib';
+
 import { SavedObjectsErrorHelpers } from './lib/errors';
 
 type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;

x-pack/typings/core.d.ts

@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+import { SavedObjectsClient } from 'src/core/server/saved_objects';
+
+declare module 'src/core/server/saved_objects' {
+  type SavedObjectsNamespace = string | undefined | symbol;
+  interface SavedObjectsBaseOptions {
+    namespace?: SavedObjectsNamespace;
+  }
+}