[Security Solution][Timeline] Minor side panel fixes (#91691)

elastic · Feb 17, 2021 · e095a6a · e095a6a
1 parent a2cd366
commit e095a6a
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 13 deletions.
diff --git a/...urity_solution/public/overview/components/host_overview/endpoint_overview/translations.ts b/...urity_solution/public/overview/components/host_overview/endpoint_overview/translations.ts
@@ -17,13 +17,13 @@ export const ENDPOINT_POLICY = i18n.translate(
 export const POLICY_STATUS = i18n.translate(
   'xpack.securitySolution.host.details.endpoint.policyStatus',
   {
-    defaultMessage: 'Configuration Status',
+    defaultMessage: 'Policy Status',
   }
 );
 
 export const SENSORVERSION = i18n.translate(
   'xpack.securitySolution.host.details.endpoint.sensorversion',
   {
-    defaultMessage: 'Sensorversion',
+    defaultMessage: 'Sensor Version',
   }
 );
diff --git a/...security_solution/public/timelines/components/side_panel/host_details/expandable_host.tsx b/...security_solution/public/timelines/components/side_panel/host_details/expandable_host.tsx
@@ -6,6 +6,7 @@
  */
 
 import React from 'react';
+import styled from 'styled-components';
 import { i18n } from '@kbn/i18n';
 import { EuiTitle } from '@elastic/eui';
 import { HostDetailsLink } from '../../../../common/components/links';
@@ -23,14 +24,20 @@ interface ExpandableHostProps {
   hostName: string;
 }
 
+const StyledTitle = styled.h4`
+  word-break: break-all;
+  word-wrap: break-word;
+  white-space: pre-wrap;
+`;
+
 export const ExpandableHostDetailsTitle = ({ hostName }: ExpandableHostProps) => (
   <EuiTitle size="s">
-    <h4>
+    <StyledTitle>
       {i18n.translate('xpack.securitySolution.timeline.sidePanel.hostDetails.title', {
         defaultMessage: 'Host details',
       })}
       {`: ${hostName}`}
-    </h4>
+    </StyledTitle>
   </EuiTitle>
 );
 

diff --git a/...ty_solution/public/timelines/components/side_panel/network_details/expandable_network.tsx b/...ty_solution/public/timelines/components/side_panel/network_details/expandable_network.tsx
@@ -7,6 +7,7 @@
 
 import { EuiTitle } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
+import styled from 'styled-components';
 import React, { useCallback, useMemo } from 'react';
 import { useDispatch } from 'react-redux';
 import { FlowTarget } from '../../../../../common/search_strategy';
@@ -31,14 +32,20 @@ interface ExpandableNetworkProps {
   expandedNetwork: { ip: string; flowTarget: FlowTarget };
 }
 
+const StyledTitle = styled.h4`
+  word-break: break-all;
+  word-wrap: break-word;
+  white-space: pre-wrap;
+`;
+
 export const ExpandableNetworkDetailsTitle = ({ ip }: { ip: string }) => (
   <EuiTitle size="s">
-    <h4>
+    <StyledTitle>
       {i18n.translate('xpack.securitySolution.timeline.sidePanel.networkDetails.title', {
         defaultMessage: 'Network details',
       })}
       {`: ${ip}`}
-    </h4>
+    </StyledTitle>
   </EuiTitle>
 );
 

diff --git a/...ins/security_solution/public/timelines/components/timeline/body/events/stateful_event.tsx b/...ins/security_solution/public/timelines/components/timeline/body/events/stateful_event.tsx
@@ -109,8 +109,14 @@ const StatefulEventComponent: React.FC<Props> = ({
   }, [event?.data]);
 
   const hostIPAddresses = useMemo(() => {
-    const ipList = getMappedNonEcsValue({ data: event?.data, fieldName: 'host.ip' });
-    return ipList;
+    const hostIpList = getMappedNonEcsValue({ data: event?.data, fieldName: 'host.ip' }) ?? [];
+    const sourceIpList = getMappedNonEcsValue({ data: event?.data, fieldName: 'source.ip' }) ?? [];
+    const destinationIpList =
+      getMappedNonEcsValue({
+        data: event?.data,
+        fieldName: 'destination.ip',
+      }) ?? [];
+    return new Set([...hostIpList, ...sourceIpList, ...destinationIpList]);
   }, [event?.data]);
 
   const activeTab = tabType ?? TimelineTabs.query;
@@ -123,7 +129,7 @@ const StatefulEventComponent: React.FC<Props> = ({
       activeExpandedDetail?.params?.hostName === hostName) ||
     (activeExpandedDetail?.panelView === 'networkDetail' &&
       activeExpandedDetail?.params?.ip &&
-      hostIPAddresses?.includes(activeExpandedDetail?.params?.ip)) ||
+      hostIPAddresses?.has(activeExpandedDetail?.params?.ip)) ||
     false;
 
   const getNotesByIds = useMemo(() => appSelectors.notesByIdsSelector(), []);

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -18875,8 +18875,6 @@
     "xpack.securitySolution.hooks.useAddToTimeline.addedFieldMessage": "{fieldOrValue}をタイムラインに追加しました",
     "xpack.securitySolution.host.details.architectureLabel": "アーキテクチャー",
     "xpack.securitySolution.host.details.endpoint.endpointPolicy": "統合",
-    "xpack.securitySolution.host.details.endpoint.policyStatus": "構成ステータス",
-    "xpack.securitySolution.host.details.endpoint.sensorversion": "センサーバージョン",
     "xpack.securitySolution.host.details.firstSeenTitle": "初回の認識",
     "xpack.securitySolution.host.details.lastSeenTitle": "前回の認識",
     "xpack.securitySolution.host.details.overview.cloudProviderTitle": "クラウドプロバイダー",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -18921,8 +18921,6 @@
     "xpack.securitySolution.hooks.useAddToTimeline.addedFieldMessage": "已将 {fieldOrValue} 添加到时间线",
     "xpack.securitySolution.host.details.architectureLabel": "架构",
     "xpack.securitySolution.host.details.endpoint.endpointPolicy": "集成",
-    "xpack.securitySolution.host.details.endpoint.policyStatus": "配置状态",
-    "xpack.securitySolution.host.details.endpoint.sensorversion": "感应器版本",
     "xpack.securitySolution.host.details.firstSeenTitle": "首次看到时间",
     "xpack.securitySolution.host.details.lastSeenTitle": "最后看到时间",
     "xpack.securitySolution.host.details.overview.cloudProviderTitle": "云服务提供商",