Always Show Embeddable Panel Header in Edit Mode (#79152)

* Always show header in edit mode
elastic · Oct 1, 2020 · e08f6a3 · e08f6a3
1 parent 46084cb
commit e08f6a3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx b/src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx
@@ -136,7 +136,7 @@ export function PanelHeader({
 }: PanelHeaderProps) {
   const viewDescription = getViewDescription(embeddable);
   const showTitle = !hidePanelTitle && (!isViewMode || title || viewDescription !== '');
-  const showPanelBar = badges.length > 0 || notifications.length > 0 || showTitle;
+  const showPanelBar = !isViewMode || badges.length > 0 || notifications.length > 0 || showTitle;
   const classes = classNames('embPanel__header', {
     // eslint-disable-next-line @typescript-eslint/naming-convention
     'embPanel__header--floater': !showPanelBar,

diff --git a/test/functional/apps/dashboard/dashboard_options.js b/test/functional/apps/dashboard/dashboard_options.js
@@ -44,7 +44,7 @@ export default function ({ getService, getPageObjects }) {
       await PageObjects.dashboard.checkHideTitle();
       await retry.try(async () => {
         const titles = await PageObjects.dashboard.getPanelTitles();
-        expect(titles[0]).to.eql(undefined);
+        expect(titles[0]).to.eql('');
       });
     });