Translate appendInformationToField helper

elastic · Mar 18, 2020 · e08ab39 · e08ab39
1 parent 2bc1fa5
commit e08ab39
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 14 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.test.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.test.ts
@@ -283,6 +283,16 @@ describe('appendInformationToField', () => {
     });
     expect(res).toEqual('my value (updated at 2020-03-13T08:34:53.450Z by Elastic Test User)');
   });
+
+  test('add mode', () => {
+    const res = appendInformationToField({
+      value: 'my value',
+      user: 'Elastic Test User',
+      date: '2020-03-13T08:34:53.450Z',
+      mode: 'add',
+    });
+    expect(res).toEqual('my value (added at 2020-03-13T08:34:53.450Z by Elastic Test User)');
+  });
 });
 
 describe('transformComments', () => {

diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.ts
@@ -21,6 +21,7 @@ import {
 import { Incident } from './lib/types';
 
 import * as transformers from './transformers';
+import * as i18n from './translations';
 
 export const normalizeMapping = (supportedFields: string[], mapping: MapEntry[]): MapEntry[] => {
   // Prevent prototype pollution and remove unsupported fields
@@ -96,10 +97,9 @@ export const appendInformationToField = ({
   date,
   mode = 'create',
 }: AppendInformationFieldArgs): string => {
-  const action = mode === 'create' ? 'created at' : 'updated at';
   return appendField({
     value,
-    suffix: `(${action} ${date} by ${user})`,
+    suffix: i18n.FIELD_INFORMATION(mode, date, user),
   });
 };
 

diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/transformers.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/transformers.ts
@@ -13,7 +13,7 @@ export const informationCreated = ({
   user,
   ...rest
 }: TransformerArgs): TransformerArgs => ({
-  value: i18n.FIELD_INFORMATION('create', value, date, user),
+  value: `${value} ${i18n.FIELD_INFORMATION('create', date, user)}`,
   ...rest,
 });
 
@@ -23,7 +23,7 @@ export const informationUpdated = ({
   user,
   ...rest
 }: TransformerArgs): TransformerArgs => ({
-  value: i18n.FIELD_INFORMATION('update', value, date, user),
+  value: `${value} ${i18n.FIELD_INFORMATION('update', date, user)}`,
   ...rest,
 });
 
@@ -33,7 +33,7 @@ export const informationAdded = ({
   user,
   ...rest
 }: TransformerArgs): TransformerArgs => ({
-  value: i18n.FIELD_INFORMATION('add', value, date, user),
+  value: `${value} ${i18n.FIELD_INFORMATION('add', date, user)}`,
   ...rest,
 });
 

diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/translations.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/translations.ts
@@ -54,30 +54,29 @@ export const UNEXPECTED_STATUS = (status: number) =>
 
 export const FIELD_INFORMATION = (
   mode: string,
-  value: string,
   date: string | undefined,
   user: string | undefined
 ) => {
   switch (mode) {
     case 'create':
       return i18n.translate('xpack.actions.builtin.servicenow.informationCreated', {
-        values: { value, date, user },
-        defaultMessage: '{value} (created at {date} by {user})',
+        values: { date, user },
+        defaultMessage: '(created at {date} by {user})',
       });
     case 'update':
       return i18n.translate('xpack.actions.builtin.servicenow.informationUpdated', {
-        values: { value, date, user },
-        defaultMessage: '{value} (updated at {date} by {user})',
+        values: { date, user },
+        defaultMessage: '(updated at {date} by {user})',
       });
     case 'add':
       return i18n.translate('xpack.actions.builtin.servicenow.informationAdded', {
-        values: { value, date, user },
-        defaultMessage: '{value} (added at {date} by {user})',
+        values: { date, user },
+        defaultMessage: '(added at {date} by {user})',
       });
     default:
       return i18n.translate('xpack.actions.builtin.servicenow.informationDefault', {
-        values: { value, date, user },
-        defaultMessage: '{value} (created at {date} by {user})',
+        values: { date, user },
+        defaultMessage: '(created at {date} by {user})',
       });
   }
 };