fixing some problems, should work ok now

elastic · Sep 14, 2016 · e07027c · e07027c
1 parent 727eecc
commit e07027c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/src/ui/public/vislib/lib/axis.js b/src/ui/public/vislib/lib/axis.js
@@ -150,7 +150,7 @@ export default function AxisFactory(Private) {
             }
           })());
         });
-        const length = _.max(lengths);
+        const length = lengths.length > 0 ? _.max(lengths) : 0;
 
         if (self.isHorizontal()) {
           selection.attr('height', length);

diff --git a/src/ui/public/vislib/lib/axis_scale.js b/src/ui/public/vislib/lib/axis_scale.js
@@ -235,7 +235,7 @@ export default function AxisScaleFactory(Private) {
 
       if (!this.isUserDefined() && !this.isOrdinal() && !this.isTimeDomain()) this.scale.nice(); // round extents when not user defined
       // Prevents bars from going off the chart when the y extents are within the domain range
-      if (this.axis._attr.type === 'histogram') this.scale.clamp(true);
+      if (this.axis._attr.type === 'histogram' && this.scale.clamp) this.scale.clamp(true);
 
       this.validateScale(this.scale);
 

diff --git a/src/ui/public/vislib/lib/layout/splits/column_chart/y_axis_split.js b/src/ui/public/vislib/lib/layout/splits/column_chart/y_axis_split.js
@@ -17,7 +17,7 @@ define(function () {
       selection.each(function () {
         const div = d3.select(this);
 
-        div.call(setWidth, yAxis);
+        //div.call(setWidth, yAxis);
 
         div.selectAll('.y-axis-div')
         .append('div')

diff --git a/src/ui/public/vislib/visualizations/area_chart.js b/src/ui/public/vislib/visualizations/area_chart.js
@@ -212,8 +212,6 @@ export default function AreaChartFactory(Private) {
         return xScale(d.x) + xScale.rangeBand() / 2;
       })
       .attr('cy', function cy(d, i, j) {
-        const yScale = self.handler.valueAxes[0].getScale();
-
         if (isOverlapping) {
           return yScale(d.y);
         }