fix for code review

elastic · Aug 16, 2021 · ddb3c18 · ddb3c18
1 parent e26cbf8
commit ddb3c18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/hover_actions/index.tsx b/x-pack/plugins/security_solution/public/common/components/hover_actions/index.tsx
@@ -240,9 +240,7 @@ export const HoverActions: React.FC<Props> = React.memo(
 
           {additionalContent != null && <AdditionalContent>{additionalContent}</AdditionalContent>}
 
-          {enableOverflowButton && overflowActionItems}
-
-          {!enableOverflowButton && allActionItems}
+          {enableOverflowButton ? overflowActionItems : allActionItems}
         </StyledHoverActionsContainer>
       </EuiFocusTrap>
     );

diff --git a/...ugins/security_solution/public/common/components/hover_actions/use_hover_action_items.tsx b/...ugins/security_solution/public/common/components/hover_actions/use_hover_action_items.tsx
@@ -110,6 +110,10 @@ export const useHoverActionItems = ({
       : SourcererScopeName.default;
   const { browserFields } = useSourcererScope(activeScope);
 
+  /*
+   * In the case of `DisableOverflowButton`, we show filters only when topN is NOT opened. As after topN button is clicked, the chart panel replace current hover actions in the hover actions' popover, so we have to hide all the actions.
+   * in the case of `EnableOverflowButton`, we only need to hide all the items in the overflow popover as the chart's panel opens in the overflow popover, so non-overflowed actions are not affected.
+   */
   const showFilters =
     values != null && (enableOverflowButton || (!showTopN && !enableOverflowButton));
 

diff --git a/.../plugins/security_solution/public/timelines/components/side_panel/event_details/index.tsx b/.../plugins/security_solution/public/timelines/components/side_panel/event_details/index.tsx
@@ -154,7 +154,7 @@ const EventDetailsPanelComponent: React.FC<EventDetailsPanelProps> = ({
 
   return isFlyoutView ? (
     <>
-      <EuiFlyoutHeader hasBorder={isHostIsolationPanelOpen ? true : false}>
+      <EuiFlyoutHeader hasBorder={isHostIsolationPanelOpen}>
         {isHostIsolationPanelOpen ? (
           backToAlertDetailsLink
         ) : (