Fix types

elastic · Apr 16, 2024 · dc91440 · dc91440
1 parent af0baec
commit dc91440
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/...ck/plugins/alerting/server/connector_adapters/get_system_action_kibana_privileges.test.ts b/...ck/plugins/alerting/server/connector_adapters/get_system_action_kibana_privileges.test.ts
@@ -45,7 +45,7 @@ describe('getSystemActionKibanaPrivileges', () => {
     const privileges = getSystemActionKibanaPrivileges({
       connectorAdapterRegistry: registry,
       systemActions: [],
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(privileges).toEqual([]);
@@ -54,7 +54,7 @@ describe('getSystemActionKibanaPrivileges', () => {
   it('should return an empty array if systemActions are not defined', () => {
     const privileges = getSystemActionKibanaPrivileges({
       connectorAdapterRegistry: registry,
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(privileges).toEqual([]);
@@ -64,7 +64,7 @@ describe('getSystemActionKibanaPrivileges', () => {
     const privileges = getSystemActionKibanaPrivileges({
       connectorAdapterRegistry: registry,
       systemActions,
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(privileges).toEqual(['my-priv:stackAlerts', 'my-priv-2:stackAlerts']);
@@ -74,7 +74,7 @@ describe('getSystemActionKibanaPrivileges', () => {
     const privileges = getSystemActionKibanaPrivileges({
       connectorAdapterRegistry: registry,
       systemActions: [...systemActions, { id: 'my-id-2', actionTypeId: '.not-valid', params: {} }],
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(privileges).toEqual(['my-priv:stackAlerts', 'my-priv-2:stackAlerts']);
@@ -84,7 +84,7 @@ describe('getSystemActionKibanaPrivileges', () => {
     const privileges = getSystemActionKibanaPrivileges({
       connectorAdapterRegistry: registry,
       systemActions: [...systemActions, { id: 'my-id-2', actionTypeId: '.no-priv', params: {} }],
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(privileges).toEqual(['my-priv:stackAlerts', 'my-priv-2:stackAlerts']);
@@ -94,7 +94,7 @@ describe('getSystemActionKibanaPrivileges', () => {
     const privileges = getSystemActionKibanaPrivileges({
       connectorAdapterRegistry: registry,
       systemActions: [systemActions[0], systemActions[0]],
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(privileges).toEqual(['my-priv:stackAlerts']);

diff --git a/x-pack/plugins/alerting/server/lib/validate_authorize_system_actions.test.ts b/x-pack/plugins/alerting/server/lib/validate_authorize_system_actions.test.ts
@@ -50,7 +50,7 @@ describe('validateAndAuthorizeSystemActions', () => {
       systemActions: [],
       actionsClient,
       actionsAuthorization,
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(res).toBe(undefined);
@@ -78,7 +78,7 @@ describe('validateAndAuthorizeSystemActions', () => {
         systemActions,
         actionsClient,
         actionsAuthorization,
-        rule: { consumer: 'stackAlerts' },
+        rule: { consumer: 'stackAlerts', producer: 'alerts' },
       })
     ).rejects.toThrowErrorMatchingInlineSnapshot(`"Action not-exist is not a system action"`);
   });
@@ -103,7 +103,7 @@ describe('validateAndAuthorizeSystemActions', () => {
         systemActions,
         actionsClient,
         actionsAuthorization,
-        rule: { consumer: 'stackAlerts' },
+        rule: { consumer: 'stackAlerts', producer: 'alerts' },
       })
     ).rejects.toThrowErrorMatchingInlineSnapshot(`"Action not-exist is not a system action"`);
   });
@@ -128,7 +128,7 @@ describe('validateAndAuthorizeSystemActions', () => {
         systemActions,
         actionsClient,
         actionsAuthorization,
-        rule: { consumer: 'stackAlerts' },
+        rule: { consumer: 'stackAlerts', producer: 'alerts' },
       })
     ).rejects.toThrowErrorMatchingInlineSnapshot(
       `"Invalid system action params. System action type: .test - [foo]: expected value of type [string] but got [undefined]"`
@@ -161,7 +161,7 @@ describe('validateAndAuthorizeSystemActions', () => {
         systemActions,
         actionsClient,
         actionsAuthorization,
-        rule: { consumer: 'stackAlerts' },
+        rule: { consumer: 'stackAlerts', producer: 'alerts' },
       })
     ).rejects.toThrowErrorMatchingInlineSnapshot(`"Cannot use the same system action twice"`);
   });
@@ -213,7 +213,7 @@ describe('validateAndAuthorizeSystemActions', () => {
       systemActions,
       actionsClient,
       actionsAuthorization,
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(res).toBe(undefined);
@@ -281,7 +281,7 @@ describe('validateAndAuthorizeSystemActions', () => {
       systemActions,
       actionsClient,
       actionsAuthorization,
-      rule: { consumer: 'stackAlerts' },
+      rule: { consumer: 'stackAlerts', producer: 'alerts' },
     });
 
     expect(actionsAuthorization.ensureAuthorized).toBeCalledWith({