Skip to content

Commit

Permalink
[PR feedback] Fix visual regression by removing unnecessary EuiFormRow
Browse files Browse the repository at this point in the history
- doesn't apply and isn't necessary, removing it gets the button group back to the previous prod rendering
  • Loading branch information
cee-chen committed Aug 28, 2024
1 parent 6872b4f commit db96596
Showing 1 changed file with 16 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
EuiEmptyPrompt,
EuiFlexGroup,
EuiFlexItem,
EuiFormRow,
EuiSpacer,
EuiText,
} from '@elastic/eui';
Expand Down Expand Up @@ -428,26 +427,22 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({
shouldRerunAnalysis={shouldRerunAnalysis}
>
<EuiFlexItem grow={false}>
<EuiFormRow display="columnCompressedSwitch">
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem grow={false}>
<EuiText size="xs">{groupResultsMessage}</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonGroup
data-test-subj={`aiopsLogRateAnalysisGroupSwitch${
groupResults ? ' checked' : ''
}`}
buttonSize="s"
isDisabled={disabledGroupResultsSwitch}
legend="Smart grouping"
options={toggleButtons}
idSelected={toggleIdSelected}
onChange={onGroupResultsToggle}
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFormRow>
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem grow={false}>
<EuiText size="xs">{groupResultsMessage}</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonGroup
data-test-subj={`aiopsLogRateAnalysisGroupSwitch${groupResults ? ' checked' : ''}`}
buttonSize="s"
isDisabled={disabledGroupResultsSwitch}
legend="Smart grouping"
options={toggleButtons}
idSelected={toggleIdSelected}
onChange={onGroupResultsToggle}
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<FieldFilterPopover
Expand Down

0 comments on commit db96596

Please sign in to comment.