Rename open flyout method

elastic · Jul 7, 2023 · d71df9e · d71df9e
1 parent c0c81e2
commit d71df9e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/.../public/editor/open_create_new_flyout.tsx → ...able/public/editor/open_editor_flyout.tsx b/.../public/editor/open_create_new_flyout.tsx → ...able/public/editor/open_editor_flyout.tsx
@@ -8,7 +8,6 @@
 
 import React from 'react';
 import { Subject } from 'rxjs';
-import { v4 as uuidv4 } from 'uuid';
 import { skip, take, takeUntil } from 'rxjs/operators';
 
 import { toMountPoint } from '@kbn/kibana-react-plugin/public';
@@ -21,15 +20,15 @@ import { NavigationEmbeddablePanelEditor } from '../components/navigation_embedd
 /**
  * @throws in case user cancels
  */
-export async function openCreateNewFlyout(
+export async function openEditorFlyout(
   initialInput?: Omit<NavigationEmbeddableInput, 'id'>,
   parentDashboard?: DashboardContainer
 ): Promise<Partial<NavigationEmbeddableInput>> {
   return new Promise((resolve, reject) => {
     const closed$ = new Subject<true>();
 
-    const onSave = (containerInput: Partial<NavigationEmbeddableInput>) => {
-      resolve(containerInput);
+    const onSave = (partialInput: Partial<NavigationEmbeddableInput>) => {
+      resolve(partialInput);
       editorFlyout.close();
     };
 
@@ -50,7 +49,7 @@ export async function openCreateNewFlyout(
     const editorFlyout = coreServices.overlays.openFlyout(
       toMountPoint(
         <NavigationEmbeddablePanelEditor
-          initialInput={{ id: uuidv4(), ...initialInput }}
+          initialInput={initialInput ?? {}}
           onClose={onCancel}
           onSave={onSave}
           parentDashboard={parentDashboard}

diff --git a/src/plugins/navigation_embeddable/public/embeddable/navigation_embeddable_factory.ts b/src/plugins/navigation_embeddable/public/embeddable/navigation_embeddable_factory.ts
@@ -74,8 +74,8 @@ export class NavigationEmbeddableFactoryDefinition
   ) {
     if (!parent) return {};
 
-    const { openCreateNewFlyout: createNavigationEmbeddable } = await import(
-      '../editor/open_create_new_flyout'
+    const { openEditorFlyout: createNavigationEmbeddable } = await import(
+      '../editor/open_editor_flyout'
     );
 
     const input = await createNavigationEmbeddable(