[Monitoring] APM monitoring to EUI (#26344)

* Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages
elastic · Dec 12, 2018 · d71d97b · d71d97b
1 parent 7dfa1c3
commit d71d97b
Show file tree

Hide file tree

Showing 25 changed files with 1,123 additions and 681 deletions.
diff --git a/x-pack/plugins/monitoring/public/components/apm/instance/instance.js b/x-pack/plugins/monitoring/public/components/apm/instance/instance.js
@@ -12,7 +12,8 @@ import {
   EuiSpacer,
   EuiPage,
   EuiPageBody,
-  EuiFlexGroup
+  EuiFlexGroup,
+  EuiPageContent
 } from '@elastic/eui';
 import { Status } from './status';
 
@@ -46,13 +47,15 @@ export function ApmServerInstance({ summary, metrics, ...props }) {
   ));
 
   return (
-    <EuiPage style={{ backgroundColor: 'white' }}>
+    <EuiPage>
       <EuiPageBody>
-        <Status stats={summary}/>
-        <EuiSpacer size="s"/>
-        <EuiFlexGroup wrap>
-          {charts}
-        </EuiFlexGroup>
+        <EuiPageContent>
+          <Status stats={summary}/>
+          <EuiSpacer size="s"/>
+          <EuiFlexGroup wrap>
+            {charts}
+          </EuiFlexGroup>
+        </EuiPageContent>
       </EuiPageBody>
     </EuiPage>
   );

diff --git a/x-pack/plugins/monitoring/public/components/apm/instances/instances.js b/x-pack/plugins/monitoring/public/components/apm/instances/instances.js
@@ -6,150 +6,126 @@
 
 import React from 'react';
 import moment from 'moment';
-import { MonitoringTable } from '../../table';
-import {
-  KuiTableRowCell,
-  KuiTableRow
-} from '@kbn/ui-framework/components';
-import { EuiLink } from '@elastic/eui';
+import { uniq } from 'lodash';
+import { EuiMonitoringTable } from '../../table';
+import { EuiLink, EuiPage, EuiPageBody, EuiPageContent, EuiSpacer } from '@elastic/eui';
 import { Status } from './status';
-import { SORT_ASCENDING, SORT_DESCENDING, TABLE_ACTION_UPDATE_FILTER } from '../../../../common/constants';
 import { formatMetric } from '../../../lib/format_number';
 import { formatTimestampToDuration } from '../../../../common';
 import { i18n } from '@kbn/i18n';
 import { injectI18n } from '@kbn/i18n/react';
 
-
-const filterFields = [ 'name', 'type', 'version', 'output' ];
 const columns = [
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.nameTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.nameTitle', {
       defaultMessage: 'Name'
     }),
-    sortKey: 'name',
-    sortOrder: SORT_ASCENDING
+    field: 'name',
+    render: (name, instance) => (
+      <EuiLink
+        href={`#/apm/instances/${instance.uuid}`}
+        data-test-subj={`apmLink-${name}`}
+      >
+        {name}
+      </EuiLink>
+    )
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.outputEnabledTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.outputEnabledTitle', {
       defaultMessage: 'Output Enabled'
     }),
-    sortKey: 'output'
+    field: 'output'
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.totalEventsRateTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.totalEventsRateTitle', {
       defaultMessage: 'Total Events Rate'
     }),
-    sortKey: 'total_events_rate',
-    secondarySortOrder: SORT_DESCENDING
+    field: 'total_events_rate',
+    render: value => formatMetric(value, '', '/s')
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.bytesSentRateTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.bytesSentRateTitle', {
       defaultMessage: 'Bytes Sent Rate'
     }),
-    sortKey: 'bytes_sent_rate'
+    field: 'bytes_sent_rate',
+    render: value => formatMetric(value, 'byte', '/s')
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.outputErrorsTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.outputErrorsTitle', {
       defaultMessage: 'Output Errors'
     }),
-    sortKey: 'errors'
+    field: 'errors',
+    render: value => formatMetric(value, '0')
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.lastEventTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.lastEventTitle', {
       defaultMessage: 'Last Event'
     }),
-    sortKey: 'time_of_last_event'
+    field: 'time_of_last_event',
+    render: value => formatTimestampToDuration(+moment(value), 'since') + ' ago'
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.allocatedMemoryTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.allocatedMemoryTitle', {
       defaultMessage: 'Allocated Memory'
     }),
-    sortKey: 'memory'
+    field: 'memory',
+    render: value => formatMetric(value, 'byte')
   },
   {
-    title: i18n.translate('xpack.monitoring.apm.instances.versionTitle', {
+    name: i18n.translate('xpack.monitoring.apm.instances.versionTitle', {
       defaultMessage: 'Version'
     }),
-    sortKey: 'version'
+    field: 'version'
   },
 ];
-const instanceRowFactory = () => {
-  return function KibanaRow(props) {
-    const applyFiltering = filterText => () => {
-      props.dispatchTableAction(TABLE_ACTION_UPDATE_FILTER, filterText);
-    };
-
-    return (
-      <KuiTableRow>
-        <KuiTableRowCell>
-          <div className="monTableCell__name">
-            <EuiLink
-              href={`#/apm/instances/${props.uuid}`}
-              data-test-subj={`apmLink-${props.name}`}
-            >
-              {props.name}
-            </EuiLink>
-          </div>
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          {props.output}
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          {formatMetric(props.total_events_rate, '', '/s')}
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          {formatMetric(props.bytes_sent_rate, 'byte', '/s')}
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          {formatMetric(props.errors, '0')}
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          {formatTimestampToDuration(+moment(props.time_of_last_event), 'since') + ' ago'}
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          {formatMetric(props.memory, 'byte')}
-        </KuiTableRowCell>
-        <KuiTableRowCell>
-          <EuiLink
-            onClick={applyFiltering(props.version)}
-          >
-            {props.version}
-          </EuiLink>
-        </KuiTableRowCell>
-      </KuiTableRow>
-    );
-  };
-};
 
-function ApmServerInstancesUI({ apms, intl }) {
+export function ApmServerInstancesUI({ apms, intl }) {
   const {
-    pageIndex,
-    filterText,
-    sortKey,
-    sortOrder,
-    onNewState,
+    pagination,
+    sorting,
+    onTableChange,
+    data
   } = apms;
 
+  const versions = uniq(data.apms.map(item => item.version)).map(version => {
+    return { value: version };
+  });
+
   return (
-    <div>
-      <Status stats={apms.data.stats}/>
-      <MonitoringTable
-        className="apmInstancesTable"
-        rows={apms.data.apms}
-        pageIndex={pageIndex}
-        filterText={filterText}
-        sortKey={sortKey}
-        sortOrder={sortOrder}
-        onNewState={onNewState}
-        placeholder={intl.formatMessage({
-          id: 'xpack.monitoring.apm.instances.filterInstancesPlaceholder',
-          defaultMessage: 'Filter Instances…'
-        })}
-        filterFields={filterFields}
-        columns={columns}
-        rowComponent={instanceRowFactory()}
-      />
-    </div>
+    <EuiPage>
+      <EuiPageBody>
+        <EuiPageContent>
+          <Status stats={data.stats} />
+          <EuiSpacer size="m"/>
+          <EuiMonitoringTable
+            className="apmInstancesTable"
+            rows={data.apms}
+            columns={columns}
+            sorting={sorting}
+            pagination={pagination}
+            search={{
+              box: {
+                incremental: true,
+                placeholder: intl.formatMessage({
+                  id: 'xpack.monitoring.apm.instances.filterInstancesPlaceholder',
+                  defaultMessage: 'Filter Instances…'
+                })
+              },
+              filters: [
+                {
+                  type: 'field_value_selection',
+                  field: 'version',
+                  name: 'Version',
+                  options: versions,
+                  multiSelect: 'or',
+                }
+              ]
+            }}
+            onTableChange={onTableChange}
+          />
+        </EuiPageContent>
+      </EuiPageBody>
+    </EuiPage>
   );
 }
 

diff --git a/x-pack/plugins/monitoring/public/components/apm/overview/index.js b/x-pack/plugins/monitoring/public/components/apm/overview/index.js
@@ -12,7 +12,8 @@ import {
   EuiFlexGroup,
   EuiFlexItem,
   EuiPageBody,
-  EuiPanel
+  EuiPanel,
+  EuiPageContent
 } from '@elastic/eui';
 import { Status } from '../instances/status';
 
@@ -50,13 +51,15 @@ export function ApmOverview({
   ));
 
   return (
-    <EuiPage style={{ backgroundColor: 'white' }}>
+    <EuiPage>
       <EuiPageBody>
-        <Status stats={stats}/>
-        <EuiSpacer size="s"/>
-        <EuiFlexGroup wrap>
-          {charts}
-        </EuiFlexGroup>
+        <EuiPageContent>
+          <Status stats={stats}/>
+          <EuiSpacer size="s"/>
+          <EuiFlexGroup wrap>
+            {charts}
+          </EuiFlexGroup>
+        </EuiPageContent>
       </EuiPageBody>
     </EuiPage>
   );

diff --git a/x-pack/plugins/monitoring/public/components/beats/listing/index.js b/x-pack/plugins/monitoring/public/components/beats/listing/index.js
@@ -0,0 +1,7 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+export { Listing } from './listing';