Skip to content

Commit

Permalink
remove useUTC deprecation, set default timezone to local
Browse files Browse the repository at this point in the history
  • Loading branch information
jbudz committed Sep 4, 2018
1 parent a64738d commit d5035d0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
6 changes: 6 additions & 0 deletions docs/migration/migrate_7_0.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,9 @@ considered unique based on its persistent UUID, which is written to the path.dat
*Details:* Any timezone can now be specified by canonical id.

*Impact:* The logging.useUTC flag will have to be replaced with a timezone id. If set to true the id is `UTC`.

[float]
=== Default logging timezone is now the system's timezone
*Details:* In prior releases the timezone used in logs defaulted to UTC. We now use the host machine's timezone by default.

*Impact:* To restore the previous behavior, in kibana.yml set `logging.timezone: UTC`.
2 changes: 1 addition & 1 deletion src/server/config/schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export default () => Joi.object({
then: Joi.default(!process.stdout.isTTY),
otherwise: Joi.default(true)
}),
timezone: Joi.string().allow(false).default('UTC')
timezone: Joi.string().allow(false).default(false)
}).default(),

ops: Joi.object({
Expand Down
10 changes: 0 additions & 10 deletions src/server/config/transform_deprecations.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,6 @@ const rewriteBasePath = (settings, log) => {
}
};

const loggingTimezone = (settings, log) => {
if (_.has(settings, 'logging.useUTC')) {
const timezone = settings.logging.useUTC ? 'UTC' : false;
set('logging.timezone', timezone);
unset(settings, 'logging.UTC');
log(`Config key "logging.useUTC" is deprecated. It has been replaced with "logging.timezone"`);
}
};

const deprecations = [
//server
rename('server.ssl.cert', 'server.ssl.certificate'),
Expand All @@ -78,7 +69,6 @@ const deprecations = [
serverSslEnabled,
savedObjectsIndexCheckTimeout,
rewriteBasePath,
loggingTimezone,
];

export const transformDeprecations = createTransform(deprecations);

0 comments on commit d5035d0

Please sign in to comment.