Apply suggestions from code review

Co-authored-by: Joe Portner <[email protected]>
elastic · May 1, 2020 · d424da4 · d424da4
1 parent 85b37de
commit d424da4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/core/server/elasticsearch/elasticsearch_config.ts b/src/core/server/elasticsearch/elasticsearch_config.ts
@@ -133,6 +133,10 @@ const deprecations: ConfigDeprecationProvider = () => [
       log(
         `Setting [${fromPath}.username] to "elastic" is deprecated. You should use the "kibana_system" user instead.`
       );
+    } else if (es.username === 'kibana') {
+      log(
+        `Setting [${fromPath}.username] to "kibana" is deprecated. You should use the "kibana_system" user instead.`
+      );
     }
     if (es.ssl?.key !== undefined && es.ssl?.certificate === undefined) {
       log(

diff --git a/x-pack/plugins/monitoring/server/deprecations.ts b/x-pack/plugins/monitoring/server/deprecations.ts
@@ -61,6 +61,10 @@ export const deprecations = ({
           logger(
             `Setting [${fromPath}.username] to "elastic" is deprecated. You should use the "kibana_system" user instead.`
           );
+        } else if (es.username === 'kibana') {
+          logger(
+            `Setting [${fromPath}.username] to "kibana" is deprecated. You should use the "kibana_system" user instead.`
+          );
         }
       }
       return config;