Merge branch 'master' of github.com:elastic/kibana into pr/58930

elastic · Mar 10, 2020 · d29643c · d29643c
2 parents 2e853a3 + ecac63f
commit d29643c
Show file tree

Hide file tree

Showing 2,567 changed files with 59,373 additions and 36,750 deletions.
diff --git a/.ci/Jenkinsfile_visual_baseline b/.ci/Jenkinsfile_visual_baseline
@@ -6,13 +6,15 @@ kibanaLibrary.load()
 kibanaPipeline(timeoutMinutes: 120) {
   catchError {
     parallel([
-      workers.base(name: 'oss-visualRegression', label: 'linux && immutable') {
-        kibanaPipeline.buildOss()
-        kibanaPipeline.functionalTestProcess('oss-visualRegression', './test/scripts/jenkins_visual_regression.sh')
+      'oss-visualRegression': {
+        workers.ci(name: 'oss-visualRegression', label: 'linux && immutable', ramDisk: false) {
+          kibanaPipeline.functionalTestProcess('oss-visualRegression', './test/scripts/jenkins_visual_regression.sh')(1)
+        }
       },
-      workers.base(name: 'xpack-visualRegression', label: 'linux && immutable') {
-        kibanaPipeline.buildXpack()
-        kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh')
+      'xpack-visualRegression': {
+        workers.ci(name: 'xpack-visualRegression', label: 'linux && immutable', ramDisk: false) {
+          kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh')(1)
+        }
       },
     ])
   }

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -514,6 +514,16 @@ module.exports = {
       },
     },
 
+    /**
+     * Harden specific rules
+     */
+    {
+      files: ['test/harden/*.js'],
+      rules: {
+        'mocha/handle-done-callback': 'off', // TODO: Find a way to disable all mocha rules
+      },
+    },
+
     /**
      * APM overrides
      */

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -5,7 +5,6 @@
 # App
 /x-pack/legacy/plugins/lens/ @elastic/kibana-app
 /x-pack/legacy/plugins/graph/ @elastic/kibana-app
-/src/plugins/share/ @elastic/kibana-app
 /src/legacy/server/url_shortening/ @elastic/kibana-app
 /src/legacy/server/sample_data/ @elastic/kibana-app
 /src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-app
@@ -27,6 +26,7 @@
 /src/plugins/kibana_legacy/ @elastic/kibana-app
 /src/plugins/timelion/ @elastic/kibana-app
 /src/plugins/dev_tools/ @elastic/kibana-app
+/src/plugins/dashboard_embeddable_container/ @elastic/kibana-app
 
 # App Architecture
 /packages/kbn-interpreter/ @elastic/kibana-app-arch
@@ -42,7 +42,6 @@
 /src/legacy/core_plugins/visualizations/ @elastic/kibana-app-arch
 /src/legacy/server/index_patterns/ @elastic/kibana-app-arch
 /src/plugins/bfetch/ @elastic/kibana-app-arch
-/src/plugins/dashboard_embeddable_container/ @elastic/kibana-app-arch
 /src/plugins/data/ @elastic/kibana-app-arch
 /src/plugins/embeddable/ @elastic/kibana-app-arch
 /src/plugins/expressions/ @elastic/kibana-app-arch
@@ -53,6 +52,9 @@
 /src/plugins/navigation/ @elastic/kibana-app-arch
 /src/plugins/ui_actions/ @elastic/kibana-app-arch
 /src/plugins/visualizations/ @elastic/kibana-app-arch
+/src/plugins/share/ @elastic/kibana-app-arch
+/examples/url_generators_examples/ @elastic/kibana-app-arch
+/examples/url_generators_explorer/ @elastic/kibana-app-arch
 /x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch
 /x-pack/plugins/drilldowns/ @elastic/kibana-app-arch
 
@@ -130,6 +132,7 @@
 /src/legacy/server/logging/ @elastic/kibana-platform
 /src/legacy/server/saved_objects/  @elastic/kibana-platform
 /src/legacy/server/status/ @elastic/kibana-platform
+/src/plugins/status_page/ @elastic/kibana-platform
 /src/dev/run_check_core_api_changes.ts @elastic/kibana-platform
 
 # Security

diff --git a/.github/workflows/pr-project-assigner.yml b/.github/workflows/pr-project-assigner.yml
@@ -13,8 +13,9 @@ jobs:
         with:
           issue-mappings: |
             [
-              { "label": "Team:AppArch", "projectName": "kibana-app-arch", "columnId": 6173897 },
-              { "label": "Feature:Lens", "projectName": "Lens", "columnId": 6219362 },
-              { "label": "Team:Canvas", "projectName": "canvas", "columnId": 6187580 }
             ]
           ghToken: ${{ secrets.PROJECT_ASSIGNER_TOKEN }}
+
+#              { "label": "Team:AppArch", "projectName": "kibana-app-arch", "columnId": 6173897 },
+#              { "label": "Feature:Lens", "projectName": "Lens", "columnId": 6219362 },
+#              { "label": "Team:Canvas", "projectName": "canvas", "columnId": 6187580 }
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -391,9 +391,9 @@ Note that for VSCode, to enable "live" linting of TypeScript (and other) file ty
 
 All user-facing labels and info texts in Kibana should be internationalized. Please take a look at the [readme](packages/kbn-i18n/README.md) and the [guideline](packages/kbn-i18n/GUIDELINE.md) of the i18n package on how to do so.
 
-In order to enable translations in the React parts of the application, the top most component of every `ReactDOM.render` call should be an `I18nContext`:
+In order to enable translations in the React parts of the application, the top most component of every `ReactDOM.render` call should be the `Context` component from the `i18n` core service:
 ```jsx
-import { I18nContext } from 'ui/i18n';
+const I18nContext = coreStart.i18n.Context;
 
 ReactDOM.render(
   <I18nContext>

diff --git a/docs/apm/advanced-queries.asciidoc b/docs/apm/advanced-queries.asciidoc
@@ -5,7 +5,7 @@ When querying in the APM app, you're simply searching and selecting data from fi
 Queries entered into the query bar are also added as parameters to the URL,
 so it's easy to share a specific query or view with others.
 
-In the screenshot below, you can begin to see some of the transaction fields available for filtering on:  
+In the screenshot below, you can begin to see some of the transaction fields available for filtering on:
 
 [role="screenshot"]
 image::apm/images/apm-query-bar.png[Example of the Kibana Query bar in APM app in Kibana]
@@ -21,22 +21,22 @@ TIP: Read the {kibana-ref}/kuery-query.html[Kibana Query Language Enhancements]
 
 [float]
 [[discover-advanced-queries]]
-=== Querying in the Discover app
+=== Querying in Discover
 
-It may also be helpful to view your APM data in the {kibana-ref}/discover.html[Discover app].
-Querying documents in Discover works the same way as querying in the APM app,
-and all of the example queries listed above can also be used in the Discover app.
+It may also be helpful to view your APM data in {kibana-ref}/discover.html[*Discover*].
+Querying documents in *Discover* works the same way as querying in the APM app,
+and all of the example APM app queries can also be used in *Discover*.
 
 [float]
-==== Example Discover app query
+==== Example Discover query
 
-One example where you may want to make use of the Discover app,
+One example where you may want to make use of *Discover*,
 is for viewing  _all_ transactions for an endpoint, instead of just a sample.
 
 TIP: Starting in v7.6, you can view 10 samples per bucket in the APM app, instead of just one.
 
 Use the APM app to find a transaction name and time bucket that you're interested in learning more about.
-Then, switch to the Discover app and make a search:
+Then, switch to *Discover* and make a search:
 
 ["source","sh"]
 -----

diff --git a/docs/canvas/canvas-function-reference.asciidoc b/docs/canvas/canvas-function-reference.asciidoc
diff --git a/docs/dev-tools/console/console.asciidoc b/docs/dev-tools/console/console.asciidoc
@@ -18,8 +18,8 @@ NOTE: You are unable to interact with the REST API of {kib} with the Console.
 [[console-api]]
 === Write requests
 
-Console understands commands in a cURL-like syntax. 
-For example, the following is a `GET` request to the {es} `_search` API. 
+Console understands commands in a cURL-like syntax.
+For example, the following is a `GET` request to the {es} `_search` API.
 
 [source,js]
 ----------------------------------
@@ -43,23 +43,23 @@ curl -XGET "http://localhost:9200/_search" -d'
 }'
 ----------------------------------
 
-If you paste the above command into Console, {kib} automatically converts it
+When you paste the command into Console, {kib} automatically converts it
 to Console syntax.  Alternatively, if you want to want to see Console syntax in cURL, 
-click the action icon (image:dev-tools/console/images/wrench.png[]) and select *Copy as cURL*. 
+click the action icon (image:dev-tools/console/images/wrench.png[]) and select *Copy as cURL*.
 
 [float]
 [[console-autocomplete]]
 ==== Autocomplete
 
 When you're typing a command, Console makes context-sensitive suggestions.
-These suggestions show you the parameters for each API and speed up your typing. 
-To configure your preferences for autocomplete, go to 
-<<configuring-console, Settings>>. 
+These suggestions show you the parameters for each API and speed up your typing.
+To configure your preferences for autocomplete, go to
+<<configuring-console, Settings>>.
 
 [float]
 [[auto-formatting]]
 ==== Auto-formatting
-The auto-formatting 
+The auto-formatting
 capability can help you format requests. Select one or more requests that you
 want to format, click the action icon (image:dev-tools/console/images/wrench.png[]),
 and then select *Auto indent*.
@@ -69,27 +69,27 @@ For example, you might have a request formatted like this:
 [role="screenshot"]
 image::dev-tools/console/images/copy-curl.png["Console close-up"]
 
-Console adjusts the JSON body of the request to apply the indents. 
+Console adjusts the JSON body of the request to apply the indents.
 
 [role="screenshot"]
 image::dev-tools/console/images/request.png["Console close-up"]
 
-If you select *Auto indent* on a request that is already well formatted, 
-Console collapses the request body to a single line per document. 
+If you select *Auto indent* on a request that is already well formatted,
+Console collapses the request body to a single line per document.
 This is helpful when working with the {es} {ref}/docs-bulk.html[bulk APIs].
 
 
 
 [float]
 [[console-request]]
-=== Submit requests 
+=== Submit requests
 
-When you're ready to submit the request to {es}, click the 
+When you're ready to submit the request to {es}, click the
 green triangle.
 
 You can select multiple requests and submit them together.
-Console sends the requests to {es} one by one and shows the output 
-in the response pane. Submitting multiple request is helpful when you're debugging an issue or trying query 
+Console sends the requests to {es} one by one and shows the output
+in the response pane. Submitting multiple request is helpful when you're debugging an issue or trying query
 combinations in multiple scenarios.
 
 
@@ -105,15 +105,15 @@ the action icon (image:dev-tools/console/images/wrench.png[]) and select
 [[console-history]]
 === Get your request history
 
-Console maintains a list of the last 500 requests that {es} successfully executed. 
+Console maintains a list of the last 500 requests that {es} successfully executed.
 To view your most recent requests, click *History*. If you select a request
 and click *Apply*, {kib} adds it to the editor at the current cursor position.
 
 [float]
 [[configuring-console]]
 === Configure Console settings
 
-You can configure the Console font size, JSON syntax, 
+You can configure the Console font size, JSON syntax,
 and autocomplete suggestions in *Settings*.
 
 [role="screenshot"]
@@ -130,9 +130,7 @@ shortcuts, click *Help*.
 [[console-settings]]
 === Disable Console
 
-If you don’t want to use Console, you can disable it by setting `console.enabled` 
-to `false` in your `kibana.yml` configuration file. Changing this setting 
-causes the server to regenerate assets on the next startup, 
+If you don’t want to use Console, you can disable it by setting `console.enabled`
+to `false` in your `kibana.yml` configuration file. Changing this setting
+causes the server to regenerate assets on the next startup,
 which might cause a delay before pages start being served.
-
-
diff --git a/docs/dev-tools/searchprofiler/more-complicated.asciidoc b/docs/dev-tools/searchprofiler/more-complicated.asciidoc
@@ -25,7 +25,7 @@ POST test/_bulk
 // CONSOLE
 --
 
-. From the {searchprofiler}, enter "test" in the Index field above the query editor to restrict profiled 
+. From the {searchprofiler}, enter "test" in the *Index* field to restrict profiled 
 queries to the `test` index.
 
 . Replace the default `match_all` query in the query editor with a query that has two sub-query
@@ -66,7 +66,7 @@ components and includes a simple aggregation, like the example below.
 // NOTCONSOLE
 --
 
-. Click *Profile* to profile the query and visualize the results. 
+. Click *Profile* to profile the query and visualize the results.
 . Select the shard to view the query details.
 +
 [role="screenshot"]
@@ -100,5 +100,5 @@ Select the name of the shard to view the aggregation details and timing breakdow
 image::dev-tools/searchprofiler/images/gs10.png["Drilling into the first shard's details"]
 
 For more information about how the {searchprofiler} works, how timings are calculated, and
-how to interpret various results, see 
+how to interpret various results, see
 {ref}/search-profile.html#profiling-queries[Profiling queries].
diff --git a/docs/developer/core/development-dependencies.asciidoc b/docs/developer/core/development-dependencies.asciidoc
@@ -96,8 +96,8 @@ module.exports = window.angular;
 
 What this shim does is fairly simple if you go line by line:
 
-. makes sure that jQuery is loaded before angular (which actually runs the shim above)
+. makes sure that jQuery is loaded before angular (which actually runs the shim)
 . load the angular.js file from the node_modules directory
 . load the angular-elastic plugin, a plugin we want to always be included whenever we import angular
 . use the `ui/modules` module to add the module exported by angular-elastic as a dependency to the `kibana` angular module
-. finally, export the window.angular variable. This means that writing `import angular from 'angular';` will properly set the angular variable to the angular library, rather than undefined which is the default behavior.
+. finally, export the window.angular variable. This means that writing `import angular from 'angular';` will properly set the angular variable to the angular library, rather than undefined which is the default behavior.
diff --git a/docs/developer/core/development-modules.asciidoc b/docs/developer/core/development-modules.asciidoc
@@ -20,7 +20,7 @@ certain components. Here is a breakdown of those modules:
     the required modules and import them were they are actually necessary.
 
 - *`import 'ui/autoload/all'`*
-    Imports all of the above modules
+    Imports all of the modules
 
 [float]
 ==== Resolving Require Paths
@@ -60,4 +60,4 @@ Here is how import/require statements are resolved to a file:
     ** path/index + '.js'
     ** path/index + '.json'
     ** path/index
-  * if none of the above paths matches then an error is thrown
+  * if none of the paths matches then an error is thrown
diff --git a/docs/developer/plugin/development-plugin-feature-registration.asciidoc b/docs/developer/plugin/development-plugin-feature-registration.asciidoc
@@ -175,7 +175,7 @@ init(server) {
 }
 -----------
 
-Unlike the Canvas example above, Dev Tools does not require access to any saved objects to function. Dev Tools does specify an API endpoint, however. When this is configured, the Security plugin will automatically authorize access to any server API route that is tagged with `access:console`, similar to the following:
+Unlike the Canvas example, Dev Tools does not require access to any saved objects to function. Dev Tools does specify an API endpoint, however. When this is configured, the Security plugin will automatically authorize access to any server API route that is tagged with `access:console`, similar to the following:
 
 ["source","javascript"]
 -----------

diff --git a/docs/developer/plugin/development-plugin-localization.asciidoc b/docs/developer/plugin/development-plugin-localization.asciidoc
@@ -68,7 +68,7 @@ This outputs a `en.json` file inside the `translations` directory. To localize o
 Checking i18n does the following:
 
 * Checks all existing labels for violations.
-* Takes translations from `.i18nrc.json` and compares them to the messages extracted and validated at the step above and:
+* Takes translations from `.i18nrc.json` and compares them to the messages extracted and validated.
 ** Checks for unused translations. If you remove a label that has a corresponding translation, you must also remove the label from the translations file.
 ** Checks for incompatible translations.  If you add or remove a new parameter from an existing string, you must also remove the label from the translations file.
 
@@ -86,7 +86,7 @@ node scripts/i18n_check --fix --include-config ../kibana-extra/myPlugin/.i18nrc.
 Kibana relies on several UI frameworks (ReactJS and AngularJS) and
 requires localization in different environments (browser and NodeJS).
 The internationalization engine is framework agnostic and consumable in
-all parts of Kibana (ReactJS, AngularJS and NodeJS). 
+all parts of Kibana (ReactJS, AngularJS and NodeJS).
 
 To simplify
 internationalization in UI frameworks, additional abstractions are
@@ -112,7 +112,7 @@ export const HELLO_WORLD = i18n.translate('hello.wonderful.world', {
 Full details are {repo}tree/master/packages/kbn-i18n#vanilla-js[here].
 
 [float]
-===== i18n for React 
+===== i18n for React
 
 To localize strings in React, use either `FormattedMessage` or `i18n.translate`.
 
@@ -138,7 +138,7 @@ Full details are {repo}tree/master/packages/kbn-i18n#react[here].
 
 
 [float]
-===== i18n for Angular 
+===== i18n for Angular
 
 You are encouraged to use `i18n.translate()` by statically importing `i18n` from `@kbn/i18n` wherever possible in your Angular code. Angular wrappers use the translation `service` with the i18n engine under the hood.
 

diff --git a/docs/developer/pr-review.asciidoc b/docs/developer/pr-review.asciidoc
@@ -67,7 +67,7 @@ Enhancements are pretty much always going to have extensive unit tests as a base
 [float]
 === Product level review
 
-Reviewers are not simply evaluating the code itself, they are also evaluating the quality of the user-facing change in the product. This generally means they need to check out the branch locally and "play around" with it. In addition to the "do we want this change in the product" details from above, the reviewer should be looking for bugs and evaluating how approachable and useful the feature is as implemented. Special attention should be given to error scenarios and edge cases to ensure they are all handled well within the product.
+Reviewers are not simply evaluating the code itself, they are also evaluating the quality of the user-facing change in the product. This generally means they need to check out the branch locally and "play around" with it. In addition to the "do we want this change in the product" details, the reviewer should be looking for bugs and evaluating how approachable and useful the feature is as implemented. Special attention should be given to error scenarios and edge cases to ensure they are all handled well within the product.
 
 
 [float]
@@ -107,7 +107,7 @@ Conflicting opinions between reviewers and authors happen, and sometimes it is h
 
 Whether or not a bit of feedback is appropriate for a pull request is often dependent on the motivation for giving the feedback in the first place.
 
-_Demanding_ an author make changes based primarily on the mindset of "how would I write this code?" isn't appropriate. The reviewer didn't write the code, and their critical purpose in the review process is not to craft the contribution into a form that is simply whatever they would have written if they had. If a reviewer wants to provide this type of feedback, they should qualify it as a "nit" as mentioned in the nitpicking section above to make it clear that the author can take it or leave it.
+_Demanding_ an author make changes based primarily on the mindset of "how would I write this code?" isn't appropriate. The reviewer didn't write the code, and their critical purpose in the review process is not to craft the contribution into a form that is simply whatever they would have written if they had. If a reviewer wants to provide this type of feedback, they should qualify it as a "nit" as mentioned in the nitpicking section to make it clear that the author can take it or leave it.
 
 Inflammatory feedback such as "this is crap" isn't feedback at all. It's both mean and unhelpful, and it is never appropriate.
 

diff --git a/docs/development/core/server/kibana-plugin-server.authnothandled.md b/docs/development/core/server/kibana-plugin-server.authnothandled.md
@@ -0,0 +1,19 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthNotHandled](./kibana-plugin-server.authnothandled.md)
+
+## AuthNotHandled interface
+
+
+<b>Signature:</b>
+
+```typescript
+export interface AuthNotHandled 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [type](./kibana-plugin-server.authnothandled.type.md) | <code>AuthResultType.notHandled</code> |  |
+
diff --git a/docs/development/core/server/kibana-plugin-server.authnothandled.type.md b/docs/development/core/server/kibana-plugin-server.authnothandled.type.md
@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthNotHandled](./kibana-plugin-server.authnothandled.md) &gt; [type](./kibana-plugin-server.authnothandled.type.md)
+
+## AuthNotHandled.type property
+
+<b>Signature:</b>
+
+```typescript
+type: AuthResultType.notHandled;
+```
-Original file line number
+Diff line change
@@ Expand Up / @@ -175,7 +175,7 @@ init(server) { @@
     }
     -----------
-    Unlike the Canvas example above, Dev Tools does not require access to any saved objects to function. Dev Tools does specify an API endpoint, however. When this is configured, the Security plugin will automatically authorize access to any server API route that is tagged with `access:console`, similar to the following:
+    Unlike the Canvas example, Dev Tools does not require access to any saved objects to function. Dev Tools does specify an API endpoint, however. When this is configured, the Security plugin will automatically authorize access to any server API route that is tagged with `access:console`, similar to the following:
     ["source","javascript"]
     -----------
@@ Expand Down @@