Skip to content

Commit

Permalink
[ML] Move APM Latency Correlations from flyout to transactions page. (#…
Browse files Browse the repository at this point in the history
…107266)

- Moves APM Latency Correlations from flyout to transactions page.
- Introduces a tab based navigation for `Trace samples` / `Latency correlations` / `Failed transactions correlations`
- For trace samples, the previous low detailed histogram chart gets replaced with the new log log based histogram chart. Users can drag select a range of lantency to filter trace samples.
- Removes code related to the previous distribution chart. Renames `useTransactionDistributionFetcher` to `useTransactionTraceSamplesFetcher`. Instead of a histogram with top hits, this will now just return a sample of traces for the given filters.
  • Loading branch information
walterra authored Aug 17, 2021
1 parent d62ff55 commit d07f7a5
Show file tree
Hide file tree
Showing 45 changed files with 1,871 additions and 2,311 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface SearchServiceParams {
start?: string;
end?: string;
percentileThreshold?: number;
percentileThresholdValue?: number;
analyzeCorrelations?: boolean;
}

export interface SearchServiceFetchParams extends SearchServiceParams {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,7 @@ type CorrelationsApiResponse = NonNullable<
APIReturnType<'GET /api/apm/correlations/errors/failed_transactions'>
>;

interface Props {
onClose: () => void;
}

export function ErrorCorrelations({ onClose }: Props) {
export function ErrorCorrelations() {
const [
selectedSignificantTerm,
setSelectedSignificantTerm,
Expand Down Expand Up @@ -130,7 +126,9 @@ export function ErrorCorrelations({ onClose }: Props) {
);

const trackApmEvent = useUiTracker({ app: 'apm' });
trackApmEvent({ metric: 'view_errors_correlations' });
trackApmEvent({ metric: 'view_failed_transactions' });

const onFilter = () => {};

return (
<>
Expand Down Expand Up @@ -175,7 +173,7 @@ export function ErrorCorrelations({ onClose }: Props) {
}
status={correlationsStatus}
setSelectedSignificantTerm={setSelectedSignificantTerm}
onFilter={onClose}
onFilter={onFilter}
/>
</EuiFlexItem>
<EuiFlexItem>
Expand Down
258 changes: 0 additions & 258 deletions x-pack/plugins/apm/public/components/app/correlations/index.tsx

This file was deleted.

Loading

0 comments on commit d07f7a5

Please sign in to comment.