Merge branch 'master' of github.com:elastic/kibana into override-anom…

…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (76 commits) Fix z-index of KQL Suggestions dropdown (#79184) [babel] remove unused/unneeded babel plugins (#79173) [Search] Fix timeout upgrade link (#79045) Always Show Embeddable Panel Header in Edit Mode (#79152) [Ingest]: add more test for transform index (#79154) [ML] DF Analytics: Collapsable sections on results pages (#76641) [Fleet] Fix agent policy change action migration (#79046) [Ingest Manager] Match package spec `dataset`->`data_stream` and `config_templates`->`policy_templates` renaming (#78699) Revert "[Metrics UI] Add ability to override datafeeds and job config for partition field (#78875)" [ML] Update transform cloning to include description and new fields (#78364) chore(NA): remove non existing plugin paths from case api integration tests (#79127) [Ingest Manager] Ensure we trigger agent policy updated event when we bump revision. (#78836) [Metrics UI] Display No Data context.values as [NO DATA] (#78038) [Monitoring] Missing data alert (#78208) [Lens] Fix embeddable title and description for reporting and dashboard tooltip (#78767) [Lens] Consistent Drag and Drop styles (#78674) [ML] Model management UI fixes and enhancements (#79072) [Metrics UI] Add ability to override datafeeds and job config for partition field (#78875) [Security Solution]Fix basepath used by endpoint telemetry tests (#79027) update rum agent version which contains longtasks (#79105) ...
elastic · Oct 1, 2020 · cfaef1d · cfaef1d
2 parents f14915d + d0f8e5c
commit cfaef1d
Show file tree

Hide file tree

Showing 609 changed files with 11,904 additions and 3,948 deletions.
diff --git a/.telemetryrc.json b/.telemetryrc.json
@@ -5,8 +5,7 @@
     "exclude": [
       "src/plugins/kibana_react/",
       "src/plugins/testbed/",
-      "src/plugins/kibana_utils/",
-      "src/plugins/kibana_usage_collection/server/collectors/ui_metric/telemetry_ui_metric_collector.ts"
+      "src/plugins/kibana_utils/"
     ]
   }
 ]
diff --git a/docs/developer/contributing/development-github.asciidoc b/docs/developer/contributing/development-github.asciidoc
@@ -25,7 +25,7 @@ Pull requests are made into the `master` branch and then backported when it is s
 * Breaking changes do not get backported and only go into `master`.
 * All non-breaking changes can be backported to the `<major>.x` branch.
 * Features should not be backported to a `<major>.<minor>` branch.
-* Bugs can be backported to a `<major>.<minor>` branch if the changes are safe and appropriate. Safety is a judgment call you make based on factors like the bug's severity, test coverage, confidence in the changes, etc. Your reasoning should be included in the pull request description.
+* Bug fixes can be backported to a `<major>.<minor>` branch if the changes are safe and appropriate. Safety is a judgment call you make based on factors like the bug's severity, test coverage, confidence in the changes, etc. Your reasoning should be included in the pull request description.
 * Documentation changes can be backported to any branch at any time.
 
 [discrete]

diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
@@ -48,7 +48,7 @@ NOTE:
 
 
 |{kib-repo}blob/{branch}/src/plugins/data/README.md[data]
-|data plugin provides common data access services.
+|The data plugin provides common data access services, such as search and query, for solutions and application developers.
 
 
 |{kib-repo}blob/{branch}/src/plugins/dev_tools/README.md[devTools]

diff --git a/...elopment/core/public/kibana-plugin-core-public.applicationstart.geturlforapp.md b/...elopment/core/public/kibana-plugin-core-public.applicationstart.geturlforapp.md
@@ -4,9 +4,11 @@
 
 ## ApplicationStart.getUrlForApp() method
 
-Returns an URL to a given app, including the global base path. By default, the URL is relative (/basePath/app/my-app). Use the `absolute` option to generate an absolute url (http://host:port/basePath/app/my-app)
+Returns the absolute path (or URL) to a given app, including the global base path.
 
-Note that when generating absolute urls, the origin (protocol, host and port) are determined from the browser's location.
+By default, it returns the absolute path of the application (e.g `/basePath/app/my-app`<!-- -->). Use the `absolute` option to generate an absolute url instead (e.g `http://host:port/basePath/app/my-app`<!-- -->)
+
+Note that when generating absolute urls, the origin (protocol, host and port) are determined from the browser's current location.
 
 <b>Signature:</b>
 

diff --git a/docs/development/core/public/kibana-plugin-core-public.applicationstart.md b/docs/development/core/public/kibana-plugin-core-public.applicationstart.md
@@ -23,8 +23,8 @@ export interface ApplicationStart
 
 |  Method | Description |
 |  --- | --- |
-|  [getUrlForApp(appId, options)](./kibana-plugin-core-public.applicationstart.geturlforapp.md) | Returns an URL to a given app, including the global base path. By default, the URL is relative (/basePath/app/my-app). Use the <code>absolute</code> option to generate an absolute url (http://host:port/basePath/app/my-app)<!-- -->Note that when generating absolute urls, the origin (protocol, host and port) are determined from the browser's location. |
+|  [getUrlForApp(appId, options)](./kibana-plugin-core-public.applicationstart.geturlforapp.md) | Returns the absolute path (or URL) to a given app, including the global base path.<!-- -->By default, it returns the absolute path of the application (e.g <code>/basePath/app/my-app</code>). Use the <code>absolute</code> option to generate an absolute url instead (e.g <code>http://host:port/basePath/app/my-app</code>)<!-- -->Note that when generating absolute urls, the origin (protocol, host and port) are determined from the browser's current location. |
 |  [navigateToApp(appId, options)](./kibana-plugin-core-public.applicationstart.navigatetoapp.md) | Navigate to a given app |
-|  [navigateToUrl(url)](./kibana-plugin-core-public.applicationstart.navigatetourl.md) | Navigate to given url, which can either be an absolute url or a relative path, in a SPA friendly way when possible.<!-- -->If all these criteria are true for the given url: - (only for absolute URLs) The origin of the URL matches the origin of the browser's current location - The pathname of the URL starts with the current basePath (eg. /mybasepath/s/my-space) - The pathname segment after the basePath matches any known application route (eg. /app/<id>/ or any application's <code>appRoute</code> configuration)<!-- -->Then a SPA navigation will be performed using <code>navigateToApp</code> using the corresponding application and path. Otherwise, fallback to a full page reload to navigate to the url using <code>window.location.assign</code> |
+|  [navigateToUrl(url)](./kibana-plugin-core-public.applicationstart.navigatetourl.md) | Navigate to given URL in a SPA friendly way when possible (when the URL will redirect to a valid application within the current basePath).<!-- -->The method resolves pathnames the same way browsers do when resolving a <code>&lt;a href&gt;</code> value. The provided <code>url</code> can be: - an absolute URL - an absolute path - a path relative to the current URL (window.location.href)<!-- -->If all these criteria are true for the given URL: - (only for absolute URLs) The origin of the URL matches the origin of the browser's current location - The resolved pathname of the provided URL/path starts with the current basePath (eg. /mybasepath/s/my-space) - The pathname segment after the basePath matches any known application route (eg. /app/<id>/ or any application's <code>appRoute</code> configuration)<!-- -->Then a SPA navigation will be performed using <code>navigateToApp</code> using the corresponding application and path. Otherwise, fallback to a full page reload to navigate to the url using <code>window.location.assign</code> |
 |  [registerMountContext(contextName, provider)](./kibana-plugin-core-public.applicationstart.registermountcontext.md) | Register a context provider for application mounting. Will only be available to applications that depend on the plugin that registered this context. Deprecated, use [CoreSetup.getStartServices](./kibana-plugin-core-public.coresetup.getstartservices.md)<!-- -->. |
 
diff --git a/...lopment/core/public/kibana-plugin-core-public.applicationstart.navigatetourl.md b/...lopment/core/public/kibana-plugin-core-public.applicationstart.navigatetourl.md
@@ -4,9 +4,11 @@
 
 ## ApplicationStart.navigateToUrl() method
 
-Navigate to given url, which can either be an absolute url or a relative path, in a SPA friendly way when possible.
+Navigate to given URL in a SPA friendly way when possible (when the URL will redirect to a valid application within the current basePath).
 
-If all these criteria are true for the given url: - (only for absolute URLs) The origin of the URL matches the origin of the browser's current location - The pathname of the URL starts with the current basePath (eg. /mybasepath/s/my-space) - The pathname segment after the basePath matches any known application route (eg. /app/<id>/ or any application's `appRoute` configuration)
+The method resolves pathnames the same way browsers do when resolving a `<a href>` value. The provided `url` can be: - an absolute URL - an absolute path - a path relative to the current URL (window.location.href)
+
+If all these criteria are true for the given URL: - (only for absolute URLs) The origin of the URL matches the origin of the browser's current location - The resolved pathname of the provided URL/path starts with the current basePath (eg. /mybasepath/s/my-space) - The pathname segment after the basePath matches any known application route (eg. /app/<id>/ or any application's `appRoute` configuration)
 
 Then a SPA navigation will be performed using `navigateToApp` using the corresponding application and path. Otherwise, fallback to a full page reload to navigate to the url using `window.location.assign`
 
@@ -20,7 +22,7 @@ navigateToUrl(url: string): Promise<void>;
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  url | <code>string</code> | an absolute url, or a relative path, to navigate to. |
+|  url | <code>string</code> | an absolute URL, an absolute path or a relative path, to navigate to. |
 
 <b>Returns:</b>
 
@@ -35,11 +37,14 @@ navigateToUrl(url: string): Promise<void>;
 // will call `application.navigateToApp('discover', { path: '/some-path?foo=bar'})`
 application.navigateToUrl('https://kibana:8080/base-path/s/my-space/app/discover/some-path?foo=bar')
 application.navigateToUrl('/base-path/s/my-space/app/discover/some-path?foo=bar')
+application.navigateToUrl('./discover/some-path?foo=bar')
 
 // will perform a full page reload using `window.location.assign`
 application.navigateToUrl('https://elsewhere:8080/base-path/s/my-space/app/discover/some-path') // origin does not match
 application.navigateToUrl('/app/discover/some-path') // does not include the current basePath
 application.navigateToUrl('/base-path/s/my-space/app/unknown-app/some-path') // unknown application
+application.navigateToUrl('../discover') // resolve to `/base-path/s/my-space/discover` which is not a path of a known app.
+application.navigateToUrl('../../other-space/discover') // resolve to `/base-path/s/other-space/discover` which is not within the current basePath.
 
 ```
 
diff --git a/...ana-plugin-plugins-expressions-public.expressionrenderdefinition.displayname.md b/...ana-plugin-plugins-expressions-public.expressionrenderdefinition.displayname.md
@@ -9,5 +9,5 @@ A user friendly name of the renderer as will be displayed to user in UI.
 <b>Signature:</b>
 
 ```typescript
-displayName: string;
+displayName?: string;
 ```
diff --git a/...ana-plugin-plugins-expressions-server.expressionrenderdefinition.displayname.md b/...ana-plugin-plugins-expressions-server.expressionrenderdefinition.displayname.md
@@ -9,5 +9,5 @@ A user friendly name of the renderer as will be displayed to user in UI.
 <b>Signature:</b>
 
 ```typescript
-displayName: string;
+displayName?: string;
 ```
diff --git a/docs/user/alerting/action-types/jira.asciidoc b/docs/user/alerting/action-types/jira.asciidoc
@@ -69,6 +69,8 @@ Priority::              The priority of the incident.
 Labels::              The labels of the incident.
 Title::    A title for the issue, used for searching the contents of the knowledge base. 
 Description::          The details about the incident.
+Parent::              The parent issue id or key. Only for `Sub-task` issue types.
+Priority::              The priority of the incident.
 Additional comments::  Additional information for the client, such as how to troubleshoot the issue.
 
 [[configuring-jira]]

diff --git a/docs/user/dashboard/dashboard-drilldown.asciidoc b/docs/user/dashboard/dashboard-drilldown.asciidoc
@@ -11,6 +11,26 @@ This example shows a dashboard panel that contains a pie chart with a configured
 [role="screenshot"]
 image::images/drilldown_on_piechart.gif[Drilldown on pie chart that navigates to another dashboard]
 
+[float]
+[[dashboard-drilldown-supported-panels]]
+==== Supported panels
+
+The following panels support dashboard drilldowns:
+
+* Lens
+* Area
+* Data table
+* Heat map
+* Horizontal bar
+* Line
+* Maps
+* Pie
+* TSVB
+* Tag cloud
+* Timelion
+* Vega
+* Vertical bar
+
 [float]
 [[drilldowns-example]]
 ==== Try it: Create a dashboard drilldown
@@ -74,3 +94,4 @@ image::images/drilldown_on_panel.png[Drilldown on pie chart that navigates to an
 +
 You are navigated to your destination dashboard. Verify that the search query, filters,
 and time range are carried over.
+
diff --git a/docs/user/dashboard/url-drilldown.asciidoc b/docs/user/dashboard/url-drilldown.asciidoc
@@ -14,6 +14,22 @@ image:images/url_drilldown_go_to_github.gif[Drilldown on pie chart that navigate
 
 NOTE: URL drilldown is available with the https://www.elastic.co/subscriptions[Gold subscription] and higher.
 
+[float]
+[[url-drilldown-supported-panels]]
+==== Supported panels
+
+The following panels support URL drilldowns:
+
+* Lens
+* Area
+* Data table
+* Heat map
+* Horizontal bar
+* Line
+* Pie
+* Tag cloud
+* Vertical bar
+
 [float]
 [[try-it]]
 ==== Try it: Create a URL drilldown

diff --git a/docs/user/dashboard/vega-reference.asciidoc b/docs/user/dashboard/vega-reference.asciidoc
@@ -11,7 +11,7 @@ For additional *Vega* and *Vega-Lite* information, refer to the reference sectio
 
 {kib} has extended Vega and Vega-Lite with extensions that support:
 
-* Default height and width
+* Automatic sizing
 * Default theme to match {kib}
 * Writing {es} queries using the time range and filters from dashboards
 * Using the Elastic Map Service in Vega maps
@@ -22,12 +22,35 @@ For additional *Vega* and *Vega-Lite* information, refer to the reference sectio
 
 [float]
 [[vega-sizing-and-positioning]]
-==== Default height and width
+==== Automatic sizing
 
-By default, Vega visualizations use the `autosize = { type: 'fit', contains: 'padding' }` layout.
-`fit` uses all available space, ignores `width` and `height` values,
-and respects the padding values. To override this behavior, change the
-`autosize` value.
+Most users will want their Vega visualizations to take the full available space, so unlike
+Vega examples, `width` and `height` are not required parameters in {kib}. To set the width
+or height manually, set `autosize: none`. For example, to set the height to a specific pixel value:
+
+```
+autosize: none
+width: container
+height: 200
+```
+
+The default {kib} settings which are inherited by your visualizations are:
+
+```
+autosize: {
+  type: fit
+  contains: padding
+}
+width: container
+height: container
+```
+
+{kib} is able to merge your custom `autosize` settings with the defaults. The options `fit-x`
+and `fit-y` are supported but not recommended over the default `fit` setting.
+
+To learn more, read about
+https://vega.github.io/vega/docs/specification/#autosize[autosize]
+in the Vega documentation.
 
 [float]
 [[vega-theme]]

diff --git a/package.json b/package.json
@@ -229,7 +229,7 @@
   "devDependencies": {
     "@babel/parser": "^7.11.2",
     "@babel/types": "^7.11.0",
-    "@elastic/apm-rum": "^5.6.0",
+    "@elastic/apm-rum": "^5.6.1",
     "@elastic/charts": "21.1.2",
     "@elastic/ems-client": "7.10.0",
     "@elastic/eslint-config-kibana": "0.15.0",
@@ -478,7 +478,7 @@
     "tree-kill": "^1.2.2",
     "typescript": "4.0.2",
     "ui-select": "0.19.8",
-    "vega": "^5.16.1",
+    "vega": "^5.17.0",
     "vega-lite": "^4.16.8",
     "vega-schema-url-parser": "^2.1.0",
     "vega-tooltip": "^0.24.2",

diff --git a/packages/kbn-ace/README.md b/packages/kbn-ace/README.md
@@ -1,5 +1,20 @@
 # @kbn/ace
 
-Contains all Kibana-specific brace related code. Excluding the code that still inside of Console because that code is only used inside of console at the moment.
+This package contains the XJSON mode for brace. This is an extension of the `brace/mode/json` mode.
 
-This package enables plugins to use this functionality and import it as needed -- behind an async import so that brace does not bloat the JS code needed for first page load of Kibana.
+This package also contains an import of the entire brace editor which is used for creating the custom XJSON worker.
+
+## Note to plugins
+_This code should not be eagerly loaded_.
+
+Make sure imports of this package are behind a lazy-load `import()` statement.
+
+Your plugin should already be loading application code this way in the `mount` function.
+
+## Deprecated
+
+This package is considered deprecated and will be removed in future.
+
+New and existing editor functionality should use Monaco.
+
+_Do not add new functionality to this package_. Build new functionality for Monaco and use it instead.
diff --git a/packages/kbn-babel-preset/node_preset.js b/packages/kbn-babel-preset/node_preset.js
@@ -18,23 +18,6 @@
  */
 
 module.exports = (_, options = {}) => {
-  const overrides = [];
-  if (!process.env.ALLOW_PERFORMANCE_HOOKS_IN_TASK_MANAGER) {
-    overrides.push({
-      test: [/x-pack[\/\\]legacy[\/\\]plugins[\/\\]task_manager/],
-      plugins: [
-        [
-          require.resolve('babel-plugin-filter-imports'),
-          {
-            imports: {
-              perf_hooks: ['performance'],
-            },
-          },
-        ],
-      ],
-    });
-  }
-
   return {
     presets: [
       [
@@ -74,6 +57,5 @@ module.exports = (_, options = {}) => {
         },
       ],
     ],
-    overrides,
   };
 };
diff --git a/packages/kbn-babel-preset/package.json b/packages/kbn-babel-preset/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@kbn/babel-preset",
-  "private": true,
   "version": "1.0.0",
+  "private": true,
   "license": "Apache-2.0",
   "dependencies": {
     "@babel/plugin-proposal-class-properties": "^7.10.4",
@@ -13,10 +13,8 @@
     "@babel/preset-react": "^7.10.4",
     "@babel/preset-typescript": "^7.10.4",
     "babel-plugin-add-module-exports": "^1.0.2",
-    "babel-plugin-filter-imports": "^3.0.0",
     "babel-plugin-styled-components": "^1.10.7",
     "babel-plugin-transform-define": "^1.3.1",
-    "babel-plugin-transform-imports": "^2.0.0",
     "react-is": "^16.8.0",
     "styled-components": "^5.1.0"
   }

diff --git a/packages/kbn-babel-preset/webpack_preset.js b/packages/kbn-babel-preset/webpack_preset.js
@@ -40,24 +40,5 @@ module.exports = () => {
         },
       ],
     ],
-    // NOTE: we can enable this by default for everything as soon as we only have one instance
-    // of lodash across the entire project. For now we are just enabling it for siem
-    // as they are extensively using the lodash v4
-    overrides: [
-      {
-        test: [/x-pack[\/\\]legacy[\/\\]plugins[\/\\]siem[\/\\]public/],
-        plugins: [
-          [
-            require.resolve('babel-plugin-transform-imports'),
-            {
-              'lodash/?(((\\w*)?/?)*)': {
-                transform: 'lodash/${1}/${member}',
-                preventFullImport: false,
-              },
-            },
-          ],
-        ],
-      },
-    ],
   };
 };
diff --git a/packages/kbn-config/src/env.test.ts b/packages/kbn-config/src/env.test.ts
@@ -198,6 +198,18 @@ test('pluginSearchPaths contains x-pack/examples plugins path if --run-examples
   expect(env.pluginSearchPaths).toContain('/some/home/dir/x-pack/examples');
 });
 
+test('pluginSearchPaths does not contain x-pack/examples plugins path if --oss flag is true', () => {
+  const env = new Env(
+    '/some/home/dir',
+    packageInfos,
+    getEnvOptions({
+      cliArgs: { runExamples: true, oss: true },
+    })
+  );
+
+  expect(env.pluginSearchPaths).not.toContain('/some/home/dir/x-pack/examples');
+});
+
 test('pluginSearchPaths does not contains examples plugins path if --run-examples flag is false', () => {
   const env = new Env(
     '/some/home/dir',

diff --git a/packages/kbn-config/src/env.ts b/packages/kbn-config/src/env.ts
@@ -123,8 +123,9 @@ export class Env {
       resolve(this.homeDir, 'src', 'plugins'),
       ...(options.cliArgs.oss ? [] : [resolve(this.homeDir, 'x-pack', 'plugins')]),
       resolve(this.homeDir, 'plugins'),
-      ...(options.cliArgs.runExamples
-        ? [resolve(this.homeDir, 'examples'), resolve(this.homeDir, 'x-pack', 'examples')]
+      ...(options.cliArgs.runExamples ? [resolve(this.homeDir, 'examples')] : []),
+      ...(options.cliArgs.runExamples && !options.cliArgs.oss
+        ? [resolve(this.homeDir, 'x-pack', 'examples')]
         : []),
       resolve(this.homeDir, '..', 'kibana-extra'),
     ];

diff --git a/packages/kbn-std/src/index.ts b/packages/kbn-std/src/index.ts
@@ -24,6 +24,6 @@ export { mapToObject } from './map_to_object';
 export { merge } from './merge';
 export { pick } from './pick';
 export { withTimeout } from './promise';
-export { isRelativeUrl, modifyUrl, URLMeaningfulParts } from './url';
+export { isRelativeUrl, modifyUrl, getUrlOrigin, URLMeaningfulParts } from './url';
 export { unset } from './unset';
 export { getFlattenedObject } from './get_flattened_object';