Merge branch 'master' of github.com:elastic/kibana

.bazelrc

@@ -11,7 +11,7 @@ import %workspace%/.bazelrc.common
 
 # BuildBuddy
 ## Metadata settings
-build --workspace_status_command=$(pwd)/src/dev/bazel_workspace_status.sh
+build --workspace_status_command="node ./src/dev/bazel_workspace_status.js"
 # Enable this in case you want to share your build info
 # build --build_metadata=VISIBILITY=PUBLIC
 build --build_metadata=TEST_GROUPS=//packages

.ci/end2end.groovy

@@ -121,15 +121,9 @@ pipeline {
 }
 
 def notifyStatus(String description, String status) {
-  notify(context: 'end2end-for-apm-ui', description: description, status: status, targetUrl: getBlueoceanTabURL('pipeline'))
+  withGithubStatus.notify('end2end-for-apm-ui', description, status, getBlueoceanTabURL('pipeline'))
 }
 
 def notifyTestStatus(String description, String status) {
-  notify(context: 'end2end-for-apm-ui', description: description, status: status, targetUrl: getBlueoceanTabURL('tests'))
-}
-
-def notify(Map args = [:]) {
-  retryWithSleep(retries: 2, seconds: 5, backoff: true) {
-    githubNotify(context: args.context, description: args.description, status: args.status, targetUrl: args.targetUrl)
-  }
+  withGithubStatus.notify('end2end-for-apm-ui', description, status, getBlueoceanTabURL('tests'))
 }

.ci/es-snapshots/Jenkinsfile_verify_es

@@ -29,7 +29,6 @@ kibanaPipeline(timeoutMinutes: 150) {
       withEnv(["ES_SNAPSHOT_MANIFEST=${SNAPSHOT_MANIFEST}"]) {
         parallel([
           'kibana-intake-agent': workers.intake('kibana-intake', './test/scripts/jenkins_unit.sh'),
-          'x-pack-intake-agent': workers.intake('x-pack-intake', './test/scripts/jenkins_xpack.sh'),
           'kibana-oss-agent': workers.functional('kibana-oss-tests', { kibanaPipeline.buildOss() }, [
             'oss-ciGroup1': kibanaPipeline.ossCiGroupProcess(1),
             'oss-ciGroup2': kibanaPipeline.ossCiGroupProcess(2),

.ci/jobs.yml

@@ -2,7 +2,6 @@
 
 JOB:
   - kibana-intake
-  - x-pack-intake
   - kibana-firefoxSmoke
   - kibana-ciGroup1
   - kibana-ciGroup2

.ci/packer_cache_for_branch.sh

@@ -26,7 +26,6 @@ source src/dev/ci_setup/setup.sh;
 
 # download es snapshots
 node scripts/es snapshot --download-only;
-node scripts/es snapshot --license=oss --download-only;
 
 # download reporting browsers
 (cd "x-pack" && node ../node_modules/.bin/gulp downloadChromium);

.eslintrc.js

@@ -1119,6 +1119,39 @@ module.exports = {
       // All files
       files: ['x-pack/plugins/enterprise_search/**/*.{ts,tsx}'],
       rules: {
+        'import/order': [
+          'error',
+          {
+            groups: ['unknown', ['builtin', 'external'], 'internal', 'parent', 'sibling', 'index'],
+            pathGroups: [
+              {
+                pattern:
+                  '{../../../../../../,../../../../../,../../../../,../../../,../../,../}{common/,*}__mocks__{*,/**}',
+                group: 'unknown',
+              },
+              {
+                pattern: '{**,.}/*.mock',
+                group: 'unknown',
+              },
+              {
+                pattern: 'react*',
+                group: 'external',
+                position: 'before',
+              },
+              {
+                pattern: '{@elastic/**,@kbn/**,src/**}',
+                group: 'internal',
+              },
+            ],
+            pathGroupsExcludedImportTypes: [],
+            alphabetize: {
+              order: 'asc',
+              caseInsensitive: true,
+            },
+            'newlines-between': 'always-and-inside-groups',
+          },
+        ],
+        'import/newline-after-import': 'error',
         'react-hooks/exhaustive-deps': 'off',
         'react/jsx-boolean-value': ['error', 'never'],
       },

.github/CODEOWNERS

@@ -26,6 +26,7 @@
 /src/plugins/vis_type_xy/ @elastic/kibana-app
 /src/plugins/visualize/ @elastic/kibana-app
 /src/plugins/visualizations/ @elastic/kibana-app
+/packages/kbn-tinymath/ @elastic/kibana-app
 
 # Application Services
 /examples/bfetch_explorer/ @elastic/kibana-app-services
@@ -91,6 +92,7 @@
 /src/plugins/dashboard/ @elastic/kibana-presentation
 /src/plugins/input_control_vis/ @elastic/kibana-presentation
 /src/plugins/vis_type_markdown/ @elastic/kibana-presentation
+/test/functional/apps/dashboard/  @elastic/kibana-presentation
 /x-pack/plugins/canvas/  @elastic/kibana-presentation
 /x-pack/plugins/dashboard_enhanced/ @elastic/kibana-presentation
 /x-pack/test/functional/apps/canvas/  @elastic/kibana-presentation

docs/developer/contributing/development-ci-metrics.asciidoc

@@ -121,13 +121,20 @@ Changes to the {kib-repo}blob/{branch}/packages/kbn-optimizer/limits.yml[`limits
 [[ci-metric-validating-limits]]
 === Validating `page load bundle size` limits
 
-Once you've fixed any issues discovered while diagnosing overages you probably should just push the changes to your PR and let CI validate them.
+While you're trying to track down changes which will improve the bundle size, try running the following command locally:
 
-If you have a pretty powerful dev machine, or the necessary patience/determination, you can validate the limits locally by running the following command:
+[source,shell]
+-----------
+node scripts/build_kibana_platform_plugins --dist --watch --focus {pluginId}
+-----------
+
+This will build the front-end bundles for your plugin and only the plugins your plugin depends on. Whenever you make changes the bundles are rebuilt and you can inspect the metrics of that build in the `target/public/metrics.json` file within your plugin. This file will be updated as you save changes to the source and should be helpful to determine if your changes are lowering the `page load asset size` enough.
+
+If you only want to run the build once you can run:
 
 [source,shell]
 -----------
-node scripts/build_kibana_platform_plugins --validate-limits
+node scripts/build_kibana_platform_plugins --validate-limits --focus {pluginId}
 -----------
 
 This command needs to apply production optimizations to get the right sizes, which means that the optimizer will take significantly longer to run and on most developmer machines will consume all of your machines resources for 20 minutes or more. If you'd like to multi-task while this is running you might need to limit the number of workers using the `--max-workers` flag.

docs/user/alerting/alert-types.asciidoc

@@ -130,12 +130,13 @@ image::images/alert-types-es-query-select.png[Choosing an ES query alert type]
 [float]
 ==== Defining the conditions
 
-The ES query alert has 4 clauses that define the condition to detect.
+The ES query alert has 5 clauses that define the condition to detect.
 
 [role="screenshot"]
 image::images/alert-types-es-query-conditions.png[Four clauses define the condition to detect]
 
 Index:: This clause requires an *index or index pattern* and a *time field* that will be used for the *time window*.
+Size:: This clause specifies the number of documents to pass to the configured actions when the the threshold condition is met.
 ES query:: This clause specifies the ES DSL query to execute. The number of documents that match this query will be evaulated against the threshold
 condition. Aggregations are not supported at this time. 
 Threshold:: This clause defines a threshold value and a comparison operator  (`is above`, `is above or equals`, `is below`, `is below or equals`, or `is between`). The number of documents that match the specified query is compared to this threshold.

docs/user/dashboard/vega-reference.asciidoc

@@ -251,17 +251,22 @@ experimental[] To enable *Maps*, the graph must specify `type=map` in the host c
       "longitude": -74,   // default 0
       "zoom": 7,          // default 2
 
-      // defaults to "default". Use false to disable base layer.
+      // Defaults to 'true', disables the base map layer.
       "mapStyle": false,
 
+      // When 'mapStyle' is 'undefined' or 'true', sets the EMS-layer for the map.
+      // May either be: "road_map", "road_map_desaturated", "dark_map".
+      // If 'emsTileServiceId' is 'undefined', it falls back to the auto-switch-dark-light behavior.
+      "emsTileServiceId": "road_map",
+
       // default 0
       "minZoom": 5,
 
       // defaults to the maximum for the given style,
       // or 25 when base is disabled
       "maxZoom": 13,
 
-      // defaults to true, shows +/- buttons to zoom in/out
+      // Defaults to 'true', shows +/- buttons to zoom in/out
       "zoomControl": false,
 
       // Defaults to 'false', disables mouse wheel zoom. If set to

jest.config.integration.js

@@ -17,12 +17,15 @@ module.exports = {
   testPathIgnorePatterns: preset.testPathIgnorePatterns.filter(
     (pattern) => !pattern.includes('integration_tests')
   ),
+  setupFilesAfterEnv: ['<rootDir>/packages/kbn-test/target/jest/setup/after_env.integration.js'],
   reporters: [
     'default',
     [
       '<rootDir>/packages/kbn-test/target/jest/junit_reporter',
       { reportName: 'Jest Integration Tests' },
     ],
   ],
-  setupFilesAfterEnv: ['<rootDir>/packages/kbn-test/target/jest/setup/after_env.integration.js'],
+  coverageReporters: !!process.env.CI
+    ? [['json', { file: 'jest-integration.json' }]]
+    : ['html', 'text'],
 };

jest.config.js

@@ -7,6 +7,14 @@
  */
 
 module.exports = {
+  preset: '@kbn/test',
   rootDir: '.',
-  projects: [...require('./jest.config.oss').projects, ...require('./x-pack/jest.config').projects],
+  projects: [
+    '<rootDir>/packages/*/jest.config.js',
+    '<rootDir>/src/*/jest.config.js',
+    '<rootDir>/src/legacy/*/jest.config.js',
+    '<rootDir>/src/plugins/*/jest.config.js',
+    '<rootDir>/test/*/jest.config.js',
+    '<rootDir>/x-pack/plugins/*/jest.config.js',
+  ],
 };

packages/kbn-dev-utils/src/ci_stats_reporter/ci_stats_reporter.ts

@@ -109,7 +109,7 @@ export class CiStatsReporter {
           },
         });
 
-        return;
+        return true;
       } catch (error) {
         if (!error?.request) {
           // not an axios error, must be a usage error that we should notify user about

packages/kbn-dev-utils/src/ci_stats_reporter/ship_ci_stats_cli.ts

@@ -10,7 +10,7 @@ import Path from 'path';
 import Fs from 'fs';
 
 import { CiStatsReporter } from './ci_stats_reporter';
-import { run, createFlagError } from '../run';
+import { run, createFlagError, createFailError } from '../run';
 
 export function shipCiStatsCli() {
   run(
@@ -23,12 +23,20 @@ export function shipCiStatsCli() {
       }
 
       const reporter = CiStatsReporter.fromEnv(log);
+
+      if (!reporter.isEnabled()) {
+        throw createFailError('unable to initilize the CI Stats reporter');
+      }
+
       for (const path of metricPaths) {
         // resolve path from CLI relative to CWD
         const abs = Path.resolve(path);
         const json = Fs.readFileSync(abs, 'utf8');
-        await reporter.metrics(JSON.parse(json));
-        log.success('shipped metrics from', path);
+        if (await reporter.metrics(JSON.parse(json))) {
+          log.success('shipped metrics from', path);
+        } else {
+          throw createFailError('failed to ship metrics');
+        }
       }
     },
     {

packages/kbn-monaco/src/monaco_imports.ts

@@ -17,7 +17,7 @@ import 'monaco-editor/esm/vs/editor/browser/controller/coreCommands.js';
 import 'monaco-editor/esm/vs/editor/browser/widget/codeEditorWidget.js';
 
 import 'monaco-editor/esm/vs/editor/contrib/wordOperations/wordOperations.js'; // Needed for word-wise char navigation
-
+import 'monaco-editor/esm/vs/editor/contrib/folding/folding.js'; // Needed for folding
 import 'monaco-editor/esm/vs/editor/contrib/suggest/suggestController.js'; // Needed for suggestions
 import 'monaco-editor/esm/vs/editor/contrib/hover/hover.js'; // Needed for hover
 import 'monaco-editor/esm/vs/editor/contrib/parameterHints/parameterHints.js'; // Needed for signature

packages/kbn-std/src/promise.test.ts

@@ -12,40 +12,36 @@ const delay = (ms: number, resolveValue?: any) =>
   new Promise((resolve) => setTimeout(resolve, ms, resolveValue));
 
 describe('withTimeout', () => {
-  it('resolves with a promise value if resolved in given timeout', async () => {
+  it('resolves with a promise value and "timedout: false" if resolved in given timeout', async () => {
     await expect(
       withTimeout({
         promise: delay(10, 'value'),
-        timeout: 200,
-        errorMessage: 'error-message',
+        timeoutMs: 200,
       })
-    ).resolves.toBe('value');
+    ).resolves.toStrictEqual({ value: 'value', timedout: false });
   });
 
-  it('rejects with errorMessage if not resolved in given time', async () => {
+  it('resolves with "timedout: false" if not resolved in given time', async () => {
     await expect(
       withTimeout({
         promise: delay(200, 'value'),
-        timeout: 10,
-        errorMessage: 'error-message',
+        timeoutMs: 10,
       })
-    ).rejects.toMatchInlineSnapshot(`[Error: error-message]`);
+    ).resolves.toStrictEqual({ timedout: true });
 
     await expect(
       withTimeout({
         promise: new Promise((i) => i),
-        timeout: 10,
-        errorMessage: 'error-message',
+        timeoutMs: 10,
       })
-    ).rejects.toMatchInlineSnapshot(`[Error: error-message]`);
+    ).resolves.toStrictEqual({ timedout: true });
   });
 
   it('does not swallow promise error', async () => {
     await expect(
       withTimeout({
         promise: Promise.reject(new Error('from-promise')),
-        timeout: 10,
-        errorMessage: 'error-message',
+        timeoutMs: 10,
       })
     ).rejects.toMatchInlineSnapshot(`[Error: from-promise]`);
   });

packages/kbn-std/src/promise.ts

@@ -6,19 +6,26 @@
  * Side Public License, v 1.
  */
 
-export function withTimeout<T>({
+export async function withTimeout<T>({
   promise,
-  timeout,
-  errorMessage,
+  timeoutMs,
 }: {
   promise: Promise<T>;
-  timeout: number;
-  errorMessage: string;
-}) {
-  return Promise.race([
-    promise,
-    new Promise((resolve, reject) => setTimeout(() => reject(new Error(errorMessage)), timeout)),
-  ]) as Promise<T>;
+  timeoutMs: number;
+}): Promise<{ timedout: true } | { timedout: false; value: T }> {
+  let timeout: NodeJS.Timeout | undefined;
+  try {
+    return (await Promise.race([
+      promise.then((v) => ({ value: v, timedout: false })),
+      new Promise((resolve) => {
+        timeout = setTimeout(() => resolve({ timedout: true }), timeoutMs);
+      }),
+    ])) as Promise<{ timedout: true } | { timedout: false; value: T }>;
+  } finally {
+    if (timeout !== undefined) {
+      clearTimeout(timeout);
+    }
+  }
 }
 
 export function isPromise<T>(maybePromise: T | Promise<T>): maybePromise is Promise<T> {

packages/kbn-test/jest-preset.js

@@ -19,7 +19,9 @@ module.exports = {
   coveragePathIgnorePatterns: ['/node_modules/', '.*\\.d\\.ts'],
 
   // A list of reporter names that Jest uses when writing coverage reports
-  coverageReporters: !!process.env.CODE_COVERAGE ? ['json'] : ['html', 'text'],
+  coverageReporters: !!process.env.CODE_COVERAGE
+    ? [['json', { file: 'jest.json' }]]
+    : ['html', 'text'],
 
   // An array of file extensions your modules use
   moduleFileExtensions: ['js', 'mjs', 'json', 'ts', 'tsx', 'node'],

packages/kbn-test/src/functional_test_runner/lib/config/schema.ts

@@ -169,7 +169,7 @@ export const schema = Joi.object()
 
     esTestCluster: Joi.object()
       .keys({
-        license: Joi.string().default('oss'),
+        license: Joi.string().default('basic'),
         from: Joi.string().default('snapshot'),
         serverArgs: Joi.array(),
         serverEnvVars: Joi.object(),

packages/kbn-test/src/legacy_es/legacy_es_test_cluster.js

@@ -22,7 +22,7 @@ export function createLegacyEsTestCluster(options = {}) {
   const {
     port = esTestConfig.getPort(),
     password = 'changeme',
-    license = 'oss',
+    license = 'basic',
     log,
     basePath = resolve(KIBANA_ROOT, '.es'),
     esFrom = esTestConfig.getBuildFrom(),

packages/kbn-tinymath/package.json

@@ -4,6 +4,7 @@
   "license": "SSPL-1.0 OR Elastic License 2.0",
   "private": true,
   "main": "src/index.js",
+  "types": "tinymath.d.ts",
   "scripts": {
     "kbn:bootstrap": "yarn build",
     "build": "../../node_modules/.bin/pegjs -o src/grammar.js src/grammar.pegjs"