-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* convert eslint scripts into TS * update settings for BWC * add script updating styles to pretter v2 * use default prettier config * run npx once, point to the correct head branch, do not add to git * throw if run script not on a clear branch * run in a batch, add logging
- Loading branch information
Showing
5 changed files
with
116 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
require('../src/setup_node_env/babel_register'); | ||
require('../src/dev/run_prettier_on_changed'); |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import execa from 'execa'; | ||
// @ts-ignore | ||
import SimpleGit from 'simple-git'; | ||
import { run } from '@kbn/dev-utils'; | ||
import dedent from 'dedent'; | ||
import Util from 'util'; | ||
|
||
import pkg from '../../package.json'; | ||
import { REPO_ROOT } from './constants'; | ||
import { File } from './file'; | ||
import * as Eslint from './eslint'; | ||
|
||
run(async function getChangedFiles({ log }) { | ||
const simpleGit = new SimpleGit(REPO_ROOT); | ||
|
||
const getStatus = Util.promisify(simpleGit.status.bind(simpleGit)); | ||
const gitStatus = await getStatus(); | ||
|
||
if (gitStatus.files.length > 0) { | ||
throw new Error( | ||
dedent(`You should run prettier formatter on a clean branch. | ||
Found not committed changes to: | ||
${gitStatus.files.map((f: { path: string }) => f.path).join('\n')}`) | ||
); | ||
} | ||
|
||
const revParse = Util.promisify(simpleGit.revparse.bind(simpleGit)); | ||
const currentBranch = await revParse(['--abbrev-ref', 'HEAD']); | ||
const headBranch = pkg.branch; | ||
|
||
const diff = Util.promisify(simpleGit.diff.bind(simpleGit)); | ||
|
||
const changedFileStatuses: string = await diff([ | ||
'--name-status', | ||
`${headBranch}...${currentBranch}`, | ||
]); | ||
|
||
const changedFiles = changedFileStatuses | ||
.split('\n') | ||
// Ignore blank lines | ||
.filter(line => line.trim().length > 0) | ||
// git diff --name-status outputs lines with two OR three parts | ||
// separated by a tab character | ||
.map(line => line.trim().split('\t')) | ||
.map(([status, ...paths]) => { | ||
// ignore deleted files | ||
if (status === 'D') { | ||
return undefined; | ||
} | ||
|
||
// the status is always in the first column | ||
// .. If the file is edited the line will only have two columns | ||
// .. If the file is renamed it will have three columns | ||
// .. In any case, the last column is the CURRENT path to the file | ||
return new File(paths[paths.length - 1]); | ||
}) | ||
.filter((file): file is File => Boolean(file)); | ||
|
||
const pathsToLint = Eslint.pickFilesToLint(log, changedFiles).map(f => f.getAbsolutePath()); | ||
|
||
if (pathsToLint.length > 0) { | ||
log.debug('[prettier] run on %j files: ', pathsToLint.length, pathsToLint); | ||
} | ||
|
||
while (pathsToLint.length > 0) { | ||
await execa('npx', ['[email protected]', '--write', ...pathsToLint.splice(0, 100)]); | ||
} | ||
}); |