[ML] Replace failed transaction tab

elastic · Aug 17, 2021 · caf5c29 · caf5c29
1 parent fb6bb05
commit caf5c29
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/x-pack/plugins/apm/public/components/app/correlations/failed_transactions_correlations.tsx b/x-pack/plugins/apm/public/components/app/correlations/failed_transactions_correlations.tsx
@@ -44,11 +44,7 @@ import { useFailedTransactionsCorrelationsFetcher } from '../../../hooks/use_fai
 import { SearchServiceParams } from '../../../../common/search_strategies/correlations/types';
 import { useApmParams } from '../../../hooks/use_apm_params';
 
-interface Props {
-  onClose: () => void;
-}
-
-export function FailedTransactionsCorrelations({ onClose }: Props) {
+export function FailedTransactionsCorrelations() {
   const {
     core: { notifications, uiSettings },
   } = useApmPluginContext();
@@ -114,7 +110,6 @@ export function FailedTransactionsCorrelations({ onClose }: Props) {
   }, [selectedSignificantTerm, result]);
 
   const history = useHistory();
-  const handleOnFilter = onClose;
 
   const failedTransactionsCorrelationsColumns: Array<
     EuiBasicTableColumn<FailedTransactionsCorrelationValue>
@@ -193,7 +188,6 @@ export function FailedTransactionsCorrelations({ onClose }: Props) {
                   )}"`,
                 },
               });
-              handleOnFilter();
               trackApmEvent({ metric: 'correlations_term_include_filter' });
             },
           },
@@ -216,7 +210,6 @@ export function FailedTransactionsCorrelations({ onClose }: Props) {
                   )}"`,
                 },
               });
-              handleOnFilter();
               trackApmEvent({ metric: 'correlations_term_exclude_filter' });
             },
           },
@@ -256,7 +249,7 @@ export function FailedTransactionsCorrelations({ onClose }: Props) {
         },
       },
     ],
-    [handleOnFilter, history, trackApmEvent]
+    [history, trackApmEvent]
   );
 
   useEffect(() => {
@@ -348,7 +341,6 @@ export function FailedTransactionsCorrelations({ onClose }: Props) {
         status={FETCH_STATUS.SUCCESS}
         setSelectedSignificantTerm={setSelectedSignificantTerm}
         selectedTerm={selectedTerm}
-        onFilter={onClose}
       />
 
       {ccsWarning && (

diff --git a/...ns/apm/public/components/app/transaction_details/failed_transactions_correlations_tab.tsx b/...ns/apm/public/components/app/transaction_details/failed_transactions_correlations_tab.tsx
@@ -22,7 +22,7 @@ import { useLicenseContext } from '../../../context/license/use_license_context'
 
 import { LicensePrompt } from '../../shared/license_prompt';
 
-import { ErrorCorrelations } from '../correlations/error_correlations';
+import { FailedTransactionsCorrelations } from '../correlations/failed_transactions_correlations';
 
 import type { TabContentProps } from './types';
 
@@ -42,7 +42,7 @@ function FailedTransactionsCorrelationsTab({}: TabContentProps) {
   useTrackMetric({ ...metric, delay: 15000 });
 
   return hasActivePlatinumLicense ? (
-    <ErrorCorrelations />
+    <FailedTransactionsCorrelations />
   ) : (
     <LicensePrompt
       text={i18n.translate(