update type guard to use correct key

elastic · Jun 28, 2024 · caddc90 · caddc90
1 parent 7b2c26f
commit caddc90
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/core/security/core-security-server/src/authentication/api_keys/api_keys.ts b/packages/core/security/core-security-server/src/authentication/api_keys/api_keys.ts
@@ -264,5 +264,5 @@ export interface UpdateRestAPIKeyWithKibanaPrivilegesParams {
 }
 
 export function isCreateRestAPIKeyParams(params: any): params is CreateRestAPIKeyParams {
-  return 'role_descriptor' in params;
+  return 'role_descriptors' in params;
 }
diff --git a/x-pack/plugins/security/server/authentication/api_keys/api_keys.test.ts b/x-pack/plugins/security/server/authentication/api_keys/api_keys.test.ts
@@ -243,6 +243,7 @@ describe('API Keys', () => {
         role_descriptors: roleDescriptors,
         expiration: '1d',
       });
+
       expect(result).toEqual({
         api_key: 'abc123',
         expiration: '1d',
@@ -254,7 +255,7 @@ describe('API Keys', () => {
       expect(mockScopedClusterClient.asCurrentUser.security.createApiKey).toHaveBeenCalledWith({
         body: {
           name: 'key-name',
-          role_descriptors: { foo: true },
+          role_descriptors: roleDescriptors,
           expiration: '1d',
         },
       });