PR feedback

elastic · Jul 5, 2023 · c719484 · c719484
1 parent f87deb5
commit c719484
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 3 deletions.
diff --git a/x-pack/plugins/cases/common/api/cases/comment/index.test.ts b/x-pack/plugins/cases/common/api/cases/comment/index.test.ts
@@ -29,6 +29,7 @@ import {
   BulkGetAttachmentsRequestRt,
   BulkGetAttachmentsResponseRt,
 } from '.';
+import { MAX_COMMENT_LENGTH } from '../../../constants';
 
 describe('Comments', () => {
   describe('CommentAttributesBasicRt', () => {
@@ -340,6 +341,23 @@ describe('Comments', () => {
         right: defaultRequest,
       });
     });
+
+    it.skip('throws error when comment is too long', () => {
+      const longComment = 'x'.repeat(MAX_COMMENT_LENGTH + 1);
+
+      expect(CommentRequestRt.decode({ ...defaultRequest, comment: longComment })).toMatchObject({
+        _tag: 'Left',
+        left: [{
+          context:[{
+          actual: {
+              ...defaultRequest,
+              comment: longComment,
+              message: "The length of the comment is too long. The maximum length is 30000."
+            }
+          }]
+        }]
+      });
+    });
   });
 
   describe('CommentRt', () => {

diff --git a/x-pack/plugins/cases/server/client/attachments/add.test.ts b/x-pack/plugins/cases/server/client/attachments/add.test.ts
@@ -25,9 +25,7 @@ describe('addComment', () => {
   });
 
   it('should throw an error if the comment length is too long', async () => {
-    const longComment = Array(MAX_COMMENT_LENGTH + 1)
-      .fill('x')
-      .toString();
+    const longComment = 'x'.repeat(MAX_COMMENT_LENGTH + 1);
 
     await expect(
       addComment({ comment: { ...comment, comment: longComment }, caseId: 'test-case' }, clientArgs)

diff --git a/...ases_api_integration/security_and_spaces/tests/common/internal/bulk_create_attachments.ts b/...ases_api_integration/security_and_spaces/tests/common/internal/bulk_create_attachments.ts
@@ -441,6 +441,23 @@ export default ({ getService }: FtrProviderContext): void => {
         });
       });
 
+      it('400s when comment is too long', async () => {
+        const longComment = 'x'.repeat(30001);
+
+        await bulkCreateAttachments({
+          supertest,
+          caseId: 'case-id',
+          params: [
+            {
+              type: CommentType.user,
+              comment: longComment,
+              owner: 'securitySolutionFixture',
+            },
+          ],
+          expectedHttpCode: 400,
+        });
+      });
+
       it('400s when adding excess attributes for type user', async () => {
         const postedCase = await createCase(supertest, postCaseReq);