Fixing assumption that groupBy is always an array

elastic · Apr 19, 2023 · c0fe697 · c0fe697
1 parent b7bcf32
commit c0fe697
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...erting/log_threshold/components/alert_details_app_section/components/logs_ratio_chart.tsx b/...erting/log_threshold/components/alert_details_app_section/components/logs_ratio_chart.tsx
@@ -131,6 +131,7 @@ const LogsRatioChart: React.FC<ChartProps> = ({
   const barSeries = useMemo(() => {
     return series.flatMap(({ points, id }) => points.map((point) => ({ ...point, groupBy: id })));
   }, [series]);
+
   if (isLoading) {
     return <LoadingState />;
   } else if (hasError) {

diff --git a/...blic/alerting/log_threshold/components/expression_editor/hooks/use_chart_preview_data.tsx b/...blic/alerting/log_threshold/components/expression_editor/hooks/use_chart_preview_data.tsx
@@ -68,7 +68,7 @@ export const useChartPreviewData = ({
           let seriesQueryB = ratio[1].data.series[0].points;
           let seriesId = 'ratio';
           // When groupBy and a filter is applied, return the ratio only for the filtered grouped-by
-          if (ruleParams.groupBy.length && filterSeriesByGroupName) {
+          if (ruleParams.groupBy?.length && filterSeriesByGroupName) {
             seriesId = filterSeriesByGroupName;
             seriesQueryA =
               ratio[0].data.series.find((series) => series.id === filterSeriesByGroupName)