add some tests

elastic · Oct 14, 2020 · bff6f16 · bff6f16
1 parent 10a1f68
commit bff6f16
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 0 deletions.
diff --git a/src/plugins/data/common/search/aggs/buckets/terms.test.ts b/src/plugins/data/common/search/aggs/buckets/terms.test.ts
@@ -18,6 +18,7 @@
  */
 
 import { AggConfigs } from '../agg_configs';
+import { METRIC_TYPES } from '../metrics';
 import { mockAggTypesRegistry } from '../test_helpers';
 import { BUCKET_TYPES } from './bucket_agg_types';
 
@@ -133,5 +134,49 @@ describe('Terms Agg', () => {
       expect(params.include).toStrictEqual([1.1, 2, 3.33]);
       expect(params.exclude).toStrictEqual([4, 5.555, 6]);
     });
+
+    test('uses correct bucket path for sorting by median', () => {
+      const indexPattern = {
+        id: '1234',
+        title: 'logstash-*',
+        fields: {
+          getByName: () => field,
+          filter: () => [field],
+        },
+      } as any;
+
+      const field = {
+        name: 'field',
+        indexPattern,
+      };
+
+      const aggConfigs = new AggConfigs(
+        indexPattern,
+        [
+          {
+            id: 'test',
+            params: {
+              field: {
+                name: 'string_field',
+                type: 'string',
+              },
+              orderAgg: {
+                type: METRIC_TYPES.MEDIAN,
+                params: {
+                  field: {
+                    name: 'number_field',
+                    type: 'number',
+                  },
+                },
+              },
+            },
+            type: BUCKET_TYPES.TERMS,
+          },
+        ],
+        { typesRegistry: mockAggTypesRegistry() }
+      );
+      const { [BUCKET_TYPES.TERMS]: params } = aggConfigs.aggs[0].toDsl();
+      expect(params.order).toEqual({ 'test-orderAgg.50': 'desc' });
+    });
   });
 });
diff --git a/src/plugins/data/common/search/aggs/metrics/median.test.ts b/src/plugins/data/common/search/aggs/metrics/median.test.ts
@@ -63,6 +63,12 @@ describe('AggTypeMetricMedianProvider class', () => {
     expect(dsl.median.percentiles.percents).toEqual([50]);
   });
 
+  it('points to right value within multi metric for value bucket path', () => {
+    expect(aggConfigs.byId(METRIC_TYPES.MEDIAN)!.getValueBucketPath()).toEqual(
+      `${METRIC_TYPES.MEDIAN}.50`
+    );
+  });
+
   it('converts the response', () => {
     const agg = aggConfigs.getResponseAggs()[0];