revert unrelated changes

elastic · Apr 9, 2020 · bfaa3dd · bfaa3dd
1 parent 1f8e959
commit bfaa3dd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/args.ts b/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/args.ts
@@ -10,7 +10,7 @@ type ViewportConfig = CaptureConfig['viewport'];
 type BrowserConfig = CaptureConfig['browser']['chromium'];
 
 interface LaunchArgs {
-  userDataDir: string;
+  userDataDir: BrowserConfig['userDataDir'];
   viewport: ViewportConfig;
   disableSandbox: BrowserConfig['disableSandbox'];
   proxy: BrowserConfig['proxy'];

diff --git a/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts b/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
@@ -56,29 +56,27 @@ export class HeadlessChromiumDriverFactory {
 
   type = BROWSER_TYPE;
 
-  async test(logger: Logger) {
+  test(logger: Logger) {
     const chromiumArgs = args({
       userDataDir: this.userDataDir,
       viewport: { width: 800, height: 600 },
       disableSandbox: this.browserConfig.disableSandbox,
       proxy: this.browserConfig.proxy,
     });
 
-    try {
-      return await puppeteerLaunch({
-        userDataDir: this.userDataDir,
-        executablePath: this.binaryPath,
-        ignoreHTTPSErrors: true,
-        args: chromiumArgs,
-      } as LaunchOptions);
-    } catch (error) {
+    return puppeteerLaunch({
+      userDataDir: this.userDataDir,
+      executablePath: this.binaryPath,
+      ignoreHTTPSErrors: true,
+      args: chromiumArgs,
+    } as LaunchOptions).catch((error: Error) => {
       logger.error(
         `The Reporting plugin encountered issues launching Chromium in a self-test. You may have trouble generating reports.`
       );
       logger.error(error);
       logger.warning(`See Chromium's log output at "${getChromeLogLocation(this.binaryPath)}"`);
       return null;
-    }
+    });
   }
 
   /*