[TSVB] use boolean instead of number

elastic · May 5, 2021 · beff6ed · beff6ed
1 parent 1c72466
commit beff6ed
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/.../vis_type_timeseries/public/application/components/lib/create_interval_based_formatter.ts b/.../vis_type_timeseries/public/application/components/lib/create_interval_based_formatter.ts
@@ -26,7 +26,7 @@ export function createIntervalBasedFormatter(
   ignoreDaylightTime: boolean
 ) {
   const fixedOffset = moment(JANUARY_MOMENT_CONFIG).utcOffset();
-  return (val: moment.MomentInput): string => {
+  return (val: moment.MomentInput) => {
     const momentVal = moment(val);
     if (ignoreDaylightTime) {
       momentVal.utcOffset(fixedOffset);

diff --git a/src/plugins/vis_type_timeseries/public/application/components/panel_config/timeseries.tsx b/src/plugins/vis_type_timeseries/public/application/components/panel_config/timeseries.tsx
@@ -127,7 +127,7 @@ export class TimeseriesPanelConfig extends Component<
       legend_position: 'right',
       show_grid: 1,
       tooltip_mode: 'show_all',
-      ignore_daylight_time: 0,
+      ignore_daylight_time: false,
     };
     const model = { ...defaults, ...this.props.model };
     const { selectedTab } = this.state;

diff --git a/src/plugins/vis_type_timeseries/public/application/components/timeseries_visualization.tsx b/src/plugins/vis_type_timeseries/public/application/components/timeseries_visualization.tsx
@@ -143,7 +143,7 @@ function TimeseriesVisualization({
                 `${isVisSeriesData(visData) ? model.id : 'series[0]'}.series[0].data`,
                 undefined
               )}
-              ignoreDaylightTime={Boolean(model.ignore_daylight_time)}
+              ignoreDaylightTime={model.ignore_daylight_time}
               panelInterval={getInterval(visData, model)}
               modelInterval={model.interval ?? AUTO_INTERVAL}
             />

diff --git a/src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js b/src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js
@@ -38,11 +38,9 @@ class TimeseriesVisualization extends Component {
       interval,
       this.scaledDataFormat,
       this.dateFormat,
-      Boolean(this.props.model.ignore_daylight_time)
+      this.props.model.ignore_daylight_time
     );
-    return (val) => {
-      return formatter(val);
-    };
+    return (val) => formatter(val);
   };
 
   yAxisStackedByPercentFormatter = (val) => {