Apply suggestions from code review

Co-authored-by: Constance <[email protected]>
elastic · Nov 4, 2020 · be76a85 · be76a85
1 parent 701951d
commit be76a85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...lic/applications/app_search/components/settings/log_retention/log_retention_logic.test.ts b/...lic/applications/app_search/components/settings/log_retention/log_retention_logic.test.ts
@@ -217,7 +217,7 @@ describe('LogRetentionLogic', () => {
 
         LogRetentionLogic.actions.saveLogRetention(ELogRetentionOptions.Analytics, true);
 
-        expect(http.put).toHaveBeenCalledWith(`/api/app_search/log_settings`, {
+        expect(http.put).toHaveBeenCalledWith('/api/app_search/log_settings', {
           body: JSON.stringify({
             analytics: {
               enabled: true,
@@ -341,7 +341,7 @@ describe('LogRetentionLogic', () => {
 
       LogRetentionLogic.actions.fetchLogRetention();
 
-      expect(http.get).toHaveBeenCalledWith(`/api/app_search/log_settings`);
+      expect(http.get).toHaveBeenCalledWith('/api/app_search/log_settings');
       await promise;
       expect(LogRetentionLogic.actions.updateLogRetention).toHaveBeenCalledWith(
         TYPICAL_CLIENT_LOG_RETENTION

diff --git a/...h/public/applications/app_search/components/settings/log_retention/log_retention_logic.ts b/...h/public/applications/app_search/components/settings/log_retention/log_retention_logic.ts
@@ -109,7 +109,7 @@ export const LogRetentionLogic = kea<MakeLogicType<ILogRetentionValues, ILogRete
       }
     },
     toggleLogRetention: ({ option }) => {
-      const logRetention = values.logRetention && values.logRetention[option];
+      const logRetention = values.logRetention?.[option];
 
       // If the user has found a way to call this before we've retrieved
       // log retention settings from the server, short circuit this and return early