Fix autocomplete suggestions for lowercase methods and other related …

…bug (#121033) * Fix autocomplete suggestions for lowercase methods and another related bug Co-authored-by: Muhammad Ibragimov <[email protected]>
elastic · Dec 14, 2021 · bd01469 · bd01469
1 parent 7176dd5
commit bd01469
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/plugins/console/public/lib/autocomplete/autocomplete.ts b/src/plugins/console/public/lib/autocomplete/autocomplete.ts
@@ -802,7 +802,7 @@ export default function ({
 
   function addPathAutoCompleteSetToContext(context: AutoCompleteContext, pos: Position) {
     const ret = getCurrentMethodAndTokenPaths(editor, pos, parser);
-    context.method = ret.method;
+    context.method = ret.method?.toUpperCase();
     context.token = ret.token;
     context.otherTokenValues = ret.otherTokenValues;
     context.urlTokenPath = ret.urlTokenPath;
@@ -929,9 +929,12 @@ export default function ({
       return; // wait for the next typing.
     }
 
+    // if the column or the line number have not changed for the last token and
+    // user did not provided a new value, then we should not show autocomplete
+    // this guards against triggering autocomplete when clicking around the editor
     if (
-      lastEvaluatedToken.position.column !== currentToken.position.column ||
-      lastEvaluatedToken.position.lineNumber !== currentToken.position.lineNumber ||
+      (lastEvaluatedToken.position.column !== currentToken.position.column ||
+        lastEvaluatedToken.position.lineNumber !== currentToken.position.lineNumber) &&
       lastEvaluatedToken.value === currentToken.value
     ) {
       // not on the same place or nothing changed, cache and wait for the next time