Improved AlertsClient tests structure by splitting a huge alerts_clie…

…nt.tests.ts file into a specific files defined by its responsibility. (#80088) (#80348) fairly large refactor, but no functional changes Co-authored-by: Yuliia Naumenko <[email protected]>
elastic · Oct 13, 2020 · bc710a7 · bc710a7
1 parent ae740fa
commit bc710a7
Show file tree

Hide file tree

Showing 19 changed files with 5,275 additions and 4,585 deletions.
diff --git a/x-pack/plugins/alerts/server/alerts_client.test.ts b/x-pack/plugins/alerts/server/alerts_client.test.ts
diff --git a/...ck/plugins/alerts/server/alerts_client.ts → ...rts/server/alerts_client/alerts_client.ts b/...ck/plugins/alerts/server/alerts_client.ts → ...rts/server/alerts_client/alerts_client.ts
@@ -14,8 +14,8 @@ import {
   SavedObject,
   PluginInitializerContext,
 } from 'src/core/server';
-import { esKuery } from '../../../../src/plugins/data/server';
-import { ActionsClient, ActionsAuthorization } from '../../actions/server';
+import { esKuery } from '../../../../../src/plugins/data/server';
+import { ActionsClient, ActionsAuthorization } from '../../../actions/server';
 import {
   Alert,
   PartialAlert,
@@ -27,26 +27,26 @@ import {
   SanitizedAlert,
   AlertTaskState,
   AlertInstanceSummary,
-} from './types';
-import { validateAlertTypeParams, alertExecutionStatusFromRaw } from './lib';
+} from '../types';
+import { validateAlertTypeParams, alertExecutionStatusFromRaw } from '../lib';
 import {
   InvalidateAPIKeyParams,
   GrantAPIKeyResult as SecurityPluginGrantAPIKeyResult,
   InvalidateAPIKeyResult as SecurityPluginInvalidateAPIKeyResult,
-} from '../../security/server';
-import { EncryptedSavedObjectsClient } from '../../encrypted_saved_objects/server';
-import { TaskManagerStartContract } from '../../task_manager/server';
-import { taskInstanceToAlertTaskInstance } from './task_runner/alert_task_instance';
-import { deleteTaskIfItExists } from './lib/delete_task_if_it_exists';
-import { RegistryAlertType } from './alert_type_registry';
-import { AlertsAuthorization, WriteOperations, ReadOperations, and } from './authorization';
-import { IEventLogClient } from '../../../plugins/event_log/server';
-import { parseIsoOrRelativeDate } from './lib/iso_or_relative_date';
-import { alertInstanceSummaryFromEventLog } from './lib/alert_instance_summary_from_event_log';
-import { IEvent } from '../../event_log/server';
-import { parseDuration } from '../common/parse_duration';
-import { retryIfConflicts } from './lib/retry_if_conflicts';
-import { partiallyUpdateAlert } from './saved_objects';
+} from '../../../security/server';
+import { EncryptedSavedObjectsClient } from '../../../encrypted_saved_objects/server';
+import { TaskManagerStartContract } from '../../../task_manager/server';
+import { taskInstanceToAlertTaskInstance } from '../task_runner/alert_task_instance';
+import { deleteTaskIfItExists } from '../lib/delete_task_if_it_exists';
+import { RegistryAlertType } from '../alert_type_registry';
+import { AlertsAuthorization, WriteOperations, ReadOperations, and } from '../authorization';
+import { IEventLogClient } from '../../../../plugins/event_log/server';
+import { parseIsoOrRelativeDate } from '../lib/iso_or_relative_date';
+import { alertInstanceSummaryFromEventLog } from '../lib/alert_instance_summary_from_event_log';
+import { IEvent } from '../../../event_log/server';
+import { parseDuration } from '../../common/parse_duration';
+import { retryIfConflicts } from '../lib/retry_if_conflicts';
+import { partiallyUpdateAlert } from '../saved_objects';
 
 export interface RegistryAlertTypeWithAuth extends RegistryAlertType {
   authorizedConsumers: string[];

diff --git a/x-pack/plugins/alerts/server/alerts_client/index.ts b/x-pack/plugins/alerts/server/alerts_client/index.ts
@@ -0,0 +1,6 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+export * from './alerts_client';