Skip to content

Commit

Permalink
[Unified search] fixes removing a value for between operator input (#…
Browse files Browse the repository at this point in the history
…174363)

## Summary

1. Removing a value for between operator doesn't create a correct
filter. Steps to reproduce:
a. Create a between filter with some values in it.
b. Remove the values - instead of infinity values, they are stuck as
empty strings that cannot be processed correctly.
c. The filter causes a runtime error.


https://github.com/elastic/kibana/assets/4283304/98104514-bea9-4668-a01e-7c769bf7560d



2. I also widened the operators container as it doesn't fit all the copy
for the options.
<img width="205" alt="Screenshot 2024-01-05 at 15 47 31"
src="https://github.com/elastic/kibana/assets/4283304/fa8ee5f0-766f-46ed-922b-731a9d023209">


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
  • Loading branch information
mbondyra authored Jan 5, 2024
1 parent fe5e1fd commit b89c53b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ function RangeValueInputUI(props: Props) {
if (typeof value !== 'string' && typeof value !== 'number') {
throw new Error('Range params must be a string or number');
}
props.onChange({ from: value, to: get(props, 'value.to') });
props.onChange({ from: value === '' ? undefined : value, to: get(props, 'value.to') });
};

const onToChange = (value: string | number | boolean) => {
if (typeof value !== 'string' && typeof value !== 'number') {
throw new Error('Range params must be a string or number');
}
props.onChange({ from: get(props, 'value.from'), to: value });
props.onChange({ from: get(props, 'value.from'), to: value === '' ? undefined : value });
};

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export function OperatorInput<TParams = unknown>({
singleSelection={{ asPlainText: true }}
isClearable={false}
data-test-subj="filterOperatorList"
inputPopoverProps={{ panelMinWidth: 180 }}
/>
);
}

0 comments on commit b89c53b

Please sign in to comment.