Skip to content

Commit

Permalink
[ML] Address review feedback on help text and comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
peteharverson committed Dec 7, 2022
1 parent 0df33ad commit aecb00b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions x-pack/plugins/ml/common/util/anomaly_utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@ export function isMultiBucketAnomaly(anomaly: AnomalyRecordDoc): boolean {
return true;
}

// Basis of use of 1.7 comes from the backend calculation for
// the single- and multi-bucket impacts
// 1.7 = 5.0/lg(e)/ln(1000)
// with the computation of the logarithm basis changed from e to 10.
if (sb !== undefined && mb > sb) {
return (((mb - sb) * mb) / sb) * 1.7 >= 2;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const TimeSeriesExplorerHelpPopover = () => {
<p>
<FormattedMessage
id="xpack.ml.timeSeriesExplorer.popoverAnomalyExplanation"
defaultMessage="An anomaly score is calculated for each bucket time interval, with a value from 0 to 100. Anomalous events are highlighted in colors that indicate their severity. If an anomaly is depicted with a cross symbol instead of a dot, it has a moderate, significant or high multi-bucket impact. This extra analysis can catch anomalies even when they fall within the bounds of expected behavior."
defaultMessage="An anomaly score is calculated for each bucket time interval, with a value from 0 to 100. Anomalous events are highlighted in colors that indicate their severity. If an anomaly is depicted with a cross symbol instead of a dot, it has a moderate, significant, or high multi-bucket impact. This extra analysis can catch anomalies even when they fall within the bounds of expected behavior."
/>
</p>
<p>
Expand Down

0 comments on commit aecb00b

Please sign in to comment.