Removes redundant aria-labels where ui label is inherited. Removes un…

…necessary components.
elastic · Mar 27, 2023 · adafdf1 · adafdf1
1 parent 065c05a
commit adafdf1
Showing 1 changed file with 20 additions and 40 deletions.
diff --git a/...plugins/security/public/management/roles/edit_role/privileges/es/index_privilege_form.tsx b/...plugins/security/public/management/roles/edit_role/privileges/es/index_privilege_form.tsx
@@ -128,10 +128,6 @@ export class IndexPrivilegeForm extends Component<Props, State> {
               {...this.props.validator.validateIndexPrivilege(this.props.indexPrivilege)}
             >
               <EuiComboBox
-                aria-label={i18n.translate(
-                  'xpack.security.management.editRole.indexPrivilegeForm.indicesAriaLabel',
-                  { defaultMessage: 'Indices' }
-                )}
                 data-test-subj={`indicesInput${this.props.formIndex}`}
                 options={this.props.indexPatterns.map(toOption)}
                 selectedOptions={this.props.indexPrivilege.names.map(toOption)}
@@ -152,10 +148,6 @@ export class IndexPrivilegeForm extends Component<Props, State> {
               fullWidth={true}
             >
               <EuiComboBox
-                aria-label={i18n.translate(
-                  'xpack.security.management.editRole.indexPrivilegeForm.privilegesAriaLabel',
-                  { defaultMessage: 'Index privileges' }
-                )}
                 data-test-subj={`privilegesInput${this.props.formIndex}`}
                 options={this.props.availableIndexPrivileges.map(toOption)}
                 selectedOptions={this.props.indexPrivilege.privileges.map(toOption)}
@@ -249,22 +241,16 @@ export class IndexPrivilegeForm extends Component<Props, State> {
                       ) : undefined
                     }
                   >
-                    <Fragment>
-                      <EuiComboBox
-                        aria-label={i18n.translate(
-                          'xpack.security.management.editRole.indexPrivilegeForm.grantedFieldsAriaLabel',
-                          { defaultMessage: 'Granted fields' }
-                        )}
-                        data-test-subj={`fieldInput${this.props.formIndex}`}
-                        options={this.state.flsOptions.map(toOption)}
-                        selectedOptions={grant.map(toOption)}
-                        onCreateOption={this.onCreateGrantedField}
-                        onChange={this.onGrantedFieldsChange}
-                        isDisabled={this.props.isRoleReadOnly}
-                        async={true}
-                        isLoading={this.state.isFieldListLoading}
-                      />
-                    </Fragment>
+                    <EuiComboBox
+                      data-test-subj={`fieldInput${this.props.formIndex}`}
+                      options={this.state.flsOptions.map(toOption)}
+                      selectedOptions={grant.map(toOption)}
+                      onCreateOption={this.onCreateGrantedField}
+                      onChange={this.onGrantedFieldsChange}
+                      isDisabled={this.props.isRoleReadOnly}
+                      async={true}
+                      isLoading={this.state.isFieldListLoading}
+                    />
                   </EuiFormRow>
                 </EuiFlexItem>
                 <EuiFlexItem>
@@ -278,22 +264,16 @@ export class IndexPrivilegeForm extends Component<Props, State> {
                     fullWidth={true}
                     className="indexPrivilegeForm__deniedFieldsRow"
                   >
-                    <Fragment>
-                      <EuiComboBox
-                        aria-label={i18n.translate(
-                          'xpack.security.management.editRole.indexPrivilegeForm.deniedFieldsAriaLabel',
-                          { defaultMessage: 'Denied fields' }
-                        )}
-                        data-test-subj={`deniedFieldInput${this.props.formIndex}`}
-                        options={this.state.flsOptions.map(toOption)}
-                        selectedOptions={except.map(toOption)}
-                        onCreateOption={this.onCreateDeniedField}
-                        onChange={this.onDeniedFieldsChange}
-                        isDisabled={isRoleReadOnly}
-                        async={true}
-                        isLoading={this.state.isFieldListLoading}
-                      />
-                    </Fragment>
+                    <EuiComboBox
+                      data-test-subj={`deniedFieldInput${this.props.formIndex}`}
+                      options={this.state.flsOptions.map(toOption)}
+                      selectedOptions={except.map(toOption)}
+                      onCreateOption={this.onCreateDeniedField}
+                      onChange={this.onDeniedFieldsChange}
+                      isDisabled={isRoleReadOnly}
+                      async={true}
+                      isLoading={this.state.isFieldListLoading}
+                    />
                   </EuiFormRow>
                 </EuiFlexItem>
               </EuiFlexGroup>