Skip to content

Commit

Permalink
[8.11] [Enterprise Search]Render native connector docs conditionally (#…
Browse files Browse the repository at this point in the history
…169121) (#169153)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Enterprise Search]Render native connector docs conditionally
(#169121)](#169121)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-17T17:14:45Z","message":"[Enterprise
Search]Render native connector docs conditionally (#169121)\n\n##
Summary\r\n\r\n<img width=\"772\" alt=\"Screenshot 2023-10-17 at 16 36
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/f668ab82-485d-46a6-8598-c1c9973b6255\">\r\n\r\n##
Release Note\r\nExternal documentation links are rendered conditionally
now to avoid\r\nempty links.\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"93f5d4e3509e8ee572f3af8803a16ba71ae81620","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:EnterpriseSearch","v8.11.0","v8.12.0"],"number":169121,"url":"https://github.com/elastic/kibana/pull/169121","mergeCommit":{"message":"[Enterprise
Search]Render native connector docs conditionally (#169121)\n\n##
Summary\r\n\r\n<img width=\"772\" alt=\"Screenshot 2023-10-17 at 16 36
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/f668ab82-485d-46a6-8598-c1c9973b6255\">\r\n\r\n##
Release Note\r\nExternal documentation links are rendered conditionally
now to avoid\r\nempty links.\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"93f5d4e3509e8ee572f3af8803a16ba71ae81620"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169121","number":169121,"mergeCommit":{"message":"[Enterprise
Search]Render native connector docs conditionally (#169121)\n\n##
Summary\r\n\r\n<img width=\"772\" alt=\"Screenshot 2023-10-17 at 16 36
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/f668ab82-485d-46a6-8598-c1c9973b6255\">\r\n\r\n##
Release Note\r\nExternal documentation links are rendered conditionally
now to avoid\r\nempty links.\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"93f5d4e3509e8ee572f3af8803a16ba71ae81620"}}]}]
BACKPORT-->

Co-authored-by: Efe Gürkan YALAMAN <[email protected]>
  • Loading branch information
kibanamachine and efegurkan authored Oct 17, 2023
1 parent 96faa97 commit ac1eda1
Showing 1 changed file with 13 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,19 @@ export const ResearchConfiguration: React.FC<ResearchConfigurationProps> = ({
)}
</EuiLink>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiLink target="_blank" href={externalDocsUrl}>
{i18n.translate(
'xpack.enterpriseSearch.content.indices.configurationConnector.researchConfiguration.serviceDocumentationLinkLabel',
{
defaultMessage: '{name} documentation',
values: { name },
}
)}
</EuiLink>
</EuiFlexItem>
{externalDocsUrl && (
<EuiFlexItem grow={false}>
<EuiLink target="_blank" href={externalDocsUrl}>
{i18n.translate(
'xpack.enterpriseSearch.content.indices.configurationConnector.researchConfiguration.serviceDocumentationLinkLabel',
{
defaultMessage: '{name} documentation',
values: { name },
}
)}
</EuiLink>
</EuiFlexItem>
)}
</EuiFlexGroup>
</>
);
Expand Down

0 comments on commit ac1eda1

Please sign in to comment.