Merge remote-tracking branch 'upstream/master' into vega-version

# Conflicts:
#	packages/kbn-pm/dist/index.js

Jenkinsfile

@@ -4,8 +4,8 @@ library 'kibana-pipeline-library'
 kibanaLibrary.load()
 
 kibanaPipeline(timeoutMinutes: 155, checkPrChanges: true) {
-  ciStats.trackBuild {
-    githubPr.withDefaultPrComments {
+  githubPr.withDefaultPrComments {
+    ciStats.trackBuild {
       catchError {
         retryable.enable()
         parallel([
@@ -53,10 +53,10 @@ kibanaPipeline(timeoutMinutes: 155, checkPrChanges: true) {
         ])
       }
     }
+  }
 
-    if (params.NOTIFY_ON_FAILURE) {
-      slackNotifications.onFailure()
-      kibanaPipeline.sendMail()
-    }
+  if (params.NOTIFY_ON_FAILURE) {
+    slackNotifications.onFailure()
+    kibanaPipeline.sendMail()
   }
 }

docs/api/saved-objects/create.asciidoc

@@ -13,7 +13,7 @@ experimental[] Create {kib} saved objects.
 
 `POST <kibana host>:<port>/api/saved_objects/<type>/<id>`
 
-`POST <kibana host>:<port>/s/<space_id>/saved_objects/<type>`
+`POST <kibana host>:<port>/s/<space_id>/api/saved_objects/<type>`
 
 [[saved-objects-api-create-path-params]]
 ==== Path parameters

docs/apm/machine-learning.asciidoc

@@ -1,6 +1,6 @@
 [role="xpack"]
 [[machine-learning-integration]]
-=== Machine Learning integration
+===  integration
 
 ++++
 <titleabbrev>Integrate with machine learning</titleabbrev>

docs/apm/transactions.asciidoc

@@ -64,7 +64,7 @@ The transaction overview page is customized for the JavaScript RUM Agent.
 This page highlights things like *page load times*, *transactions per minute*, and even the *average page load duration distribution by country*.
 
 [role="screenshot"]
-image::apm/images/apm-geo-ui.jpg[average page load duration distribution]
+image::apm/images/apm-geo-ui.png[average page load duration distribution]
 
 This data is available due to the geo-ip and user agent pipelines being enabled by default,
 which allows for the capture of geo-location and user agent data.

docs/canvas/canvas-tutorial.asciidoc

@@ -14,7 +14,7 @@ For this tutorial, you'll need to add the <<add-sample-data, Sample eCommerce or
 
 Your first step to working with Canvas is to create a workpad.
 
-. Open the menu, then click *Kibana > Canvas*.
+. Open the menu, then go to *Canvas*.
 
 . On the *Canvas workpads* page, click *Create workpad*.
 

docs/canvas/canvas-workpad.asciidoc

@@ -20,7 +20,9 @@ To create a workpad, choose one of the following options:
 
 To use the background colors, images, and data of your choice, start with a blank workpad.
 
-. On the *Canvas workpads* page, click *Create workpad*.
+. Open the menu, then go to *Canvas*.
+
+. On the *Canvas workpads* view, click *Create workpad*.
 
 . Add a *Name* to your workpad.
 
@@ -41,7 +43,9 @@ image::images/canvas-background-color-picker.png[Canvas color picker]
 
 If you're unsure about where to start, you can use one of the preconfigured templates that come with Canvas.
 
-. On the *Canvas workpads* page, select *Templates*.
+. Open the menu, then go to *Canvas*.
+
+. On the *Canvas workpads* view, select *Templates*.
 
 . Click the preconfigured template that you want to use.
 
@@ -53,7 +57,9 @@ If you're unsure about where to start, you can use one of the preconfigured temp
 
 When you want to use a workpad that someone else has already started, import the JSON file into Canvas.
 
-To import a workpad, go to the *Canvas workpads* page, then click and drag the file to the *Import workpad JSON file* field.
+. Open the menu, then go to *Canvas*.
+
+. On the *Canvas workpads* view, click and drag the file to the *Import workpad JSON file* field.
 
 [float]
 [[sample-data-workpad]]

docs/dev-tools/console/console.asciidoc

@@ -7,7 +7,7 @@ Console enables you to interact with the REST API of {es}. You can:
 * View API documentation
 * Get your request history
 
-To get started, go to *Dev Tools > Console*.
+To get started, open the menu, go to *Dev Tools*, then click *Console*.
 
 [role="screenshot"]
 image::dev-tools/console/images/console.png["Console"]

docs/dev-tools/grokdebugger/index.asciidoc

@@ -35,7 +35,7 @@ is automatically enabled in {kib}.
 NOTE: If you're using {security}, you must have the `manage_pipeline`
 permission to use the Grok Debugger.
 
-. In the side navigation, click *DevTools*, then open the *Grok Debugger*. 
+. Open the menu, go to *Dev Tools*, then click *Grok Debugger*.
 . In *Sample Data*, enter a message that is representative of the data that you
 want to parse. For example:
 +

docs/dev-tools/painlesslab/index.asciidoc

@@ -12,6 +12,6 @@ process {ref}/docs-reindex.html[reindexed data], define complex
 <<watcher-create-advanced-watch, Watcher conditions>>,
 and work with data in other contexts.
 
-To get started, go to *Dev Tools > Painless Lab*.
+To get started, open the menu, go to *Dev Tools*, then click *Painless Lab*.
 
 image::dev-tools/painlesslab/images/painless-lab.png[Painless Lab]

docs/dev-tools/searchprofiler/getting-started.asciidoc

@@ -2,7 +2,7 @@
 [[profiler-getting-started]]
 === Getting Started
 
-The {searchprofiler} is automatically enabled in {kib}.  Go to *Dev Tools > Search Profiler*
+The {searchprofiler} is automatically enabled in {kib}. From the menu, go to *Dev Tools*, then click *Search Profiler*
 to get started.
 
 {searchprofiler} displays the names of the indices searched, the shards in each index,
@@ -11,10 +11,10 @@ with the query you want to profile and click *Profile*.
 
 The following example shows the results of profiling the `match_all` query.
 If we take a closer look at the information for the `.kibana_1` sample index, the
-Cumulative Time field shows us that the query took 0.067ms to execute.
+Cumulative Time field shows us that the query took 1.279ms to execute.
 
 [role="screenshot"]
-image::dev-tools/searchprofiler/images/query.png["{searchprofiler} example"]
+image::dev-tools/searchprofiler/images/overview.png["{searchprofiler} example"]
 
 
 [NOTE]

docs/development/core/server/kibana-plugin-core-server.sessionstoragecookieoptions.md

@@ -19,5 +19,6 @@ export interface SessionStorageCookieOptions<T>
 |  [encryptionKey](./kibana-plugin-core-server.sessionstoragecookieoptions.encryptionkey.md) | <code>string</code> | A key used to encrypt a cookie's value. Should be at least 32 characters long. |
 |  [isSecure](./kibana-plugin-core-server.sessionstoragecookieoptions.issecure.md) | <code>boolean</code> | Flag indicating whether the cookie should be sent only via a secure connection. |
 |  [name](./kibana-plugin-core-server.sessionstoragecookieoptions.name.md) | <code>string</code> | Name of the session cookie. |
+|  [sameSite](./kibana-plugin-core-server.sessionstoragecookieoptions.samesite.md) | <code>'Strict' &#124; 'Lax' &#124; 'None'</code> | Defines SameSite attribute of the Set-Cookie Header. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite |
 |  [validate](./kibana-plugin-core-server.sessionstoragecookieoptions.validate.md) | <code>(sessionValue: T &#124; T[]) =&gt; SessionCookieValidationResult</code> | Function called to validate a cookie's decrypted value. |
 

docs/development/core/server/kibana-plugin-core-server.sessionstoragecookieoptions.samesite.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [SessionStorageCookieOptions](./kibana-plugin-core-server.sessionstoragecookieoptions.md) &gt; [sameSite](./kibana-plugin-core-server.sessionstoragecookieoptions.samesite.md)
+
+## SessionStorageCookieOptions.sameSite property
+
+Defines SameSite attribute of the Set-Cookie Header. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite
+
+<b>Signature:</b>
+
+```typescript
+sameSite?: 'Strict' | 'Lax' | 'None';
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpattern._constructor_.md

@@ -9,19 +9,13 @@ Constructs a new instance of the `IndexPattern` class
 <b>Signature:</b>
 
 ```typescript
-constructor(id: string | undefined, getConfig: any, savedObjectsClient: SavedObjectsClientContract, apiClient: IIndexPatternsApiClient, patternCache: PatternCache, fieldFormats: FieldFormatsStartCommon, onNotification: OnNotification, onError: OnError);
+constructor(id: string | undefined, { getConfig, savedObjectsClient, apiClient, patternCache, fieldFormats, onNotification, onError, }: IndexPatternDeps);
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
 |  id | <code>string &#124; undefined</code> |  |
-|  getConfig | <code>any</code> |  |
-|  savedObjectsClient | <code>SavedObjectsClientContract</code> |  |
-|  apiClient | <code>IIndexPatternsApiClient</code> |  |
-|  patternCache | <code>PatternCache</code> |  |
-|  fieldFormats | <code>FieldFormatsStartCommon</code> |  |
-|  onNotification | <code>OnNotification</code> |  |
-|  onError | <code>OnError</code> |  |
+|  { getConfig, savedObjectsClient, apiClient, patternCache, fieldFormats, onNotification, onError, } | <code>IndexPatternDeps</code> |  |
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpattern.md

@@ -14,7 +14,7 @@ export declare class IndexPattern implements IIndexPattern
 
 |  Constructor | Modifiers | Description |
 |  --- | --- | --- |
-|  [(constructor)(id, getConfig, savedObjectsClient, apiClient, patternCache, fieldFormats, onNotification, onError)](./kibana-plugin-plugins-data-public.indexpattern._constructor_.md) |  | Constructs a new instance of the <code>IndexPattern</code> class |
+|  [(constructor)(id, { getConfig, savedObjectsClient, apiClient, patternCache, fieldFormats, onNotification, onError, })](./kibana-plugin-plugins-data-public.indexpattern._constructor_.md) |  | Constructs a new instance of the <code>IndexPattern</code> class |
 
 ## Properties
 

docs/discover/search.asciidoc

@@ -104,7 +104,9 @@ To save the current search:
 . Click *Save* in the Kibana toolbar.
 . Enter a name for the search and click *Save*.
 
-You can import, export and delete saved searches from *Management/Kibana/Saved Objects*.
+To import, export and delete saved searches:
+. Open the menu, then click *Stack Management.
+. From the {kib} menu, click *Saved Ojbects*.
 
 ==== Open a saved search
 To load a saved search into Discover:

docs/getting-started/tutorial-dashboard.asciidoc

@@ -1,17 +1,18 @@
 [[tutorial-dashboard]]
-=== Add visualizations to a dashboard
+=== Add the visualizations to a dashboard
 
-A dashboard is a collection of visualizations that you can arrange and share.
-You'll build a dashboard that contains the visualizations and map that you saved during
+Build a dashboard that contains the visualizations and map that you saved during
 this tutorial.
 
-. Open *Dashboard*.
-. On the Dashboard overview page, click *Create new dashboard*.
+. Open the menu, go to *Dashboard*, then click *Create dashboard*.
 . Set the time filter to May 18, 2015 to May 20, 2015.
-. Click *Add* in the menu bar.
-. Add *Bar Example*, *Map Example*, *Markdown Example*, and *Pie Example*.
+. Click *Add*, then select the following:
+ * *Bar Example*
+ * *Map Example*
+ * *Markdown Example*
+ * *Pie Example*
 +
-Your sample dashboard should look like this:
+Your sample dashboard looks like this:
 +
 [role="screenshot"]
 image::images/tutorial-dashboard.png[]
@@ -32,27 +33,21 @@ but sometimes you need to look at the actual data to
 understand what's really going on. You can inspect the data behind any visualization
 and view the {es} query used to retrieve it.
 
-. In the dashboard, hover the pointer over the pie chart, and then click the icon in the upper right.
-. From the *Options* menu, select *Inspect*.
+. Click the pie chart *Options* menu, then select *Inspect*.
 +
 [role="screenshot"]
 image::images/tutorial-full-inspect1.png[]
 
-. To look at the query used to fetch the data for the visualization, select *View > Requests*
-in the upper right of the Inspect pane.
+. To look at the query used to fetch the data for the visualization, select *View > Requests*.
 
 [float]
 === Next steps
 
-Now that you have a handle on the basics, you're ready to start exploring
-your own data with Kibana.
-
-* See {kibana-ref}/discover.html[Discover] for information about searching and filtering
-your data.
-* See {kibana-ref}/visualize.html[Visualize] for information about the visualization
-types Kibana has to offer.
-* See {kibana-ref}/management.html[Management] for information about configuring Kibana
-and managing your saved objects.
-* See {kibana-ref}/console-kibana.html[Console] to learn about the interactive
-console you can use to submit REST requests to Elasticsearch.
+Now that you have the basics, you're ready to start exploring
+your own data with {kib}.
+
+* To learn about searching and filtering your data, refer to {kibana-ref}/discover.html[Discover].
+* To learn about the visualization types {kib} has to offer, refer to {kibana-ref}/visualize.html[Visualize].
+* To learn about configuring {kib} and managing your saved objects, refer to {kibana-ref}/management.html[Management].
+* To learn about the interactive console you can use to submit REST requests to {es}, refer to {kibana-ref}/console-kibana.html[Console].
 

docs/getting-started/tutorial-define-index.asciidoc

@@ -18,35 +18,35 @@ First you'll create index patterns for the Shakespeare data set, which has an
 index named `shakespeare,` and the accounts data set, which has an index named
 `bank`. These data sets don't contain time series data.
 
-. In Kibana, open *Management*, and then click *Index Patterns.*
-. If this is your first index pattern, the *Create index pattern* page opens automatically.
+. Open the menu, then go to *Stack Management > {kib} > Index Patterns*.
+. If this is your first index pattern, the *Create index pattern* page opens.
 Otherwise, click *Create index pattern*.
-. Enter `shakes*` in the *Index pattern* field.
+. In the *Index pattern field*, enter `shakes*`.
 +
 [role="screenshot"]
 image::images/tutorial-pattern-1.png[]
 
 . Click *Next step*.
-. In *Configure settings*, click *Create index pattern*.
+. Select the *Time Filter field name*, then click *Create index pattern*.
 +
 You’re presented a table of all fields and associated data types in the index.
 
-. Return to the *Index patterns* overview page and define a second index pattern named  `ba*`. 
+. Return to the *Index patterns* page and create a second index pattern named  `ba*`. 
 
 [float]
-==== Create an index pattern for time series data
+==== Create an index pattern for the time series data
 
-Now create an index pattern for the Logstash index, which
-contains time series data.
+Create an index pattern for the Logstash index, which
+contains the time series data.
 
 . Define an index pattern named `logstash*`.
 . Click *Next step*.
-. Open the *Time Filter field name* dropdown and select *@timestamp*.
+. From the *Time Filter field name* dropdown, select *@timestamp*.
 . Click *Create index pattern*.
 
 NOTE: When you define an index pattern, the indices that match that pattern must
 exist in Elasticsearch and they must contain data. To check which indices are
-available, go to *Dev Tools > Console* and enter `GET _cat/indices`.  Alternately, use
+available, open the menu, then go to *Dev Tools > Console* and enter `GET _cat/indices`.  Alternately, use
 `curl -XGET "http://localhost:9200/_cat/indices"`.
 
 

docs/getting-started/tutorial-discovering.asciidoc

@@ -5,15 +5,15 @@ Using *Discover*, enter
 an {ref}/query-dsl-query-string-query.html#query-string-syntax[Elasticsearch
 query] to search your data and filter the results.
 
-. Open *Discover*.
+. Open the menu, then go to *Discover*.
 +
 The `shakes*` index pattern appears.
 
-. To make `ba*` the current index, click the index pattern dropdown, then select `ba*`.
+. To make `ba*` the index, click the *Change Index Pattern* dropdown, then select `ba*`.
 +
 By default, all fields are shown for each matching document.
 
-. In the search field, enter:
+. In the *Search* field, enter the following:
 +
 [source,text]
 account_number<100 AND balance>47500
@@ -25,7 +25,7 @@ excess of 47,500. Results appear for account numbers 8, 32, 78, 85, and 97.
 image::images/tutorial-discover-2.png[]
 +
 . Hover over the list of *Available fields*, then
-click *add* next to each field you want include as a column in the table.
+click *Add* next to each field you want include in the table.
 +
 For example, when you add the `account_number` field, the display changes to a list of five
 account numbers.

docs/getting-started/tutorial-full-experience.asciidoc

@@ -94,7 +94,7 @@ You must also have the `create`, `manage` `read`, `write,` and `delete`
 index privileges. See {ref}/security-privileges.html[Security privileges] 
 for more information.
 
-In Kibana *Dev Tools > Console*, set up a mapping for the Shakespeare data set:
+Open *Dev Tools*. On the *Console* page, set up a mapping for the Shakespeare data set:
 
 [source,js]
 PUT /shakespeare