Skip to content

Commit

Permalink
added comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jloleysens committed Feb 14, 2023
1 parent e46577e commit a7ce4de
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/core/http/core-http-server/src/router/scratch_pad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,9 @@ type Version = '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9' | '10';
* 2. We can treat the versioning implementation as an open source protocol.
* Consumers can choose to create their own implementation (but increase maintenance).
* 3. Removes only the boilerplate regarding versions
* 4. Could also implement a simplified version that just takeas in a bunch of validations
* and passes them all to one handler, then the consumer must specify if-else/map/switch
* to correctly handle versions.
* WEAKNESSES:
* 1. Whole new API to design and implement
* 2. Will it actually be used since this is only a recommendation?
Expand Down

0 comments on commit a7ce4de

Please sign in to comment.