Skip to content

Commit

Permalink
[8.8] Minor copy edit in Create Search Application Flyout (#156116) (#…
Browse files Browse the repository at this point in the history
…156200)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Minor copy edit in Create Search Application Flyout
(#156116)](#156116)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kathleen
DeRusso","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-28T16:03:40Z","message":"Minor
copy edit in Create Search Application Flyout (#156116)\n\n##
Summary\r\n\r\nA minor copy edit to the Create Search Application
flyout, as
requested\r\n[here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).\r\n\r\nPer
the thread in the request, the popover is changed but the
callout\r\nremains the same.\r\n<img width=\"457\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png\">\r\n<img
width=\"631\" alt=\"Screenshot 2023-04-28 at 8 53 55
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png\">","sha":"53e7cd943ec78aa2e620d1b3933a75359f49c47f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.8.0","v8.9.0"],"number":156116,"url":"https://github.com/elastic/kibana/pull/156116","mergeCommit":{"message":"Minor
copy edit in Create Search Application Flyout (#156116)\n\n##
Summary\r\n\r\nA minor copy edit to the Create Search Application
flyout, as
requested\r\n[here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).\r\n\r\nPer
the thread in the request, the popover is changed but the
callout\r\nremains the same.\r\n<img width=\"457\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png\">\r\n<img
width=\"631\" alt=\"Screenshot 2023-04-28 at 8 53 55
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png\">","sha":"53e7cd943ec78aa2e620d1b3933a75359f49c47f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156116","number":156116,"mergeCommit":{"message":"Minor
copy edit in Create Search Application Flyout (#156116)\n\n##
Summary\r\n\r\nA minor copy edit to the Create Search Application
flyout, as
requested\r\n[here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).\r\n\r\nPer
the thread in the request, the popover is changed but the
callout\r\nremains the same.\r\n<img width=\"457\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png\">\r\n<img
width=\"631\" alt=\"Screenshot 2023-04-28 at 8 53 55
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png\">","sha":"53e7cd943ec78aa2e620d1b3933a75359f49c47f"}}]}]
BACKPORT-->

Co-authored-by: Kathleen DeRusso <[email protected]>
  • Loading branch information
kibanamachine and kderusso authored Apr 28, 2023
1 parent 1d581aa commit a5b0071
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('CreateEngineButton', () => {

expect(popover).toHaveLength(1);
expect(popover.text()).toMatch(
'This functionality is in technical preview and may be changed or removed completely in a future release.'
'This functionality may be changed or removed completely in a future release.'
);
});
});
Expand Down Expand Up @@ -177,7 +177,7 @@ describe('CreateEngineButton', () => {

expect(popover).toHaveLength(1);
expect(popover.text()).toMatch(
'This functionality is in technical preview and may be changed or removed completely in a future release.'
'This functionality may be changed or removed completely in a future release.'
);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export const CreateEngineButton: React.FC<CreateEngineButtonProps> = ({ disabled
<EuiText size="s">
<FormattedMessage
id="xpack.enterpriseSearch.content.searchApplications.createEngineTechnicalPreviewPopover.body"
defaultMessage="This functionality is in technical preview and may be changed or removed completely in a future release. Elastic will take a best effort approach to fix any issues, but features in technical preview are not subject to the support SLA of official GA features."
defaultMessage="This functionality may be changed or removed completely in a future release."
/>
</EuiText>
</EuiFlexGroup>
Expand Down

0 comments on commit a5b0071

Please sign in to comment.