PR amendments

elastic · May 31, 2024 · a3e04b2 · a3e04b2
1 parent d6c1028
commit a3e04b2
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/...n-unified-data-table/src/components/compare_documents/hooks/use_comparison_cell_value.tsx b/...n-unified-data-table/src/components/compare_documents/hooks/use_comparison_cell_value.tsx
@@ -174,9 +174,12 @@ const FieldCellValue = ({
           className={FIELD_NAME_CLASS}
           data-test-subj="unifiedDataTableComparisonFieldName"
         >
-          {field?.displayName ?? fieldName}{' '}
+          {field?.displayName ?? fieldName}
           {isDerivedAsPartOfSmartField ? (
-            <SmartFieldFallbackTooltip associatedSmartFields={associatedSmartFields} />
+            <>
+              {' '}
+              <SmartFieldFallbackTooltip associatedSmartFields={associatedSmartFields} />
+            </>
           ) : null}
         </EuiText>
       </EuiFlexItem>

diff --git a/...s/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx b/...s/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx
@@ -78,7 +78,7 @@ export type UnifiedFieldListSidebarCustomizableProps = Pick<
   /**
    * Prop to pass additional field groups to the field list
    */
-  additionalFieldGroups?: AdditionalFieldGroups;
+  additionalFieldGroups?: AdditionalFieldGroups<DataViewField>;
 };
 
 interface UnifiedFieldListSidebarInternalProps {

diff --git a/packages/kbn-unified-field-list/src/hooks/use_grouped_fields.ts b/packages/kbn-unified-field-list/src/hooks/use_grouped_fields.ts
@@ -20,6 +20,7 @@ import {
   type OverrideFieldGroupDetails,
   FieldsGroupNames,
   ExistenceFetchStatus,
+  AdditionalFieldGroups,
 } from '../types';
 import { useExistingFieldsReader } from './use_existing_fields';
 import {
@@ -43,9 +44,7 @@ export interface GroupedFieldsParams<T extends FieldListItem> {
   onSupportedFieldFilter?: (field: T) => boolean;
   onSelectedFieldFilter?: (field: T) => boolean;
   getNewFieldsBySpec?: UseNewFieldsParams<T>['getNewFieldsBySpec'];
-  additionalFieldGroups?: {
-    smartFields?: FieldsGroup<T>['fields'];
-  };
+  additionalFieldGroups?: AdditionalFieldGroups<T>;
 }
 
 export interface GroupedFieldsResult<T extends FieldListItem> {

diff --git a/packages/kbn-unified-field-list/src/types.ts b/packages/kbn-unified-field-list/src/types.ts
@@ -84,8 +84,8 @@ export type FieldListGroups<T extends FieldListItem> = {
   [key in FieldsGroupNames]?: FieldsGroup<T>;
 };
 
-export interface AdditionalFieldGroups {
-  smartFields?: FieldsGroup<DataViewField>['fields'];
+export interface AdditionalFieldGroups<T extends FieldListItem = FieldListItem> {
+  smartFields?: FieldsGroup<T>['fields'];
   fallbackFields?: Record<string, string[]>;
 }
 

diff --git a/...ugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx b/...ugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx
@@ -68,9 +68,12 @@ export const FieldStatisticsTable = (props: FieldStatisticsTableProps) => {
 
       return (
         <>
-          {displayName}{' '}
+          {displayName}
           {isDerivedAsPartOfSmartField ? (
-            <SmartFieldFallbackTooltip associatedSmartFields={associatedSmartFields} />
+            <>
+              {' '}
+              <SmartFieldFallbackTooltip associatedSmartFields={associatedSmartFields} />
+            </>
           ) : null}
         </>
       );