review feedback

elastic · Jun 6, 2024 · a323be8 · a323be8
1 parent 417e5d2
commit a323be8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.test.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.test.tsx
@@ -124,6 +124,20 @@ describe('ShowShareModal', () => {
       query: { query: 'bye', language: 'kuery' },
     } as unknown as DashboardContainerInput;
     const showModalProps = getPropsAndShare(unsavedDashboardState);
+    showModalProps.getDashboardState = () => {
+      return {
+        panels: {
+          panel_1: {
+            type: 'panel_type',
+            gridData: { w: 0, h: 0, x: 0, y: 0, i: '0' },
+            panelRefName: 'superPanel',
+            explicitInput: {
+              id: 'superPanel',
+            },
+          },
+        },
+      } as unknown as DashboardContainerInput;
+    };
     ShowShareModal(showModalProps);
     expect(toggleShareMenuSpy).toHaveBeenCalledTimes(1);
     const shareLocatorParams = (

diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.tsx
@@ -157,10 +157,9 @@ export function ShowShareModal({
         }, {} as DashboardPanelMap)
       : {};
 
-    // this dashboard has unsaved panels.
+    //
     const allUnsavedPanelsMap = {
       ...latestPanels,
-      ...(unsavedDashboardState?.panels ?? {}),
       ...modifiedPanels,
     };
     return convertPanelMapToSavedPanels(allUnsavedPanelsMap);