Move rule field names to package to limit bundle size impact

package.json

@@ -136,8 +136,8 @@
     "@kbn/logging": "link:bazel-bin/packages/kbn-logging/npm_module",
     "@kbn/monaco": "link:packages/kbn-monaco",
     "@kbn/securitysolution-constants": "link:bazel-bin/packages/kbn-securitysolution-constants/npm_module",
-    "@kbn/securitysolution-utils": "link:bazel-bin/packages/kbn-securitysolution-utils/npm_module",
     "@kbn/securitysolution-io-ts-utils": "link:bazel-bin/packages/kbn-securitysolution-io-ts-utils/npm_module",
+    "@kbn/securitysolution-utils": "link:bazel-bin/packages/kbn-securitysolution-utils/npm_module",
     "@kbn/server-http-tools": "link:packages/kbn-server-http-tools",
     "@kbn/server-route-repository": "link:packages/kbn-server-route-repository",
     "@kbn/std": "link:bazel-bin/packages/kbn-std/npm_module",
@@ -264,6 +264,7 @@
     "json-stringify-safe": "5.0.1",
     "jsonwebtoken": "^8.5.1",
     "jsts": "^1.6.2",
+    "@kbn/rule-data-utils": "link:packages/kbn-rule-data-utils",
     "kea": "^2.3.0",
     "leaflet": "1.5.1",
     "leaflet-draw": "0.4.14",

packages/kbn-rule-data-utils/jest.config.js

@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../..',
+  roots: ['<rootDir>/packages/kbn-rule-data-utils'],
+};

packages/kbn-rule-data-utils/package.json

@@ -0,0 +1,13 @@
+{
+  "name": "@kbn/rule-data-utils",
+  "main": "./target/index.js",
+  "types": "./target/index.d.ts",
+  "version": "1.0.0",
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "private": true,
+  "scripts": {
+    "build": "../../node_modules/.bin/tsc",
+    "kbn:bootstrap": "yarn build",
+    "kbn:watch": "yarn build --watch"
+  }
+}

packages/kbn-rule-data-utils/src/index.ts

@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export * from './technical_field_names';

packages/kbn-rule-data-utils/src/technical_field_names.ts

@@ -0,0 +1,77 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { ValuesType } from 'utility-types';
+
+const ALERT_NAMESPACE = 'kibana.rac.alert';
+
+const TIMESTAMP = '@timestamp' as const;
+const EVENT_KIND = 'event.kind' as const;
+const EVENT_ACTION = 'event.action' as const;
+const RULE_UUID = 'rule.uuid' as const;
+const RULE_ID = 'rule.id' as const;
+const RULE_NAME = 'rule.name' as const;
+const RULE_CATEGORY = 'rule.category' as const;
+const TAGS = 'tags' as const;
+const PRODUCER = `${ALERT_NAMESPACE}.producer` as const;
+const ALERT_ID = `${ALERT_NAMESPACE}.id` as const;
+const ALERT_UUID = `${ALERT_NAMESPACE}.uuid` as const;
+const ALERT_START = `${ALERT_NAMESPACE}.start` as const;
+const ALERT_END = `${ALERT_NAMESPACE}.end` as const;
+const ALERT_DURATION = `${ALERT_NAMESPACE}.duration.us` as const;
+const ALERT_SEVERITY_LEVEL = `${ALERT_NAMESPACE}.severity.level` as const;
+const ALERT_SEVERITY_VALUE = `${ALERT_NAMESPACE}.severity.value` as const;
+const ALERT_STATUS = `${ALERT_NAMESPACE}.status` as const;
+const ALERT_EVALUATION_THRESHOLD = `${ALERT_NAMESPACE}.evaluation.threshold` as const;
+const ALERT_EVALUATION_VALUE = `${ALERT_NAMESPACE}.evaluation.value` as const;
+
+const fields = {
+  TIMESTAMP,
+  EVENT_KIND,
+  EVENT_ACTION,
+  RULE_UUID,
+  RULE_ID,
+  RULE_NAME,
+  RULE_CATEGORY,
+  TAGS,
+  PRODUCER,
+  ALERT_ID,
+  ALERT_UUID,
+  ALERT_START,
+  ALERT_END,
+  ALERT_DURATION,
+  ALERT_SEVERITY_LEVEL,
+  ALERT_SEVERITY_VALUE,
+  ALERT_STATUS,
+  ALERT_EVALUATION_THRESHOLD,
+  ALERT_EVALUATION_VALUE,
+};
+
+export {
+  TIMESTAMP,
+  EVENT_KIND,
+  EVENT_ACTION,
+  RULE_UUID,
+  RULE_ID,
+  RULE_NAME,
+  RULE_CATEGORY,
+  TAGS,
+  PRODUCER,
+  ALERT_ID,
+  ALERT_UUID,
+  ALERT_START,
+  ALERT_END,
+  ALERT_DURATION,
+  ALERT_SEVERITY_LEVEL,
+  ALERT_SEVERITY_VALUE,
+  ALERT_STATUS,
+  ALERT_EVALUATION_THRESHOLD,
+  ALERT_EVALUATION_VALUE,
+};
+
+export type TechnicalRuleDataFieldName = ValuesType<typeof fields>;

packages/kbn-rule-data-utils/tsconfig.json

@@ -0,0 +1,19 @@
+{
+  "extends": "../../tsconfig.base.json",
+  "compilerOptions": {
+    "incremental": false,
+    "outDir": "./target",
+    "stripInternal": false,
+    "declaration": true,
+    "declarationMap": true,
+    "sourceMap": true,
+    "sourceRoot": "../../../../packages/kbn-rule-data-utils/src",
+    "types": [
+      "jest",
+      "node"
+    ]
+  },
+  "include": [
+    "./src/**/*.ts"
+  ]
+}

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

@@ -12,7 +12,7 @@ import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
   ALERT_SEVERITY_LEVEL,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import type { ObservabilityRuleTypeRegistry } from '../../../../observability/public';
 import { ENVIRONMENT_ALL } from '../../../common/environment_filter_values';
 import { AlertType } from '../../../common/alert_types';

x-pack/plugins/apm/public/components/app/ErrorGroupDetails/Distribution/index.tsx

@@ -19,7 +19,7 @@ import {
 import { EuiTitle } from '@elastic/eui';
 import d3 from 'd3';
 import React from 'react';
-import { RULE_ID } from '../../../../../../rule_registry/common/technical_rule_data_field_names';
+import { RULE_ID } from '@kbn/rule-data-utils/target/technical_field_names';
 import { useApmServiceContext } from '../../../../context/apm_service/use_apm_service_context';
 import { APIReturnType } from '../../../../services/rest/createCallApmApi';
 import { asRelativeDateTimeRange } from '../../../../../common/utils/formatters';

x-pack/plugins/apm/public/components/app/service_details/service_icons/alert_details.tsx

@@ -8,13 +8,13 @@ import React from 'react';
 import { EuiFlexGroup, EuiFlexItem, EuiLink } from '@elastic/eui';
 import { parse, format } from 'url';
 import { uniqBy } from 'lodash';
-import { parseTechnicalFields } from '../../../../../../rule_registry/common';
 import {
   ALERT_ID,
   ALERT_START,
   RULE_ID,
   RULE_NAME,
-} from '../../../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
+import { parseTechnicalFields } from '../../../../../../rule_registry/common';
 import { useUrlParams } from '../../../../context/url_params_context/use_url_params';
 import { useApmPluginContext } from '../../../../context/apm_plugin/use_apm_plugin_context';
 import { APIReturnType } from '../../../../services/rest/createCallApmApi';

x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx

@@ -14,7 +14,7 @@ import {
   RULE_ID,
   ALERT_START,
   ALERT_UUID,
-} from '../../../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { parseTechnicalFields } from '../../../../../../rule_registry/common';
 import { APIReturnType } from '../../../../services/rest/createCallApmApi';
 

x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx

@@ -9,7 +9,7 @@ import { EuiFlexGroup, EuiFlexItem, EuiSelect, EuiTitle } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import React from 'react';
 import { useHistory } from 'react-router-dom';
-import { RULE_ID } from '../../../../../../rule_registry/common/technical_rule_data_field_names';
+import { RULE_ID } from '@kbn/rule-data-utils/target/technical_field_names';
 import { AlertType } from '../../../../../common/alert_types';
 import { useApmServiceContext } from '../../../../context/apm_service/use_apm_service_context';
 import { LatencyAggregationType } from '../../../../../common/latency_aggregation_types';

x-pack/plugins/apm/server/lib/alerts/register_error_count_alert_type.ts

@@ -10,7 +10,7 @@ import { take } from 'rxjs/operators';
 import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';
 import { ENVIRONMENT_NOT_DEFINED } from '../../../common/environment_filter_values';
 import { asMutableArray } from '../../../common/utils/as_mutable_array';

x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_alert_type.ts

@@ -11,7 +11,7 @@ import { QueryContainer } from '@elastic/elasticsearch/api/types';
 import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';
 import { parseEnvironmentUrlParam } from '../../../common/environment_filter_values';
 import { AlertType, ALERT_TYPES_CONFIG } from '../../../common/alert_types';

x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_anomaly_alert_type.ts

@@ -9,6 +9,12 @@ import { schema } from '@kbn/config-schema';
 import { compact } from 'lodash';
 import { ESSearchResponse } from 'typings/elasticsearch';
 import { QueryContainer } from '@elastic/elasticsearch/api/types';
+import {
+  ALERT_EVALUATION_THRESHOLD,
+  ALERT_EVALUATION_VALUE,
+  ALERT_SEVERITY_LEVEL,
+  ALERT_SEVERITY_VALUE,
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';
 import { ProcessorEvent } from '../../../common/processor_event';
 import { getSeverity } from '../../../common/anomaly_detection';
@@ -30,12 +36,6 @@ import { getMLJobs } from '../service_map/get_service_anomalies';
 import { apmActionVariables } from './action_variables';
 import { RegisterRuleDependencies } from './register_apm_alerts';
 import { parseEnvironmentUrlParam } from '../../../common/environment_filter_values';
-import {
-  ALERT_EVALUATION_THRESHOLD,
-  ALERT_EVALUATION_VALUE,
-  ALERT_SEVERITY_LEVEL,
-  ALERT_SEVERITY_VALUE,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
 
 const paramsSchema = schema.object({
   serviceName: schema.maybe(schema.string()),

x-pack/plugins/apm/server/lib/alerts/register_transaction_error_rate_alert_type.ts

@@ -10,7 +10,7 @@ import { take } from 'rxjs/operators';
 import {
   ALERT_EVALUATION_THRESHOLD,
   ALERT_EVALUATION_VALUE,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { createLifecycleRuleTypeFactory } from '../../../../rule_registry/server';
 import { AlertType, ALERT_TYPES_CONFIG } from '../../../common/alert_types';
 import {

x-pack/plugins/apm/server/lib/services/get_service_alerts.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { ALERT_UUID } from '../../../../rule_registry/common/technical_rule_data_field_names';
+import { ALERT_UUID } from '@kbn/rule-data-utils/target/technical_field_names';
 import { RuleDataClient } from '../../../../rule_registry/server';
 import {
   SERVICE_NAME,

x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx

@@ -29,7 +29,7 @@ import {
   ALERT_SEVERITY_LEVEL,
   RULE_CATEGORY,
   RULE_NAME,
-} from '../../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { TopAlert } from '../';
 import { useUiSetting } from '../../../../../../../src/plugins/kibana_react/public';
 import { asDuration } from '../../../../common/utils/formatters';

x-pack/plugins/observability/public/pages/alerts/alerts_table.tsx

@@ -19,7 +19,7 @@ import React, { useState } from 'react';
 import {
   ALERT_DURATION,
   ALERT_SEVERITY_LEVEL,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
 import { asDuration } from '../../../common/utils/formatters';
 import { TimestampTooltip } from '../../components/shared/timestamp_tooltip';
 import { usePluginContext } from '../../hooks/use_plugin_context';

x-pack/plugins/observability/public/pages/alerts/index.tsx

@@ -17,16 +17,16 @@ import { i18n } from '@kbn/i18n';
 import React from 'react';
 import { useHistory } from 'react-router-dom';
 import { format, parse } from 'url';
-import {
-  ParsedTechnicalFields,
-  parseTechnicalFields,
-} from '../../../../rule_registry/common/parse_technical_fields';
 import {
   ALERT_START,
   EVENT_ACTION,
   RULE_ID,
   RULE_NAME,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+} from '@kbn/rule-data-utils/target/technical_field_names';
+import {
+  ParsedTechnicalFields,
+  parseTechnicalFields,
+} from '../../../../rule_registry/common/parse_technical_fields';
 import { asDuration, asPercent } from '../../../common/utils/formatters';
 import { ExperimentalBadge } from '../../components/shared/experimental_badge';
 import { useFetcher } from '../../hooks/use_fetcher';

x-pack/plugins/observability/server/lib/rules/get_top_alerts.ts

@@ -4,10 +4,7 @@
  * 2.0; you may not use this file except in compliance with the Elastic License
  * 2.0.
  */
-import {
-  ALERT_UUID,
-  TIMESTAMP,
-} from '../../../../rule_registry/common/technical_rule_data_field_names';
+import { ALERT_UUID, TIMESTAMP } from '@kbn/rule-data-utils/target/technical_field_names';
 import { RuleDataClient } from '../../../../rule_registry/server';
 import { kqlQuery, rangeQuery } from '../../utils/queries';
 

x-pack/plugins/rule_registry/common/technical_rule_data_field_names.ts

@@ -5,72 +5,4 @@
  * 2.0.
  */
 
-import { ValuesType } from 'utility-types';
-
-const ALERT_NAMESPACE = 'kibana.rac.alert';
-
-const TIMESTAMP = '@timestamp' as const;
-const EVENT_KIND = 'event.kind' as const;
-const EVENT_ACTION = 'event.action' as const;
-const RULE_UUID = 'rule.uuid' as const;
-const RULE_ID = 'rule.id' as const;
-const RULE_NAME = 'rule.name' as const;
-const RULE_CATEGORY = 'rule.category' as const;
-const TAGS = 'tags' as const;
-const PRODUCER = `${ALERT_NAMESPACE}.producer` as const;
-const ALERT_ID = `${ALERT_NAMESPACE}.id` as const;
-const ALERT_UUID = `${ALERT_NAMESPACE}.uuid` as const;
-const ALERT_START = `${ALERT_NAMESPACE}.start` as const;
-const ALERT_END = `${ALERT_NAMESPACE}.end` as const;
-const ALERT_DURATION = `${ALERT_NAMESPACE}.duration.us` as const;
-const ALERT_SEVERITY_LEVEL = `${ALERT_NAMESPACE}.severity.level` as const;
-const ALERT_SEVERITY_VALUE = `${ALERT_NAMESPACE}.severity.value` as const;
-const ALERT_STATUS = `${ALERT_NAMESPACE}.status` as const;
-const ALERT_EVALUATION_THRESHOLD = `${ALERT_NAMESPACE}.evaluation.threshold` as const;
-const ALERT_EVALUATION_VALUE = `${ALERT_NAMESPACE}.evaluation.value` as const;
-
-const fields = {
-  TIMESTAMP,
-  EVENT_KIND,
-  EVENT_ACTION,
-  RULE_UUID,
-  RULE_ID,
-  RULE_NAME,
-  RULE_CATEGORY,
-  TAGS,
-  PRODUCER,
-  ALERT_ID,
-  ALERT_UUID,
-  ALERT_START,
-  ALERT_END,
-  ALERT_DURATION,
-  ALERT_SEVERITY_LEVEL,
-  ALERT_SEVERITY_VALUE,
-  ALERT_STATUS,
-  ALERT_EVALUATION_THRESHOLD,
-  ALERT_EVALUATION_VALUE,
-};
-
-export {
-  TIMESTAMP,
-  EVENT_KIND,
-  EVENT_ACTION,
-  RULE_UUID,
-  RULE_ID,
-  RULE_NAME,
-  RULE_CATEGORY,
-  TAGS,
-  PRODUCER,
-  ALERT_ID,
-  ALERT_UUID,
-  ALERT_START,
-  ALERT_END,
-  ALERT_DURATION,
-  ALERT_SEVERITY_LEVEL,
-  ALERT_SEVERITY_VALUE,
-  ALERT_STATUS,
-  ALERT_EVALUATION_THRESHOLD,
-  ALERT_EVALUATION_VALUE,
-};
-
-export type TechnicalRuleDataFieldName = ValuesType<typeof fields>;
+export * from '@kbn/rule-data-utils/target/technical_field_names';