[Uptime] Delete useless try...catch blocks (#58263)

* Delete useless try...catch blocks. * Delete unneeded function. Co-authored-by: Elastic Machine <[email protected]>
elastic · Feb 24, 2020 · a00ebc6 · a00ebc6
1 parent 5eefdbb
commit a00ebc6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 23 deletions.
diff --git a/x-pack/legacy/plugins/uptime/public/hooks/use_telemetry.ts b/x-pack/legacy/plugins/uptime/public/hooks/use_telemetry.ts
@@ -22,13 +22,9 @@ const getApiPath = (page?: UptimePage) => {
 };
 
 const logPageLoad = async (fetch: HttpHandler, page?: UptimePage) => {
-  try {
-    await fetch(getApiPath(page), {
-      method: 'POST',
-    });
-  } catch (e) {
-    throw e;
-  }
+  await fetch(getApiPath(page), {
+    method: 'POST',
+  });
 };
 
 export const useUptimeTelemetry = (page?: UptimePage) => {

diff --git a/x-pack/legacy/plugins/uptime/server/lib/helper/index.ts b/x-pack/legacy/plugins/uptime/server/lib/helper/index.ts
@@ -7,6 +7,5 @@
 export { getFilterClause } from './get_filter_clause';
 export { parseRelativeDate } from './get_histogram_interval';
 export { getHistogramIntervalFormatted } from './get_histogram_interval_formatted';
-export { parseFilterQuery } from './parse_filter_query';
 export { assertCloseTo } from './assert_close_to';
 export { objectValuesToArrays } from './object_to_array';
diff --git a/x-pack/legacy/plugins/uptime/server/lib/helper/parse_filter_query.ts b/x-pack/legacy/plugins/uptime/server/lib/helper/parse_filter_query.ts
diff --git a/x-pack/legacy/plugins/uptime/server/lib/requests/get_ping_histogram.ts b/x-pack/legacy/plugins/uptime/server/lib/requests/get_ping_histogram.ts
@@ -5,7 +5,7 @@
  */
 
 import { UMElasticsearchQueryFn } from '../adapters';
-import { parseFilterQuery, getFilterClause } from '../helper';
+import { getFilterClause } from '../helper';
 import { INDEX_NAMES, QUERY } from '../../../common/constants';
 import { HistogramQueryResult } from './types';
 import { HistogramResult } from '../../../common/types';
@@ -27,7 +27,7 @@ export const getPingHistogram: UMElasticsearchQueryFn<
   GetPingHistogramParams,
   HistogramResult
 > = async ({ callES, from, to, filters, monitorId, statusFilter }) => {
-  const boolFilters = parseFilterQuery(filters);
+  const boolFilters = filters ? JSON.parse(filters) : null;
   const additionalFilters = [];
   if (monitorId) {
     additionalFilters.push({ match: { 'monitor.id': monitorId } });